[rpc] Remove deprecated rpc warnings #15642

1. 
   jnewbery commented at 2:34 PM on March 22, 2019: member

   Removes some deprecated code from the RPCs:

   • signrawtransaction was deprecated in 0.17 and removed in 0.18. A warning message was left in place to advise users to use signrawtransactionwithwallet and signrawtransactionwithkey. That warning can now be removed.
   • validateaddress had some functionality deprecated in 0.17 and removed in 0.18. The help text for that functionality was not removed in 0.18 and can be removed now.
2. [rpc] Remove signrawtransaction warning

   signrawtransaction was deprecated in 0.17 and removed in 0.18. A warning
   was left in place to tell users to migrate to using
   signrawtransactionswithwallet or signrawtransactionwithkey. Remove the
   warning now that it's been two releases since the method was removed.

   839c3f7c49
3. [rpc] Remove deprecated functionality message from validateaddress help

   This functionality was removed in v0.18.

   7b6616b78b
4. fanquake added the label RPC/REST/ZMQ on Mar 22, 2019
5. fanquake added this to the milestone 0.19.0 on Mar 22, 2019
6. 
   jnewbery commented at 2:35 PM on March 22, 2019: member

   One could argue that the second commit Remove deprecated functionality message from validateaddress help should be backported to 0.18, but I think it's so minor that it's not worth it.

7. 
   promag commented at 3:13 PM on March 22, 2019: member

   Maybe also replace in https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#L955?

8. 
   MarcoFalke commented at 5:25 PM on March 22, 2019: member

   ACK on the doc-backport

9. ryanofsky approved
10. 
    ryanofsky commented at 6:00 PM on March 22, 2019: member

    utACK 7b6616b78bd9f76502002db1a209a0363979e506. I would maybe change pr summary from "Remove deprecated rpc functionality" to "Remove deprecated rpc warnings" since "functionality" makes me think something more than error text is being removed.

11. jnewbery renamed this:
    [rpc] Remove deprecated rpc functionality
    [rpc] Remove deprecated rpc warnings
    on Mar 22, 2019
12. [docs] remove reference to signrawtransaction in the developer docs. 947f73ceba
13. 
    jnewbery commented at 7:18 PM on March 22, 2019: member

    Maybe also replace in https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#L955?

    Done

14. 
    achow101 commented at 7:25 PM on March 22, 2019: member

    utACK 947f73ceba7d74153fe83b538e42be1dfe77aea4

15. 
    MarcoFalke commented at 7:52 PM on March 22, 2019: member

    utACK 947f73ceba7d74153fe83b538e42be1dfe77aea4

16. 
    fanquake commented at 12:06 AM on March 23, 2019: member

    utACK 947f73c

17. 
    promag commented at 12:16 AM on March 23, 2019: member

    utACK 947f73c.

18. laanwj merged this on Mar 23, 2019
19. laanwj closed this on Mar 23, 2019

    ---

20. laanwj referenced this in commit 7b13c64645 on Mar 23, 2019
21. vijaydasmp referenced this in commit 1357c6f06b on Oct 12, 2021
22. vijaydasmp referenced this in commit f46e77a3b4 on Oct 14, 2021
23. vijaydasmp referenced this in commit db56b83030 on Oct 14, 2021
24. vijaydasmp referenced this in commit 617941fd8b on Oct 16, 2021
25. PastaPastaPasta referenced this in commit 6e32a464f5 on Oct 21, 2021
26. pravblockc referenced this in commit da6c7a6715 on Nov 18, 2021
27. DrahtBot locked this on Dec 16, 2021

Contributors

jnewberypromagMarcoFalkeryanofskyachow101fanquake

Milestone
0.19.0