crypto: Remove unused AES-128 code #15663

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:aes-128 changing 3 files +0 −200
  1. practicalswift commented at 2:14 PM on March 25, 2019: contributor

    Remove unused AES-128 code.

    As far as I can tell this AES-128 code has never been in use in the project (outside of testing/benchmarking).

    The AES-256 code is used in CCrypter::Encrypt/CCrypter::Decrypt (src/wallet/crypter.cpp).

    Trivia: 0.15% of the project's C++ LOC count (excluding dependencies) is trimmed off:

    $ LOC_BEFORE=$(git grep -I "" HEAD~1 -- "*.cpp" "*.h" ":(exclude)src/leveldb/" ":(exclude)src/secp256k1/" ":(exclude)src/univalue/" | wc -l)
    $ LOC_AFTER=$(git grep -I "" -- "*.cpp" "*.h" ":(exclude)src/leveldb/" ":(exclude)src/secp256k1/" ":(exclude)src/univalue/" | wc -l)
    $ bc <<< "scale=4; ${LOC_AFTER}/${LOC_BEFORE}"
    .9985
    

    :-)

  2. Remove unused AES-128 code f6ee177f7d
  3. practicalswift renamed this:
    Remove unused AES-128 code
    crypto: Remove unused AES-128 code
    on Mar 25, 2019
  4. fanquake added the label Refactoring on Mar 25, 2019
  5. sipa commented at 11:13 PM on March 25, 2019: member

    utACK f6ee177f7d8d4a8220e6ba4f0d5f68830fe1c817

  6. promag commented at 9:13 AM on March 26, 2019: member

    utACK f6ee177.

  7. fanquake commented at 10:54 PM on March 26, 2019: member

    utACK f6ee177

  8. jonasschnelli commented at 9:21 AM on March 29, 2019: contributor

    utACK f6ee177f7d8d4a8220e6ba4f0d5f68830fe1c817

  9. jonasschnelli merged this on Mar 29, 2019
  10. jonasschnelli closed this on Mar 29, 2019

  11. jonasschnelli referenced this in commit edc68d40e9 on Mar 29, 2019
  12. practicalswift deleted the branch on Apr 10, 2021
  13. PastaPastaPasta referenced this in commit 750ace53c7 on Jun 27, 2021
  14. PastaPastaPasta referenced this in commit 85a1fb42ae on Jun 28, 2021
  15. PastaPastaPasta referenced this in commit 2fa8f69d12 on Jun 29, 2021
  16. PastaPastaPasta referenced this in commit cf60d090eb on Jul 1, 2021
  17. PastaPastaPasta referenced this in commit bf4feb3f80 on Jul 1, 2021
  18. PastaPastaPasta referenced this in commit fc364bb2e4 on Jul 8, 2021
  19. PastaPastaPasta referenced this in commit b902736621 on Jul 10, 2021
  20. DrahtBot locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-16 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me