doc: rpc-mining: Clarify error messages #15685

1. 
   MarcoFalke commented at 1:02 pm on March 28, 2019: member

   Fixes #13274
2. DrahtBot added the label Docs on Mar 28, 2019
3. DrahtBot added the label RPC/REST/ZMQ on Mar 28, 2019
4. 
   practicalswift commented at 1:07 pm on March 28, 2019: contributor

   ACK fa642d770e4606e005fc41e8155ed48d2a9c5532
5. in src/rpc/mining.cpp:447 in fa642d770e outdated

   443@@ -444,10 +444,10 @@ static UniValue getblocktemplate(const JSONRPCRequest& request)
   444         throw JSONRPCError(RPC_CLIENT_P2P_DISABLED, "Error: Peer-to-peer functionality missing or disabled");
   445 
   446     if (g_connman->GetNodeCount(CConnman::CONNECTIONS_ALL) == 0)
   447-        throw JSONRPCError(RPC_CLIENT_NOT_CONNECTED, "Bitcoin is not connected!");
   448+        throw JSONRPCError(RPC_CLIENT_NOT_CONNECTED, "Bitcoin Core is not connected!");
   

   ---

   ---

   

   luke-jr commented at 1:14 pm on March 28, 2019:

   Should be using PACKAGE_NAME
6. MarcoFalke removed the label Docs on Mar 28, 2019
7. MarcoFalke removed the label RPC/REST/ZMQ on Mar 28, 2019
8. DrahtBot added the label Docs on Mar 28, 2019
9. DrahtBot added the label Mining on Mar 28, 2019
10. DrahtBot added the label RPC/REST/ZMQ on Mar 28, 2019
11. MarcoFalke force-pushed on Mar 28, 2019
12. 
    MarcoFalke commented at 1:27 pm on March 28, 2019: member

    Using PACKAGE_NAME:

    

13. in src/rpc/mining.cpp:447 in fa784ee74e outdated

    443@@ -444,10 +444,10 @@ static UniValue getblocktemplate(const JSONRPCRequest& request)
    444         throw JSONRPCError(RPC_CLIENT_P2P_DISABLED, "Error: Peer-to-peer functionality missing or disabled");
    445 
    446     if (g_connman->GetNodeCount(CConnman::CONNECTIONS_ALL) == 0)
    447-        throw JSONRPCError(RPC_CLIENT_NOT_CONNECTED, "Bitcoin is not connected!");
    448+        throw JSONRPCError(RPC_CLIENT_NOT_CONNECTED, std::string{PACKAGE_NAME} + " is not connected!");
    

    ---

    ---

    

    luke-jr commented at 1:31 pm on March 28, 2019:

    Pretty sure you could do just:

    0        throw JSONRPCError(RPC_CLIENT_NOT_CONNECTED, PACKAGE_NAME " is not connected!");
    

    but this works too. 

    ---

    

    MarcoFalke commented at 1:59 pm on March 28, 2019:

    Used this for brevity
14. doc: rpc-mining: Clarify error messages fa292adce9
15. MarcoFalke force-pushed on Mar 28, 2019
16. 
    DrahtBot commented at 1:40 pm on March 28, 2019: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #15606 ([experimental] UTXO snapshots by jamesob)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

17. luke-jr approved
18. 
    fanquake commented at 2:44 pm on April 3, 2019: member

    tACK fa292ad

    

19. MarcoFalke referenced this in commit ba54342c9d on Apr 3, 2019
20. MarcoFalke merged this on Apr 3, 2019
21. MarcoFalke closed this on Apr 3, 2019

    ---

22. MarcoFalke deleted the branch on Apr 3, 2019
23. vijaydasmp referenced this in commit 8dfd53f942 on Oct 5, 2021
24. vijaydasmp referenced this in commit 1fcb154575 on Oct 12, 2021
25. vijaydasmp referenced this in commit 3c37a0751e on Oct 14, 2021
26. vijaydasmp referenced this in commit 685e458821 on Oct 14, 2021
27. vijaydasmp referenced this in commit 5df5656e01 on Oct 16, 2021
28. PastaPastaPasta referenced this in commit 6e32a464f5 on Oct 21, 2021
29. pravblockc referenced this in commit d5e042d53c on Nov 18, 2021
30. DrahtBot locked this on Dec 16, 2021

Contributors
MarcoFalke practicalswift luke-jr DrahtBot fanquake

Labels
Docs RPC/REST/ZMQ Mining