build: Check QT library version #15706

pull lucayepa wants to merge 1 commits into bitcoin:master from lucayepa:check-qt-version changing 1 files +26 −16
  1. lucayepa commented at 2:19 PM on March 30, 2019: contributor

    Fixes #15688

    Due to a bug, the version of the QT library was not checked at configure time for systems using pkg-config. Without any check at configure time, the build process stopped with unexplicative errors on systems with QT versions not supported.

    This PR introduces the control of the version of the QT library, with a warning, or an error, at configure time, if the installed version is not supported.

    Tested in all the following cases (all combinations):

    • on Debian Jessie (QT 5.3.2) and on Debian Stretch (QT 5.7.1)
    • with depends system (QT 5.9.7) enabled and disabled
    • with --with-gui and --without-gui on configure command line

    Since the current 0.18 branch is affected, with compilation errors on some systems, like Debian Jessie (EOL on June 30, 2020), I suggest to include this low impact PR in 0.18.

  2. fanquake added the label Build system on Mar 30, 2019
  3. MarcoFalke renamed this:
    Check QT library version
    build: Check QT library version
    on Mar 30, 2019
  4. MarcoFalke added the label Needs gitian build on Mar 30, 2019
  5. MarcoFalke added this to the milestone 0.18.1 on Mar 30, 2019
  6. MarcoFalke added the label Needs backport on Mar 30, 2019
  7. DrahtBot removed the label Needs gitian build on Mar 31, 2019
  8. fanquake requested review from theuni on Apr 16, 2019
  9. laanwj commented at 6:40 PM on May 16, 2019: member

    Concept ACK, can you take a look at the build system changes please @theuni

  10. in build-aux/m4/bitcoin_qt.m4:443 in 9d74d35dfc outdated 
     429 | +        PKG_CHECK_EXISTS(Qt5Core < 5.5.1,[bitcoin_cv_qt55=no],[bitcoin_cv_qt55=yes])
 430 | +      )
 431 | +    ])
 432 | +    BITCOIN_QT_CHECK([
 433 | +      AC_CACHE_CHECK(for > Qt 5.7,bitcoin_cv_qt58,
 434 | +        PKG_CHECK_EXISTS(Qt5Core < 5.8.0,[bitcoin_cv_qt58=no],[bitcoin_cv_qt58=yes])
    laanwj commented at 2:56 PM on June 6, 2019:

    Message should mention > Qt 5.8 to be consistent

    lucayepa commented at 2:27 PM on July 19, 2019:

    I think it is consistent. "Check that QT > 5.7" means that it is 5.8 or more. This is the same as above: "check that QT > 5.4", that means it is 5.5 or more. The same message is used some rows above (275):

    AC_CACHE_CHECK(for > Qt 5.7, bitcoin_cv_qt58,[
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
    laanwj commented at 12:26 PM on September 30, 2019:

    I think that's confusing. > Qt 5.7 means newer than 5.7, so may also mean 5.7.1 or whatever, at least at a cursory glance.

    If you're concerned about lawyering correctness of > versus >= feel free to make it >=5.8 instead.

    lucayepa commented at 9:44 PM on October 3, 2019:

    I think you are right. 5.7.1 is a good example. I'll amend the commit.

  11. MarcoFalke deleted a comment on Jun 16, 2019
  12. MarcoFalke added the label Needs gitian build on Jun 16, 2019
  13. laanwj added the label Waiting for author on Jun 17, 2019
  14. DrahtBot removed the label Needs gitian build on Jun 18, 2019
  15. MarcoFalke deleted a comment on Jun 18, 2019
  16. MarcoFalke removed this from the milestone 0.18.1 on Jul 18, 2019
  17. laanwj added this to the milestone 0.18.2 on Jul 18, 2019
  18. MarcoFalke commented at 7:36 PM on July 18, 2019: member

    @lucayepa There has been a comment from @laanwj. Mind to address it?

  19. MarcoFalke deleted a comment on Jul 18, 2019
  20. fanquake removed the label Waiting for author on Sep 19, 2019
  21. fanquake requested review from dongcarl on Sep 19, 2019
  22. MarcoFalke added the label Waiting for author on Sep 30, 2019
  23. MarcoFalke removed the label Needs backport on Sep 30, 2019
  24. MarcoFalke removed this from the milestone 0.18.2 on Sep 30, 2019
  25. lucayepa force-pushed on Oct 3, 2019
  26. MarcoFalke removed the label Waiting for author on Oct 3, 2019
  27. MarcoFalke added the label Needs gitian build on Oct 3, 2019
  28. lucayepa commented at 10:50 PM on October 3, 2019: contributor

    I tested it on an affected machine.

    Are we in time to add back the 0.18.2 tag?

  29. laanwj added the label Needs backport (0.19) on Oct 4, 2019
  30. laanwj added the label Needs backport (0.18) on Oct 4, 2019
  31. laanwj added this to the milestone 0.18.2 on Oct 4, 2019
  32. DrahtBot commented at 2:39 PM on October 4, 2019: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit a689c119076c7b8dc5b4dea4539e4cbf5adfb72f (master):

    Gitian builds for commit 7afe2eaa8ed75e0aa3657653abcddfae2c65c651 (master and this pull):

  33. DrahtBot removed the label Needs gitian build on Oct 4, 2019
  34. lucayepa referenced this in commit 050b3e6152 on Oct 4, 2019
  35. lucayepa referenced this in commit f1b6f527bf on Oct 4, 2019
  36. laanwj commented at 10:17 AM on October 5, 2019: member

    @dongcarl @theuni can one of you take a look here please

  37. in build-aux/m4/bitcoin_qt.m4:102 in 25e43fcd48 outdated 
      96 | @@ -99,6 +97,12 @@ AC_DEFUN([BITCOIN_QT_CONFIGURE],[
  97 |      BITCOIN_QT_CHECK([_BITCOIN_QT_FIND_LIBS_WITHOUT_PKGCONFIG])
  98 |    fi
  99 |  
 100 | +  BITCOIN_QT_CHECK([
 101 | +    if test "x$bitcoin_cv_qt551" != xyes; then
 102 | +      BITCOIN_QT_FAIL([Qt version not supported])
    luke-jr commented at 2:13 PM on November 4, 2019:

    configure shouldn't fail unless --with-gui is explicitly specified. Otherwise, it should just turn off GUI support...

    lucayepa commented at 8:28 PM on November 4, 2019:

    Yes, this is exactly the behavior. BITCOIN_QT_FAIL fails only if GUI has been requested. If not, it generates a warning. On a machine with Qt version 5.3.2 I get:

    configure                 -> WARNING: Qt version not supported; bitcoin-qt frontend will not be built
configure --with-gui      -> error: Qt version not supported
configure --without-gui   -> no errors nor warnings
  38. luke-jr changes_requested
  39. hebasto commented at 9:52 PM on December 28, 2019: member

    Concept ACK.

  40. in build-aux/m4/bitcoin_qt.m4:259 in 25e43fcd48 outdated 
     254 | @@ -252,9 +255,9 @@ dnl ----
 255 |  
 256 |  dnl Internal. Check included version of Qt against minimum specified in doc/dependencies.md
 257 |  dnl Requires: INCLUDES must be populated as necessary.
 258 | -dnl Output: bitcoin_cv_qt5=yes|no
 259 | -AC_DEFUN([_BITCOIN_QT_CHECK_QT5],[
 260 | -  AC_CACHE_CHECK(for Qt 5, bitcoin_cv_qt5,[
 261 | +dnl Output: bitcoin_cv_qt551=yes|no
 262 | +AC_DEFUN([_BITCOIN_QT_CHECK_QT551],[
    hebasto commented at 9:57 PM on December 28, 2019: 
    AC_DEFUN([_BITCOIN_QT_CHECK_MINIMUM_REQUIRED],[

    ... to minimize future changes.

    lucayepa commented at 10:07 PM on January 24, 2020:

    Ack.

  41. in build-aux/m4/bitcoin_qt.m4:260 in 25e43fcd48 outdated 
     254 | @@ -252,9 +255,9 @@ dnl ----
 255 |  
 256 |  dnl Internal. Check included version of Qt against minimum specified in doc/dependencies.md
 257 |  dnl Requires: INCLUDES must be populated as necessary.
 258 | -dnl Output: bitcoin_cv_qt5=yes|no
 259 | -AC_DEFUN([_BITCOIN_QT_CHECK_QT5],[
 260 | -  AC_CACHE_CHECK(for Qt 5, bitcoin_cv_qt5,[
 261 | +dnl Output: bitcoin_cv_qt551=yes|no
 262 | +AC_DEFUN([_BITCOIN_QT_CHECK_QT551],[
 263 | +  AC_CACHE_CHECK(for Qt >= 5.5.1, bitcoin_cv_qt551,[
    hebasto commented at 9:59 PM on December 28, 2019: 
      AC_CACHE_CHECK(for Qt >= 5.5.1, bitcoin_cv_qtminimumrequired,[

    ... to minimize future changes.

    lucayepa commented at 10:07 PM on January 24, 2020:

    Ack

  42. in build-aux/m4/bitcoin_qt.m4:408 in 25e43fcd48 outdated 
     406 | @@ -404,8 +407,6 @@ AC_DEFUN([_BITCOIN_QT_FIND_STATIC_PLUGINS],[
 407 |  dnl Internal. Find Qt libraries using pkg-config.
 408 |  dnl Inputs: bitcoin_qt_want_version (from --with-gui=). The version to check
    hebasto commented at 10:05 PM on December 28, 2019:

    Is this comment still relevant?

    lucayepa commented at 10:14 PM on January 24, 2020:

    No. It is not. I remove it.

  43. hebasto changes_requested
  44. hebasto commented at 10:12 PM on December 28, 2019: member

    Please quote macro arguments with [ and ] consistently.

  45. DrahtBot commented at 1:28 AM on December 29, 2019: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #18361 (build: Make the help string for --with-gui configure option unambiguous by hebasto)
    • #18298 (build: Fix Qt processing of configure script for depends with DEBUG=1 by hebasto)
    • #18297 (build: Use pkg-config in BITCOIN_QT_CONFIGURE for all hosts including Windows by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  46. in build-aux/m4/bitcoin_qt.m4:432 in 25e43fcd48 outdated 
     426 | @@ -426,14 +427,25 @@ AC_DEFUN([_BITCOIN_QT_FIND_LIBS_WITH_PKGCONFIG],[
 427 |          PKG_CHECK_MODULES([QT_DBUS], [${QT_LIB_PREFIX}DBus], [QT_DBUS_INCLUDES="$QT_DBUS_CFLAGS"; have_qt_dbus=yes], [have_qt_dbus=no])
 428 |        fi
 429 |      ])
 430 | +    BITCOIN_QT_CHECK([
 431 | +      AC_CACHE_CHECK(for Qt >= 5.5.1,bitcoin_cv_qt551,
 432 | +        PKG_CHECK_EXISTS(Qt5Core < 5.5.1,[bitcoin_cv_qt551=no],[bitcoin_cv_qt551=yes])
    hebasto commented at 9:24 PM on December 29, 2019:

    https://cgit.freedesktop.org/pkg-config/tree/pkg.m4.in#n81

    dnl PKG_CHECK_EXISTS(MODULES, [ACTION-IF-FOUND], [ACTION-IF-NOT-FOUND])`
dnl -------------------------------------------------------------------
dnl Since: 0.18
dnl
dnl Check to see whether a particular set of modules exists. Similar to
dnl PKG_CHECK_MODULES(), but does not set variables or print errors

    ~Does this usage of PKG_CHECK_EXISTS macro is correct?~

    hebasto commented at 1:19 PM on January 11, 2020:

    nm, a version specifier is ok.

  47. in build-aux/m4/bitcoin_qt.m4:443 in 25e43fcd48 outdated 
     432 | +        PKG_CHECK_EXISTS(Qt5Core < 5.5.1,[bitcoin_cv_qt551=no],[bitcoin_cv_qt551=yes])
 433 | +      )
 434 | +    ])
 435 | +    BITCOIN_QT_CHECK([
 436 | +      AC_CACHE_CHECK(for Qt >= 5.8.0,bitcoin_cv_qt58,
 437 | +        PKG_CHECK_EXISTS(Qt5Core < 5.8.0,[bitcoin_cv_qt58=no],[bitcoin_cv_qt58=yes])
    hebasto commented at 9:25 PM on December 29, 2019:

    ~Does this usage of PKG_CHECK_EXISTS macro is correct? (the same as https://github.com/bitcoin/bitcoin/pull/15706/files#r361873134)~

  48. jonasschnelli assigned theuni on Jan 5, 2020
  49. jonasschnelli assigned dongcarl on Jan 5, 2020
  50. jonasschnelli commented at 8:58 PM on January 5, 2020: contributor

    Concept ACK Assigned to @theuni / @dongcarl

  51. Check QT library version
    Fixes issue #15688

Due to a bug, in systems using pkg-config, the version of the Qt library is
not checked at configure time. Without any check, when Qt version is not
supported, the build process stops with unexpleined errors.

This PR introduces the control of the version of the QT library, returning
a warning or an error at configure time, when the installed version is not
supported.
    35c46bcb68
  52. lucayepa force-pushed on Jan 24, 2020
  53. in build-aux/m4/bitcoin_qt.m4:438 in 35c46bcb68 
     432 | @@ -434,14 +433,25 @@ AC_DEFUN([_BITCOIN_QT_FIND_LIBS_WITH_PKGCONFIG],[
 433 |          PKG_CHECK_MODULES([QT_DBUS], [${QT_LIB_PREFIX}DBus], [QT_DBUS_INCLUDES="$QT_DBUS_CFLAGS"; have_qt_dbus=yes], [have_qt_dbus=no])
 434 |        fi
 435 |      ])
 436 | +    BITCOIN_QT_CHECK([
 437 | +      AC_CACHE_CHECK(for Qt >= 5.5.1,bitcoin_cv_qt_minimumrequired,
 438 | +        PKG_CHECK_EXISTS(Qt5Core < 5.5.1,[bitcoin_cv_qt_minimumrequired=no],[bitcoin_cv_qt_minimumrequired=yes])
    hebasto commented at 9:09 AM on January 26, 2020:

    non-blocking nit, for consistency with "for Qt >= 5.5.1":

            PKG_CHECK_EXISTS(Qt5Core >= 5.5.1,[bitcoin_cv_qt_minimumrequired=yes],[bitcoin_cv_qt_minimumrequired=no])
  54. in build-aux/m4/bitcoin_qt.m4:443 in 35c46bcb68 
     438 | +        PKG_CHECK_EXISTS(Qt5Core < 5.5.1,[bitcoin_cv_qt_minimumrequired=no],[bitcoin_cv_qt_minimumrequired=yes])
 439 | +      )
 440 | +    ])
 441 | +    BITCOIN_QT_CHECK([
 442 | +      AC_CACHE_CHECK(for Qt >= 5.8.0,bitcoin_cv_qt58,
 443 | +        PKG_CHECK_EXISTS(Qt5Core < 5.8.0,[bitcoin_cv_qt58=no],[bitcoin_cv_qt58=yes])
    hebasto commented at 9:12 AM on January 26, 2020:

    non-blocking nit, for consistency with "for Qt >= 5.8.0":

            PKG_CHECK_EXISTS(Qt5Core >= 5.8.0,[bitcoin_cv_qt58=yes],[bitcoin_cv_qt58=no])
  55. in build-aux/m4/bitcoin_qt.m4:265 in 35c46bcb68 
     259 | @@ -257,9 +260,9 @@ dnl ----
 260 |  
 261 |  dnl Internal. Check included version of Qt against minimum specified in doc/dependencies.md
 262 |  dnl Requires: INCLUDES must be populated as necessary.
 263 | -dnl Output: bitcoin_cv_qt5=yes|no
 264 | -AC_DEFUN([_BITCOIN_QT_CHECK_QT5],[
 265 | -  AC_CACHE_CHECK(for Qt 5, bitcoin_cv_qt5,[
 266 | +dnl Output: bitcoin_cv_qt_minimumrequired=yes|no
 267 | +AC_DEFUN([_BITCOIN_QT_CHECK_MINIMUM_REQUIRED],[
 268 | +  AC_CACHE_CHECK(for Qt >= 5.5.1, bitcoin_cv_qt_minimumrequired,[
    hebasto commented at 9:16 AM on January 26, 2020:

    non-blocking nit: here and in other places mind quoting the first argument:

      AC_CACHE_CHECK([for Qt >= 5.5.1], bitcoin_cv_qt_minimumrequired,[

    ?

  56. in build-aux/m4/bitcoin_qt.m4:285 in 35c46bcb68 
     284 | +dnl Internal. Check if the included version of Qt is >= 5.8.
 285 |  dnl Requires: INCLUDES must be populated as necessary.
 286 |  dnl Output: bitcoin_cv_qt58=yes|no
 287 |  AC_DEFUN([_BITCOIN_QT_CHECK_QT58],[
 288 | -  AC_CACHE_CHECK(for > Qt 5.7, bitcoin_cv_qt58,[
 289 | +  AC_CACHE_CHECK(for >= Qt 5.8, bitcoin_cv_qt58,[
    hebasto commented at 9:17 AM on January 26, 2020: 
      AC_CACHE_CHECK([for >= Qt 5.8], bitcoin_cv_qt58,[
  57. in build-aux/m4/bitcoin_qt.m4:437 in 35c46bcb68 
     432 | @@ -434,14 +433,25 @@ AC_DEFUN([_BITCOIN_QT_FIND_LIBS_WITH_PKGCONFIG],[
 433 |          PKG_CHECK_MODULES([QT_DBUS], [${QT_LIB_PREFIX}DBus], [QT_DBUS_INCLUDES="$QT_DBUS_CFLAGS"; have_qt_dbus=yes], [have_qt_dbus=no])
 434 |        fi
 435 |      ])
 436 | +    BITCOIN_QT_CHECK([
 437 | +      AC_CACHE_CHECK(for Qt >= 5.5.1,bitcoin_cv_qt_minimumrequired,
    hebasto commented at 9:18 AM on January 26, 2020: 
          AC_CACHE_CHECK([for Qt >= 5.5.1],bitcoin_cv_qt_minimumrequired,
  58. in build-aux/m4/bitcoin_qt.m4:442 in 35c46bcb68 
     437 | +      AC_CACHE_CHECK(for Qt >= 5.5.1,bitcoin_cv_qt_minimumrequired,
 438 | +        PKG_CHECK_EXISTS(Qt5Core < 5.5.1,[bitcoin_cv_qt_minimumrequired=no],[bitcoin_cv_qt_minimumrequired=yes])
 439 | +      )
 440 | +    ])
 441 | +    BITCOIN_QT_CHECK([
 442 | +      AC_CACHE_CHECK(for Qt >= 5.8.0,bitcoin_cv_qt58,
    hebasto commented at 9:20 AM on January 26, 2020: 
          AC_CACHE_CHECK([for Qt >= 5.8.0],bitcoin_cv_qt58,
  59. hebasto approved
  60. hebasto commented at 9:26 AM on January 26, 2020: member

    ACK 35c46bcb68344bb692dcc71a7c4dd6ac4442a920, tested on Linux Mint 19.3 with system Qt 5.9.5:

    $ qmake -qt=qt5_system -v
QMake version 3.1
Using Qt version 5.9.5 in /usr/lib/x86_64-linux-gnu

    Tests with pkg-config usage

    $ ./autogen.sh 
$ ./configure
...
checking for QT5... yes
checking for QT_TEST... yes
checking for QT_DBUS... yes
checking for Qt >= 5.5.1... yes
checking for Qt >= 5.8.0... yes
checking for static Qt... no
checking whether -fPIE can be used with this Qt config... no
checking for moc-qt5... no
checking for moc5... no
checking for moc... /usr/lib/qt5/bin/moc
checking for uic-qt5... no
checking for uic5... no
checking for uic... /usr/lib/qt5/bin/uic
checking for rcc-qt5... no
checking for rcc5... no
checking for rcc... /usr/lib/qt5/bin/rcc
checking for lrelease-qt5... no
checking for lrelease5... no
checking for lrelease... /usr/lib/qt5/bin/lrelease
checking for lupdate-qt5... no
checking for lupdate5... no
checking for lupdate... /usr/lib/qt5/bin/lupdate
checking whether to build Bitcoin Core GUI... yes (Qt5)
...

    To test alternative behavior the following patch was applied:

    $ git diff
diff --git a/build-aux/m4/bitcoin_qt.m4 b/build-aux/m4/bitcoin_qt.m4
index 019a3ebfb..be20602f0 100644
--- a/build-aux/m4/bitcoin_qt.m4
+++ b/build-aux/m4/bitcoin_qt.m4
@@ -262,7 +262,7 @@ dnl Internal. Check included version of Qt against minimum specified in doc/depe
 dnl Requires: INCLUDES must be populated as necessary.
 dnl Output: bitcoin_cv_qt_minimumrequired=yes|no
 AC_DEFUN([_BITCOIN_QT_CHECK_MINIMUM_REQUIRED],[
-  AC_CACHE_CHECK(for Qt >= 5.5.1, bitcoin_cv_qt_minimumrequired,[
+  AC_CACHE_CHECK(for Qt >= 5.9.6, bitcoin_cv_qt_minimumrequired,[
   AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
       #include <QtCore/qconfig.h>
       #ifndef QT_VERSION
@@ -270,7 +270,7 @@ AC_DEFUN([_BITCOIN_QT_CHECK_MINIMUM_REQUIRED],[
       #endif
     ]],
     [[
-      #if QT_VERSION < 0x050501
+      #if QT_VERSION < 0x050906
       choke
       #endif
     ]])],
@@ -434,8 +434,8 @@ AC_DEFUN([_BITCOIN_QT_FIND_LIBS_WITH_PKGCONFIG],[
       fi
     ])
     BITCOIN_QT_CHECK([
-      AC_CACHE_CHECK(for Qt >= 5.5.1,bitcoin_cv_qt_minimumrequired,
-        PKG_CHECK_EXISTS(Qt5Core < 5.5.1,[bitcoin_cv_qt_minimumrequired=no],[bitcoin_cv_qt_minimumrequired=yes])
+      AC_CACHE_CHECK(for Qt >= 5.9.6,bitcoin_cv_qt_minimumrequired,
+        PKG_CHECK_EXISTS(Qt5Core < 5.9.6,[bitcoin_cv_qt_minimumrequired=no],[bitcoin_cv_qt_minimumrequired=yes])
       )
     ])
     BITCOIN_QT_CHECK([

    $ ./autogen.sh 
$ ./configure
checking for QT5... yes
checking for QT_TEST... yes
checking for QT_DBUS... yes
checking for Qt >= 5.9.6... no
checking for Qt >= 5.8.0... yes
configure: WARNING: Qt version not supported; bitcoin-qt frontend will not be built
checking whether to build Bitcoin Core GUI... no
...

    $ ./autogen.sh 
$ ./configure --with-gui=qt5
...
checking for QT5... yes
checking for QT_TEST... yes
checking for QT_DBUS... yes
checking for Qt >= 5.9.6... no
checking for Qt >= 5.8.0... yes
configure: error: Qt version not supported

    Tests without pkg-config usage

    For these tests the following patch was applied:

    $ git diff configure.ac
diff --git a/configure.ac b/configure.ac
index 18f3104ac..d6c8745c7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -479,7 +479,7 @@ AC_ARG_WITH([daemon],
   [build_bitcoind=$withval],
   [build_bitcoind=yes])

-use_pkgconfig=yes
+use_pkgconfig=no
 case $host in
   *mingw*)

    and --with-qt-incdir command-line option was passed to configure script.

    $ ./autogen.sh
$ ./configure --with-qt-incdir=/usr/include/x86_64-linux-gnu/qt5
...
checking for Qt >= 5.5.1... yes
checking for >= Qt 5.8... yes
...
checking whether to build Bitcoin Core GUI... yes (Qt5)
...

    $ ./autogen.sh
$ ./configure --with-qt-incdir=/usr/include/x86_64-linux-gnu/qt5
...
checking for Qt >= 5.9.6... no
checking for >= Qt 5.8... yes
...
configure: WARNING: Qt version not supported; bitcoin-qt frontend will not be built
checking whether to build Bitcoin Core GUI... no
...
  61. laanwj removed this from the milestone 0.18.2 on Jan 27, 2020
  62. hebasto commented at 10:30 AM on March 17, 2020: member

    It seems we should consider an alternative solution based on #18297.

  63. fanquake commented at 7:26 AM on May 15, 2020: member

    I agree that something like #18297 is the way forward here, so I'm going to close. This also would not be getting backported to 0.18 or 0.19 at this point. Thanks for the contribution & sorry it didn't make it into the repo.

  64. fanquake closed this on May 15, 2020
  65. fanquake removed the label Needs backport (0.18) on May 15, 2020
  66. fanquake removed the label Needs backport (0.19) on May 15, 2020
  67. fanquake referenced this in commit 38c13a4a60 on Aug 24, 2020
  68. sidhujag referenced this in commit dafb919f5c on Aug 24, 2020
  69. xdustinface referenced this in commit 3e8687603d on Feb 17, 2021
  70. gades referenced this in commit 0e12d032a0 on Jun 27, 2021
  71. DrahtBot locked this on Feb 15, 2022
Contributors
lucayepalaanwjMarcoFalkeDrahtBotluke-jrhebastojonasschnellifanquake


theunidongcarl

Labels
Build system
Linked (view graph)
#15688 Configure should return an error with not supported versions of QT libraries#17054 [0.18.2] Backport of #15706#17055 [0.19] Backport of #15706#19689 build: Add Qt version checking
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 21:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me