[0.18.2] Backport of #15706 #17054

pull lucayepa wants to merge 1 commits into bitcoin:0.18 from lucayepa:check-qt-version-0.18 changing 1 files +24 −12

lucayepa commented at 7:16 PM on October 4, 2019: contributor

Backports #15706 to the 0.18 branch.

Check QT library version

Fixes issue #15688

Due to a bug, in systems using pkg-config, the version of the Qt library is
not checked at configure time. Without any check, when Qt version is not
supported, the build process stops with unexplained errors.

This PR introduces the control of the version of the QT library, returning
a warning at configure time if the installed version is not supported.

Github-Pull: #15706
Rebased-From: 25e43fc

050b3e6152

fanquake commented at 7:17 PM on October 4, 2019: member

This has been opened against the wrong branch (master instead of 0.18).
lucayepa changed the base branch on Oct 4, 2019
fanquake added the label Backport on Oct 4, 2019
fanquake added the label Build system on Oct 4, 2019
fanquake commented at 7:26 PM on October 4, 2019: member

Actually, if you wanted to change this to be against the 0.19 branch, I'll add the commit to #16617 for backporting to 0.18 once it's been merged into master.
lucayepa changed the base branch on Oct 4, 2019
lucayepa changed the base branch on Oct 4, 2019
lucayepa commented at 7:29 PM on October 4, 2019: contributor

Yes. I open a new one for the backport to 0.19 branch: #17055
lucayepa commented at 10:25 PM on October 4, 2019: contributor

I guess cheks need to be run again.
laanwj commented at 9:57 AM on October 5, 2019: member

Thanks! But FWIW: If it's a clean backport, you don't need to open a separate PR for every branch, clean-backportable PRs that are marked for backport, will be collected into "backport PRs" by developers (like #16617) before a new release on that branch.

Edit: also, it makes sense to do the backport after merge to master to make sure it includes all the last changes.
lucayepa commented at 1:19 PM on October 5, 2019: contributor

Sure. I've seen the "needs backport" tags and I thought it was addressed to me. Thanks.
fanquake commented at 3:07 PM on October 24, 2019: member

I don't think we need three PR open for the same change at the same time. I'm going to close this are pull the 0.18 backport into #16617 if this change gets merged into master.
fanquake closed this on Oct 24, 2019
lucayepa commented at 5:20 PM on October 24, 2019: contributor

Agree. It's my fault...
DrahtBot locked this on Dec 16, 2021

Contributors

lucayepa

fanquake

laanwj

Labels

Build system Backport

Linked (view graph)

#15706 build: Check QT library version