refactor: Extract ParseDescriptorRange #15744

pull Empact wants to merge 1 commits into bitcoin:master from Empact:parse-descriptor-range changing 7 files +48 −23
  1. Empact commented at 7:42 AM on April 4, 2019: member

    So as to be consistently informative when the checks fail, and to protect against unintentional divergence among the checks.

  2. fanquake added the label RPC/REST/ZMQ on Apr 4, 2019
  3. DrahtBot commented at 9:14 AM on April 4, 2019: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #15996 (Deprecate totalfee argument in bumpfee by instagibbs)
    • #15427 (Add support for descriptors to utxoupdatepsbt by sipa)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. practicalswift commented at 9:44 AM on April 4, 2019: contributor

    Concept ACK

    Consistency is good :-)

  5. promag commented at 11:43 AM on April 4, 2019: member

    Concept ACK, and code looks good.

    ProcessImportDescriptor now returns new errors, would be nice to have them tested.

  6. Empact force-pushed on Apr 5, 2019
  7. Empact commented at 8:48 AM on April 5, 2019: member

    Added tests for importmulti and scantxoutset conditions. deriveaddresses was covered here: https://github.com/bitcoin/bitcoin/blob/c83442e17412b96f00bc29d30763b28184c95f1e/test/functional/rpc_deriveaddresses.py#L37-L43

  8. meshcollider commented at 12:54 AM on April 14, 2019: contributor

    Looks good, do you also want to add a check that end >= start?

  9. Extract ParseDescriptorRange
    So as to be consistently informative when the checks fail, and
to protect against unintentional divergence among the checks.
    510c6532ba
  10. Empact force-pushed on Apr 14, 2019
  11. Empact commented at 2:07 AM on April 14, 2019: member

    @meshcollider Thankfully that's covered in ParseRange https://github.com/bitcoin/bitcoin/blob/66ce95a4340019ed3be8a36a8aeec86e4f0ace85/src/rpc/util.cpp#L665

    Added that check to the new test coverage.

  12. meshcollider commented at 3:58 AM on April 14, 2019: contributor

    Oh apologies, yes. Thanks :) utACK https://github.com/bitcoin/bitcoin/pull/15744/commits/510c6532bae9abc5beda1c126c945923a64680cb

  13. MarcoFalke commented at 8:58 PM on April 15, 2019: member

    utACK 510c6532bae9abc5beda1c126c945923a64680cb

  14. sipa commented at 12:50 AM on May 10, 2019: member

    utACK 510c6532bae9abc5beda1c126c945923a64680cb

  15. MarcoFalke renamed this:
    Extract ParseDescriptorRange
    refactor: Extract ParseDescriptorRange
    on May 10, 2019
  16. MarcoFalke added the label Refactoring on May 10, 2019
  17. MarcoFalke merged this on May 10, 2019
  18. MarcoFalke closed this on May 10, 2019
  19. MarcoFalke referenced this in commit 14959753a4 on May 10, 2019
  20. sidhujag referenced this in commit dc4bef3297 on May 10, 2019
  21. Empact deleted the branch on Jun 22, 2019
  22. deadalnix referenced this in commit 6a6cec44cf on Jun 17, 2020
  23. Munkybooty referenced this in commit 5881279b11 on Oct 16, 2021
  24. dzutto referenced this in commit 862fe896be on Dec 2, 2021
  25. dzutto referenced this in commit 60f98530d7 on Dec 2, 2021
  26. PastaPastaPasta referenced this in commit a490615a8b on Dec 11, 2021
  27. MarcoFalke locked this on Dec 16, 2021
Contributors
EmpactDrahtBotpracticalswiftpromagmeshcolliderMarcoFalkesipa
Labels
RefactoringRPC/REST/ZMQ
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me