[rpc] remove dead mining code #15748

1. 
   jnewbery commented at 7:48 pm on April 4, 2019: member

   Removes dead code from after the generate method was removed
2. DrahtBot added the label Build system on Apr 4, 2019
3. DrahtBot added the label Consensus on Apr 4, 2019
4. DrahtBot added the label Mining on Apr 4, 2019
5. DrahtBot added the label RPC/REST/ZMQ on Apr 4, 2019
6. DrahtBot added the label Validation on Apr 4, 2019
7. DrahtBot added the label Wallet on Apr 4, 2019
8. MarcoFalke removed the label Build system on Apr 4, 2019
9. MarcoFalke removed the label Consensus on Apr 4, 2019
10. MarcoFalke removed the label Validation on Apr 4, 2019
11. in src/rpc/mining.cpp:102 in 79ef6bc29a outdated

     98@@ -98,7 +99,7 @@ static UniValue getnetworkhashps(const JSONRPCRequest& request)
     99     return GetNetworkHashPS(!request.params[0].isNull() ? request.params[0].get_int() : 120, !request.params[1].isNull() ? request.params[1].get_int() : -1);
    100 }
    101 
    102-UniValue generateBlocks(std::shared_ptr<CReserveScript> coinbaseScript, int nGenerate, uint64_t nMaxTries, bool keepScript)
    103+static UniValue generateBlocks(CScript& coinbase_script, int nGenerate, uint64_t nMaxTries)
    

    ---

    ---

    

    Empact commented at 9:39 pm on April 4, 2019:

    nit: coinbase_script could be const

    ---

    

    BelfordZ commented at 9:54 pm on April 4, 2019:

    Just out of curiosity, how come the use of mixed casing?

    coinbase_script, nMaxTries all in the same function?

    ---

    

    Empact commented at 4:07 am on April 5, 2019:

    Variable (including function arguments) and namespace names are all lowercase, and may use _ to separate words (snake_case). https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#coding-style-c

    Patchsets should always be focused. For example, a pull request could add a feature, fix a bug, or refactor code; but not a mixture. https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md

    ---

    

    jnewbery commented at 4:04 pm on April 10, 2019:

    Changed. Thanks!
12. in src/rpc/mining.cpp:30 in 79ef6bc29a outdated

    25@@ -27,6 +26,8 @@
    26 #include <validationinterface.h>
    27 #include <versionbitsinfo.h>
    28 #include <warnings.h>
    29+#include <script/script.h>
    30+#include <univalue.h>
    

    ---

    ---

    

    Empact commented at 9:40 pm on April 4, 2019:

    nit: could sort includes

    ---

    

    jnewbery commented at 4:04 pm on April 10, 2019:

    Done
13. 
    practicalswift commented at 9:23 am on April 5, 2019: contributor

    Concept ACK

    Good catch!

14. 
    DrahtBot commented at 3:12 pm on April 10, 2019: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #15777 ([docs] Add doxygen comments for keypool classes by jnewbery)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

15. [rpc] simplify generate RPC

    Removes dead code from after the generate method was removed

    9819ad6d07
16. [cleanup] Remove unused CReserveKey 1b46a4889f
17. jnewbery force-pushed on Apr 10, 2019
18. 
    jnewbery commented at 4:04 pm on April 10, 2019: member

    rebased
19. 
    MarcoFalke commented at 4:18 pm on April 10, 2019: member

    utACK 1b46a4889f894d63062454fb9f4c2e88689a9d75
20. 
    meshcollider commented at 0:49 am on April 14, 2019: contributor

    utACK https://github.com/bitcoin/bitcoin/pull/15748/commits/1b46a4889f894d63062454fb9f4c2e88689a9d75
21. 
    scravy commented at 0:52 am on April 14, 2019: contributor

    utACK 1b46a48
22. 
    Empact commented at 2:04 am on April 14, 2019: member

    utACK https://github.com/bitcoin/bitcoin/pull/15748/commits/1b46a4889f894d63062454fb9f4c2e88689a9d75
23. meshcollider merged this on Apr 14, 2019
24. meshcollider closed this on Apr 14, 2019

    ---

25. meshcollider referenced this in commit adc55dbac5 on Apr 14, 2019
26. jnewbery deleted the branch on Apr 14, 2019
27. jasonbcox referenced this in commit db8bab35b2 on Jun 30, 2020
28. jasonbcox referenced this in commit 08f90b135f on Jun 30, 2020
29. vijaydasmp referenced this in commit 9d88e88337 on Oct 16, 2021
30. vijaydasmp referenced this in commit f8e0558dae on Oct 16, 2021
31. vijaydasmp referenced this in commit 005e729f29 on Nov 12, 2021
32. vijaydasmp referenced this in commit e3f7423e4c on Nov 13, 2021
33. vijaydasmp referenced this in commit 40ce1372ea on Nov 15, 2021
34. vijaydasmp referenced this in commit 6c20a7bd70 on Nov 16, 2021
35. vijaydasmp referenced this in commit b940f0d8e9 on Nov 22, 2021
36. DrahtBot locked this on Dec 16, 2021

Contributors
jnewbery Empact BelfordZ practicalswift DrahtBot MarcoFalke meshcollider scravy

Labels
Wallet RPC/REST/ZMQ Mining