doc: describe onlynet option in doc/tor.md #15792

1. 
   jonatack commented at 11:42 AM on April 11, 2019: member

   as per http://www.erisian.com.au/bitcoin-core-dev/log-2019-04-11.html#l-102.

   Description adapted from /src/init.cpp#L429.

   Please verify if this is the best place to add it in the documentation.

   This commit also fixes a typo in doc/dependencies.md.

   [skip ci]

2. in doc/tor.md:30 in cdf47e8fcf outdated

     26 | @@ -27,6 +27,11 @@ outgoing connections, but more is possible.
     27 |  	-seednode=X     SOCKS5. In Tor mode, such addresses can also be exchanged with
     28 |  	                other P2P nodes.
     29 |  
     30 | +	-onlynet=onion  Make outgoing connections only through .onion addresses. Incoming
   

   ---

   ---

   

   laanwj commented at 11:54 AM on April 11, 2019:

   I'd say: only to .onion addresses, not through (reserve that word for the proxy), but that's a minor thing

   ---

   

   jonatack commented at 12:03 PM on April 11, 2019:

   Thanks! Agree, will update.

3. in doc/tor.md:94 in cdf47e8fcf outdated

     90 | @@ -86,6 +91,7 @@ for normal IPv4/IPv6 communication, use:
     91 |  
     92 |  	./bitcoind -onion=127.0.0.1:9050 -externalip=57qr3yd1nyntf5k.onion -discover
     93 |  
     94 | +
   

   ---

   ---

   

   laanwj commented at 11:55 AM on April 11, 2019:

   empty line?

   ---

   

   jonatack commented at 12:03 PM on April 11, 2019:

   Like lines 38-39.

   ---

   

   jonatack commented at 12:03 PM on April 11, 2019:

   Not worth adding, will remove.

4. fanquake added the label Docs on Apr 11, 2019
5. doc: describe onlynet option in doc/tor.md

   as per http://www.erisian.com.au/bitcoin-core-dev/log-2019-04-11.html#l-102.
   
   Description adapted from https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L429.
   
   Also fixes a typo in doc/dependencies.md.

   140bbeec45
6. jonatack force-pushed on Apr 11, 2019
7. 
   jonatack commented at 12:08 PM on April 11, 2019: member

   Thanks for reviewing! Updated as per feedback.

8. 
   laanwj commented at 1:28 PM on April 11, 2019: member

   thanks, utACK

9. 
   jonatack commented at 1:57 PM on April 11, 2019: member

   If merged, might be worth backporting to 0.18.0 before final.

10. 
    DrahtBot commented at 6:00 PM on April 11, 2019: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #15778 ([wallet] Move maxtxfee from node to wallet by jnewbery)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

11. 
    jonatack commented at 6:38 PM on April 11, 2019: member

    DrahtBot appears to be mistaken; the other PR does not change these 2 documentation files. Perhaps it is from the link to source code in the commit message or the PR description?

12. 
    practicalswift commented at 6:44 PM on April 11, 2019: contributor

    ACK 140bbeec45f14fd50cce68448bc7fa655cbef951

13. 
    fanquake commented at 12:10 PM on April 15, 2019: member

    utACK 140bbee

14. laanwj merged this on Apr 15, 2019
15. laanwj closed this on Apr 15, 2019

    ---

16. laanwj referenced this in commit 9422e2c29f on Apr 15, 2019
17. laanwj added the label Needs backport on Apr 15, 2019
18. laanwj added this to the milestone 0.18.0 on Apr 15, 2019
19. fanquake referenced this in commit 15f469d7e4 on Apr 15, 2019
20. fanquake removed the label Needs backport on Apr 15, 2019
21. 
    fanquake commented at 1:07 PM on April 15, 2019: member

    Backported in #15818.

22. jonatack deleted the branch on Apr 15, 2019
23. fanquake referenced this in commit 194226f679 on Apr 16, 2019
24. laanwj referenced this in commit e753cbd645 on Apr 18, 2019
25. HashUnlimited referenced this in commit 4784d8c90f on Apr 19, 2019
26. jasonbcox referenced this in commit 27f0ad0646 on Oct 20, 2020
27. PastaPastaPasta referenced this in commit 4140379b58 on Sep 18, 2021
28. kittywhiskers referenced this in commit 1917a982c3 on Oct 12, 2021
29. MarcoFalke locked this on Dec 16, 2021

Contributors

jonatacklaanwjDrahtBotpracticalswiftfanquake

Milestone
0.18.0