travis: Bump second timeout to 33 minutes, Add rationale #15797

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1904-travisTime changing 1 files +1 −1

MarcoFalke commented at 5:46 PM on April 11, 2019: member

People have been complaining on IRC about timeouts, but I don't think we can bump it much further. The tests take more than 15 minutes in some cases [1], so if there is less than 1000 seconds left to finish them we need to abort and save the cache. :man_shrugging:.

[1] https://travis-ci.org/bitcoin/bitcoin/jobs/518788414#L3568
DrahtBot added the label Tests on Apr 11, 2019
DrahtBot commented at 5:58 PM on April 11, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #15778 ([wallet] Move maxtxfee from node to wallet by jnewbery)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

in .travis.yml:67 in fad30c2d0b outdated

  63 | @@ -64,7 +64,7 @@ script:
  64 |    - export CONTINUE=1
  65 |    - if [ $SECONDS -gt 1200 ]; then export CONTINUE=0; fi  # Likely the depends build took very long
  66 |    - if [ $CONTINUE = "1" ]; then set -o errexit; source .travis/test_06_script_a.sh; else set +o errexit; echo "$CACHE_ERR_MSG"; false; fi
  67 | -  - if [ $SECONDS -gt 1800 ]; then export CONTINUE=0; fi  # Likely the build took very long
  68 | +  - if [ $SECONDS -gt 2000]; then export CONTINUE=0; fi  # Likely the build took very long; The tests take about 1000s, so we should abort if we have less than 50*60-1000=2000s left

practicalswift commented at 6:38 PM on April 11, 2019:

Nit: Space dropped before ]? :-)

practicalswift commented at 6:40 PM on April 11, 2019: contributor

utACK fad30c2d0b358f030351d0cd5ad2f4f6f1b0ba7c modulo nit
travis: Bump second timeout to 33 minutes, Add rationale fa2dfbf30a
MarcoFalke force-pushed on Apr 11, 2019
practicalswift commented at 8:36 AM on April 12, 2019: contributor

utACK fa2dfbf30a9833eaa5f006fc4102299e8302bcd9
fanquake commented at 1:56 PM on April 12, 2019: member

utACK fa2dfbf ⏰
MarcoFalke merged this on Apr 12, 2019
MarcoFalke closed this on Apr 12, 2019
MarcoFalke referenced this in commit 66ce95a434 on Apr 12, 2019
MarcoFalke deleted the branch on Apr 12, 2019
MarcoFalke referenced this in commit 5aac5e9b03 on Aug 14, 2019
HashUnlimited referenced this in commit 784f0b38f8 on Aug 23, 2019
magic53 referenced this in commit a8a8c1bc20 on Dec 31, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

travis: Bump second timeout to 33 minutes, Add rationale #15797

Conflicts