appveyor: Write @PACKAGE_NAME@ to config #15903

1. 
   MarcoFalke commented at 5:07 PM on April 26, 2019: member

   fix tests which are currently failing on appveyor after #15896

2. appveyor: Write @PACKAGE_NAME@ to config faebd8ca11
3. MarcoFalke added this to the milestone 0.19.0 on Apr 26, 2019
4. 
   hebasto commented at 5:36 PM on April 26, 2019: member

   Should be the next patch applied aswell?

   diff --git a/build_msvc/bitcoin_config.h b/build_msvc/bitcoin_config.h
   index 4ac27dae3..817bb57ce 100644
   --- a/build_msvc/bitcoin_config.h
   +++ b/build_msvc/bitcoin_config.h
   @@ -14,7 +14,7 @@
    #define CLIENT_VERSION_MAJOR 1
    
    /* Minor version */
   -#define CLIENT_VERSION_MINOR 17
   +#define CLIENT_VERSION_MINOR 18
    
    /* Build revision */
    #define CLIENT_VERSION_REVISION 99
   

5. ryanofsky approved
6. 
   ryanofsky commented at 5:37 PM on April 26, 2019: member

   utACK faebd8ca118f6fbf08c783faba796b5ee957ff00. Not following your own "Please provide clear motivation for your patch" advice maybe, but I gather the motivation is to fix tests which are currently failing on appveyor after #15896?

7. 
   Sjors commented at 6:27 PM on April 26, 2019: member

   utACK faebd8c if AppVeyor blesses it.

8. 
   MarcoFalke commented at 6:31 PM on April 26, 2019: member

   @hebasto That should be mentioned in the branch-off todo list. See for example #15607

9. 
   MarcoFalke commented at 6:32 PM on April 26, 2019: member

   Took @ryanofsky 's motivation and copy-pasted it into the first comment

10. MarcoFalke merged this on Apr 26, 2019
11. MarcoFalke closed this on Apr 26, 2019

    ---

12. MarcoFalke referenced this in commit ec519d4d54 on Apr 26, 2019
13. 
    luke-jr commented at 2:08 AM on April 27, 2019: member

    Why isn't AppVeyor using standard build stuff? :/

14. MarcoFalke deleted the branch on Apr 27, 2019
15. MarcoFalke referenced this in commit 8da1aa471e on Apr 29, 2019
16. Munkybooty referenced this in commit a6b968a158 on Oct 7, 2021
17. Munkybooty referenced this in commit bf5ed75d6c on Oct 14, 2021
18. DrahtBot locked this on Dec 16, 2021

Milestone
0.19.0