docs: Align MSVC build options with Linux build ones #15908

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:20190427-align-msvc-linux changing 2 files +13 −8

hebasto commented at 8:54 AM on April 27, 2019: member
Ref:
- #11526
- #15903 (comment)
- #15903 (comment) by MarcoFalke
Align MSVC build options with Linux build ones 48ed65bcdd
hebasto force-pushed on Apr 27, 2019
hebasto force-pushed on Apr 27, 2019
fanquake added the label Docs on Apr 27, 2019

in doc/release-process.md:17 in 1f3aae9145 outdated

  14 |  
  15 |  * Update translations (ping wumpus on IRC) see [translation_process.md](https://github.com/bitcoin/bitcoin/blob/master/doc/translation_process.md#synchronising-translations).
  16 | -
  17 |  * Update manpages, see [gen-manpages.sh](https://github.com/bitcoin/bitcoin/blob/master/contrib/devtools/README.md#gen-manpagessh).
  18 | -* Update release candidate version in `configure.ac` (`CLIENT_VERSION_RC`)
  19 | +* Update release candidate version in `configure.ac` and `build_msvc/bitcoin_config.h` (`CLIENT_VERSION_RC`).

MarcoFalke commented at 12:32 PM on April 27, 2019:

msvc is a dev-only build and never released, the version stays at .99

in doc/release-process.md:22 in 1f3aae9145 outdated

  21 |  Before every minor and major release:
  22 |  
  23 |  * Update [bips.md](bips.md) to account for changes since the last release.
  24 | -* Update version in `configure.ac` (don't forget to set `CLIENT_VERSION_IS_RELEASE` to `true`) (don't forget to set `CLIENT_VERSION_RC` to `0`)
  25 | -* Write release notes (see below)
  26 | +* Update version in `configure.ac` and `build_msvc/bitcoin_config.h` (don't forget to set `CLIENT_VERSION_RC` to `0`).

MarcoFalke commented at 12:32 PM on April 27, 2019:

msvc is a dev-only build and never released, the version stays at .99

in doc/release-process.md:11 in 1f3aae9145 outdated

   6 | +* In `configure.ac` and `build_msvc/bitcoin_config.h` on _the master branch_:
   7 | +  - update `CLIENT_VERSION_MINOR` version
   8 | +* In `configure.ac` and `build_msvc/bitcoin_config.h` on _a new release branch_:
   9 | +  - update `CLIENT_VERSION_MINOR` version
  10 | +  - set `CLIENT_VERSION_REVISION` to `0`
  11 | +  - set `CLIENT_VERSION_IS_RELEASE` to `true`

MarcoFalke commented at 12:42 PM on April 27, 2019:

Could link to an example commit 742f7dd972fca3dd4a33cfff90bf901b71a687e7?

Could move this down to section Before a major release?

Include bitcoin_config.h in release process e47dc4f68b
hebasto force-pushed on Apr 27, 2019
hebasto commented at 1:28 PM on April 27, 2019: member

@MarcoFalke Thank you for your review. Your comments have been addressed.
MarcoFalke commented at 1:43 PM on April 27, 2019: member

utACK e47dc4f68bd3745d99dd31fe5b18b071b719c642
DrahtBot commented at 3:08 PM on April 27, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #15607 ([Docs] Release process updates by jonatack)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Sjors commented at 6:51 PM on April 27, 2019: member

utACK e47dc4f
fanquake renamed this:
~~scripts and tools, docs: Align MSVC build options with Linux build ones~~
docs: Align MSVC build options with Linux build ones
on Apr 29, 2019
fanquake commented at 1:27 PM on April 29, 2019: member

utACK e47dc4f
practicalswift commented at 1:31 PM on April 29, 2019: contributor

utACK e47dc4f68bd3745d99dd31fe5b18b071b719c642
MarcoFalke merged this on Apr 29, 2019
MarcoFalke closed this on Apr 29, 2019
MarcoFalke referenced this in commit 8da1aa471e on Apr 29, 2019
hebasto deleted the branch on Apr 29, 2019
sidhujag referenced this in commit 3a16d8441c on May 1, 2019
Munkybooty referenced this in commit a6b968a158 on Oct 7, 2021
Munkybooty referenced this in commit bf5ed75d6c on Oct 14, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#11526 Visual Studio build configuration for Bitcoin Core #15903 appveyor: Write @PACKAGE_NAME@ to config

docs: Align MSVC build options with Linux build ones #15908

Conflicts