Remove unused OpenSSL includes to make it more clear where OpenSSL is used #15919

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:openssl-includes changing 3 files +0 −5
  1. practicalswift commented at 11:01 AM on April 29, 2019: contributor

    Remove unused OpenSSL includes to make it more clear where OpenSSL is used.

    Before this patch:

    $ git grep '#include <openssl/' -- "*.cpp" "*.h"
    src/init.cpp:#include <openssl/crypto.h>
    src/qt/paymentrequestplus.cpp:#include <openssl/x509_vfy.h> 
    src/qt/paymentrequestplus.h:#include <openssl/x509.h>
    src/qt/paymentserver.cpp:#include <openssl/x509_vfy.h>
    src/qt/rpcconsole.cpp:#include <openssl/crypto.h>
    src/qt/test/paymentservertests.cpp:#include <openssl/x509.h>
    src/qt/test/paymentservertests.cpp:#include <openssl/x509_vfy.h>
    src/qt/test/test_main.cpp:#include <openssl/ssl.h>
    src/qt/winshutdownmonitor.cpp:#include <openssl/rand.h>
    src/random.cpp:#include <openssl/err.h>
    src/random.cpp:#include <openssl/rand.h>
    src/random.cpp:#include <openssl/conf.h>
    src/test/crypto_tests.cpp:#include <openssl/aes.h>
    src/test/crypto_tests.cpp:#include <openssl/evp.h>
    

    After this patch:

    $ git grep '#include <openssl/' -- "*.cpp" "*.h"
    src/qt/paymentrequestplus.cpp:#include <openssl/x509_vfy.h>
    src/qt/paymentrequestplus.h:#include <openssl/x509.h>
    src/qt/paymentserver.cpp:#include <openssl/x509_vfy.h>
    src/qt/test/paymentservertests.cpp:#include <openssl/x509.h>
    src/qt/test/paymentservertests.cpp:#include <openssl/x509_vfy.h>
    src/qt/test/test_main.cpp:#include <openssl/ssl.h>
    src/qt/winshutdownmonitor.cpp:#include <openssl/rand.h>
    src/random.cpp:#include <openssl/err.h>
    src/random.cpp:#include <openssl/rand.h>
    src/random.cpp:#include <openssl/conf.h>
    

    Removed:

    • src/init.cpp:#include <openssl/crypto.h> (unused since 5ecfa36fd01fc27475abbfcd53b4efb9da4a7398 (2016))
    • src/qt/rpcconsole.cpp:#include <openssl/crypto.h> (unused since 5ecfa36fd01fc27475abbfcd53b4efb9da4a7398 (2016))
    • src/test/crypto_tests.cpp:#include <openssl/aes.h> (introduced unused in daa384120a63542257d4ca73047d775f16fac654 (2015))
    • src/test/crypto_tests.cpp:#include <openssl/evp.h> (introduced unused in daa384120a63542257d4ca73047d775f16fac654 (2015))
  2. Remove unused OpenSSL includes to make it more clear where OpenSSL is used a34081b7c3
  3. fanquake added the label Refactoring on Apr 29, 2019
  4. MarcoFalke commented at 12:02 PM on April 29, 2019: member

    utACK a34081b7c398847c37a587029c7ad7f3a3396c8e

  5. MarcoFalke added the label Build system on Apr 29, 2019
  6. real-or-random commented at 12:26 PM on April 29, 2019: member

    utACK a34081b

  7. fanquake commented at 12:34 PM on April 29, 2019: member

    utACK a34081b

  8. MarcoFalke merged this on Apr 29, 2019
  9. MarcoFalke closed this on Apr 29, 2019

  10. MarcoFalke referenced this in commit 5873e9a3e8 on Apr 29, 2019
  11. scravy commented at 2:17 PM on April 30, 2019: contributor

    utACK a34081b

  12. deadalnix referenced this in commit ce95722d97 on Oct 1, 2020
  13. practicalswift deleted the branch on Apr 10, 2021
  14. PastaPastaPasta referenced this in commit 5f776c1771 on Jun 27, 2021
  15. PastaPastaPasta referenced this in commit 10bd715f1c on Jun 28, 2021
  16. PastaPastaPasta referenced this in commit 6cebd676bf on Jun 29, 2021
  17. PastaPastaPasta referenced this in commit 44387ab623 on Sep 11, 2021
  18. PastaPastaPasta referenced this in commit 2d4998dee0 on Sep 11, 2021
  19. vijaydasmp referenced this in commit 1958e396f2 on Nov 10, 2021
  20. vijaydasmp referenced this in commit f5cb1d6a14 on Nov 12, 2021
  21. vijaydasmp referenced this in commit 7a32a94612 on Nov 16, 2021
  22. vijaydasmp referenced this in commit b6063a1f5a on Nov 17, 2021
  23. vijaydasmp referenced this in commit ce08e28a66 on Nov 21, 2021
  24. vijaydasmp referenced this in commit 58365e5e76 on Nov 21, 2021
  25. DrahtBot locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-16 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me