refactor: Avoid UniValue copy constructor #15974

pull promag wants to merge 1 commits into bitcoin:master from promag:2019-05-copy-univalue changing 8 files +22 −24

promag commented at 3:18 PM on May 7, 2019: member

Remove unnecessary UniValue copies. Not sure if this change is exhaustive without changing UniValue or if there is a way to detect that.

A followup is to add move semantics to UniValue and remove some unnecessary members of UniValue.

This work is related to #15925.
refactor: Avoid UniValue copy constructor 879ce09cab
jgarzik commented at 3:22 PM on May 7, 2019: contributor

UniValue constructor improvements welcomed... a version 2.0 that ditches old APIs (no impact on bitcoin) is scheduled, fwiw.
practicalswift commented at 3:46 PM on May 7, 2019: contributor

Concept ACK
DrahtBot added the label Refactoring on May 7, 2019
DrahtBot added the label RPC/REST/ZMQ on May 7, 2019
DrahtBot added the label Wallet on May 7, 2019
Empact commented at 9:00 PM on May 7, 2019: member

Concept ACK - some NullUniValue changes could be scripted to be verifiably consistent and comprehensive
DrahtBot commented at 7:22 PM on June 19, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #16251 (Improve signrawtransaction error reporting by ajtowns)
- #16240 (JSONRPCRequest-aware RPCHelpMan by kallewoof)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
laanwj referenced this in commit 0a6ee9797e on Jul 8, 2019
sidhujag referenced this in commit 6678aba111 on Jul 9, 2019
DrahtBot commented at 11:41 PM on July 9, 2019: member

Needs rebase
DrahtBot added the label Needs rebase on Jul 9, 2019
promag closed this on Jul 28, 2019
promag deleted the branch on Jul 28, 2019
laanwj removed the label Needs rebase on Oct 24, 2019
Munkybooty referenced this in commit 2cd358cfcb on Nov 4, 2021
Munkybooty referenced this in commit da34449bb7 on Nov 4, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Refactoring Wallet RPC/REST/ZMQ

Linked (view graph)

#15925 getblock performance issue on verbosity #15975 univalue: Drop overloaded members #16267 bench: Benchmark blockToJSON #25429 refactor: Avoid UniValue copies

refactor: Avoid UniValue copy constructor #15974

Conflicts