net: Remove -whitelistrelay #15984

1. 
   MarcoFalke commented at 8:32 pm on May 8, 2019: member

   This removes an option that has no documented use case.

   The option is on by default and can either be disabled directly or by setting -blocksonly (an undocumented debug option). Instead of disabling -whitelistrelay to not accept txs from whitelisted peers, the user shouldn’t whitelist peers in the first place.

2. net: Remove -whitelistrelay fad56ef5db
3. 
   gmaxwell commented at 8:49 pm on May 8, 2019: contributor

   This change would make it impossible to have a node that processes no unconfirmed transactions for security/resource usage purposes, but which still has peers which are whitelisted for the purpose of bypassing anti-DOS/resource-limits to increase reliability… which should be a standard config for a border node in front of a service that doesn’t need unconfirmed transactions.

   This is a case where we’re suffering from white-listing being overloaded to mean multiple things. Is there actually a use case for accepting transactions when we’re otherwise configured to not accept transactions at all?

   Regardless, I think this is going in the wrong direction: we should be narrowing the definition of whitelisting so that users can make more use of it, not widening it so that they can’t.

4. DrahtBot added the label P2P on May 8, 2019
5. DrahtBot added the label Validation on May 8, 2019
6. 
   DrahtBot commented at 5:57 pm on May 9, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #15990 (Add tests and documentation for blocksonly by MarcoFalke)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. 
   laanwj commented at 2:57 pm on May 16, 2019: member

   There has been a long history around whitelisting and relay, I don’t think this should be removed, or at least needs much more discussion:

   • #7439 Add whitelistforcerelay to control forced relaying
   • #7106 Fix and improve relay from whitelisted peers
   • #6993 Add -blocksonly option @pstratem @sipa at least
8. 
   DrahtBot commented at 6:04 pm on May 16, 2019: member
9. DrahtBot added the label Needs rebase on May 16, 2019
10. MarcoFalke closed this on May 20, 2019

    ---

11. MarcoFalke deleted the branch on May 20, 2019
12. MarcoFalke referenced this in commit 1d74693e8a on Aug 19, 2019
13. sidhujag referenced this in commit 84228bdcc4 on Aug 19, 2019
14. laanwj removed the label Needs rebase on Oct 24, 2019
15. ShengguangXiao referenced this in commit 4ccb064133 on Aug 28, 2020
16. vijaydasmp referenced this in commit df0665137e on Oct 27, 2021
17. vijaydasmp referenced this in commit 2e8b792965 on Oct 28, 2021
18. vijaydasmp referenced this in commit 7b75d5c9df on Oct 29, 2021
19. vijaydasmp referenced this in commit b113e72ecc on Oct 30, 2021
20. vijaydasmp referenced this in commit 53f792edd1 on Nov 2, 2021
21. vijaydasmp referenced this in commit 514c0bf08b on Nov 7, 2021
22. vijaydasmp referenced this in commit 221e4769e8 on Nov 11, 2021
23. vijaydasmp referenced this in commit 757494e339 on Nov 12, 2021
24. vijaydasmp referenced this in commit 4e4e417ed2 on Nov 13, 2021
25. vijaydasmp referenced this in commit 85a8810b69 on Nov 14, 2021
26. vijaydasmp referenced this in commit 313a4606a6 on Nov 14, 2021
27. vijaydasmp referenced this in commit 52a577891e on Nov 16, 2021
28. DrahtBot locked this on Dec 16, 2021

Contributors
MarcoFalke gmaxwell DrahtBot laanwj

Labels
P2P Validation