Qt: Add vertical spacer to peer detail widget #16090

pull JosuGZ wants to merge 1 commits into bitcoin:master from JosuGZ:gui-improvements changing 1 files +13 −0

JosuGZ commented at 11:12 PM on May 25, 2019: contributor

Before:

After:
Add vertical spacer 36b0a2f2a6
DrahtBot added the label GUI on May 25, 2019
practicalswift commented at 8:23 AM on May 26, 2019: contributor

Concept ACK: looks much better! @JosuGZ, welcome as a contributor! Hope to see more contributions from you! :-)
JosuGZ commented at 10:44 AM on May 26, 2019: contributor

Concept ACK: looks much better!

@JosuGZ, welcome as a contributor! Hope to see more contributions from you! :-)

Thanks! I have no clue about why that rpc_psbt.py test fails though.
practicalswift commented at 11:01 AM on May 26, 2019: contributor

@joshrabinowitz That is just a random unrelated failure :-)
kristapsk approved
kristapsk commented at 2:56 PM on May 26, 2019: contributor

ACK 36b0a2f2a6b49008c4f37866a9e3ab702eb34eda (tested with Qt 5.11.3 under Linux/Xfce4)

in src/qt/forms/debugwindow.ui:1488 in 36b0a2f2a6

1479 | @@ -1480,6 +1480,19 @@
1480 |                   </property>
1481 |                  </widget>
1482 |                 </item>
1483 | +               <item row="18" column="0">
1484 | +                <spacer name="verticalSpacer_3">
1485 | +                 <property name="orientation">
1486 | +                  <enum>Qt::Vertical</enum>
1487 | +                 </property>
1488 | +                 <property name="sizeHint" stdset="0">

promag commented at 1:40 PM on May 27, 2019:

Property could be removed.

JosuGZ commented at 5:25 PM on May 28, 2019:

It seems indeed unneeded, I think it is how Qt creator creates spacers though. Change pushed.

JosuGZ commented at 5:45 PM on May 28, 2019:

Hmm, I'm noticing other spacers have the property set, like the one in the information tab on the same file.

promag commented at 1:42 PM on May 27, 2019: member

Tested ACK https://github.com/bitcoin/bitcoin/pull/16090/commits/36b0a2f2a6b49008c4f37866a9e3ab702eb34eda on macos 10.14.3. Resizing the window works as expected.
fanquake commented at 2:31 PM on May 28, 2019: member

utACK https://github.com/bitcoin/bitcoin/pull/16090/commits/36b0a2f2a6b49008c4f37866a9e3ab702eb34eda

This change doesn't seem to make any difference on macOS (10.14.x), as the before behavior isn't present. @JosuGZ What OS are you seeing this issue on?
promag commented at 2:43 PM on May 28, 2019: member

@fanquake I'm on a macos and it also stretches the details (macos 10.14.3, Qt 5.12.2).
kristapsk commented at 3:23 PM on May 28, 2019: contributor

@fanquake , I have the "before" behaviour also on Linux/Xfce4, Qt 5.11.3.
JosuGZ commented at 5:15 PM on May 28, 2019: contributor

@fanquake

@JosuGZ What OS are you seeing this issue on?

Linux Mint 19.1 Tessa

It usually also happens when I do this kind of layouts on Windows.
fanquake commented at 5:23 PM on May 28, 2019: member

@promag @kristapsk @JosuGZ Thanks for clarifying.
hebasto commented at 5:42 PM on May 28, 2019: member

tACK 36b0a2f2a6b49008c4f37866a9e3ab702eb34eda on Linux Mint 19.1, Qt 5.9.5 Could you squash your commits?

The different behavior (some can see 'before', others not) can be caused by QGridLayout::setRowStretch:

If the stretch factor is 0 and no other row in this table can grow at all, the row may still grow.
JosuGZ force-pushed on May 28, 2019
JosuGZ commented at 5:51 PM on May 28, 2019: contributor

@hebasto I have left the property for coherency with the rest of the file and with Qt Creator.
fanquake commented at 2:14 PM on June 3, 2019: member

re-utACK https://github.com/bitcoin/bitcoin/commit/36b0a2f2a6b49008c4f37866a9e3ab702eb34eda

Could have used a commit message like gui: add vertical spacer to peers window.
JosuGZ commented at 2:51 PM on June 3, 2019: contributor

True. Shouldn't appear in the the merge commit anyway?
laanwj merged this on Jun 3, 2019
laanwj closed this on Jun 3, 2019
laanwj referenced this in commit 599206fda7 on Jun 3, 2019
sidhujag referenced this in commit a73df3e9e7 on Jun 6, 2019
luke-jr referenced this in commit 1f5ea6f8da on Aug 23, 2019
fanquake referenced this in commit 07cacf6c61 on Aug 24, 2019
luke-jr referenced this in commit b0747b3b4c on Sep 3, 2019
fanquake referenced this in commit 1d12e52db0 on Sep 23, 2019
laanwj referenced this in commit 29d70264fb on Nov 25, 2019
Fabcien referenced this in commit dbe10f3c47 on Dec 12, 2020
Munkybooty referenced this in commit 25f80d3e4e on Oct 17, 2021
Munkybooty referenced this in commit f40f39fea9 on Oct 25, 2021
Munkybooty referenced this in commit 1b42298f32 on Oct 26, 2021
Munkybooty referenced this in commit 13658cdc7e on Oct 26, 2021
Munkybooty referenced this in commit 5974914031 on Nov 9, 2021
pravblockc referenced this in commit 46f0624b56 on Nov 18, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#16617 [0.18.2] Backports