--enable-fuzz fails in combination with --enable-wallet, --with-miniupnpc or --enable-zmq #16094

--enable-fuzz fails in combination with --enable-wallet, --with-miniupnpc or --enable-zmq.

$ git clone https://github.com/bitcoin/bitcoin
$ cd bitcoin
$ ./autogen.sh
$ ./configure --disable-wallet --without-miniupnpc --disable-zmq --enable-fuzz
$ make
$ echo $?
0
$ make clean
$ ./configure --with-incompatible-bdb --without-miniupnpc --disable-zmq --enable-fuzz
$ make
…
  CXXLD    test/fuzz/address_deserialize
libbitcoin_server.a(libbitcoin_server_a-init.o): In function `WalletInit::Construct(InitInterfaces&) const':
/…/src/wallet/init.cpp:139: undefined reference to `interfaces::MakeWalletClient(interfaces::Chain&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >)'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Makefile:4862: recipe for target 'test/fuzz/address_deserialize' failed
$ make clean
$ ./configure --disable-wallet --with-miniupnpc --disable-zmq --enable-fuzz
$ make
…
  CXXLD    test/fuzz/address_deserialize
libbitcoin_server.a(libbitcoin_server_a-net.o): In function `ThreadMapPort()':
/…/src/net.cpp:1412: undefined reference to `upnpDiscover'
/…/src/net.cpp:1423: undefined reference to `UPNP_GetValidIGD'
/…/src/net.cpp:1428: undefined reference to `UPNP_GetExternalIPAddress'
/…/src/net.cpp:1473: undefined reference to `freeUPNPDevlist'
/…/src/net.cpp:1475: undefined reference to `FreeUPNPUrls'
/…/src/net.cpp:1455: undefined reference to `UPNP_AddPortMapping'
/…/src/net.cpp:1461: undefined reference to `strupnperror'
/…/src/net.cpp:1467: undefined reference to `UPNP_DeletePortMapping'
/…/src/net.cpp:1469: undefined reference to `freeUPNPDevlist'
/…/src/net.cpp:1470: undefined reference to `FreeUPNPUrls'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
$ make clean
$ ./configure --disable-wallet --without-miniupnpc --enable-zmq --enable-fuzz
$ make
…
  CXXLD    test/fuzz/address_deserialize
libbitcoin_server.a(libbitcoin_server_a-init.o): In function `Shutdown(InitInterfaces&)':
/…/src/init.cpp:290: undefined reference to `g_zmq_notification_interface'
libbitcoin_server.a(libbitcoin_server_a-init.o): In function `SetupServerArgs()':
/…/src/init.cpp:469: undefined reference to `CZMQAbstractNotifier::DEFAULT_ZMQ_SNDHWM'
/…/src/init.cpp:470: undefined reference to `CZMQAbstractNotifier::DEFAULT_ZMQ_SNDHWM'
/…/src/init.cpp:471: undefined reference to `CZMQAbstractNotifier::DEFAULT_ZMQ_SNDHWM'
/…/src/init.cpp:472: undefined reference to `CZMQAbstractNotifier::DEFAULT_ZMQ_SNDHWM'
libbitcoin_server.a(libbitcoin_server_a-init.o): In function `AppInitMain(InitInterfaces&)':
/…/src/init.cpp:1317: undefined reference to `RegisterZMQRPCCommands(CRPCTable&)'
/…/src/init.cpp:1440: undefined reference to `CZMQNotificationInterface::Create()'
/…/src/init.cpp:1440: undefined reference to `g_zmq_notification_interface'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@practicalswift is this using master ? I've tried all the ./configure combinations above with c7cfd20a77ce57d200b3b9e5e0dfb0d63818abdc, and am not seeing any of the same failures when compiling.

@practicalswift Does it also happen with make distclean?

@fanquake @MarcoFalke I'm able to reproduce against current master (c7cfd20a77ce57d200b3b9e5e0dfb0d63818abdc) using a fresh clone:

$ git clone https://github.com/bitcoin/bitcoin bitcoin-enable-fuzz
$ cd bitcoin-enable-fuzz
$ git rev-parse HEAD
c7cfd20a77ce57d200b3b9e5e0dfb0d63818abdc
$ ./autogen.sh
$ ./configure --with-incompatible-bdb --without-miniupnpc --disable-zmq --enable-fuzz
$ make
…
libbitcoin_server.a(libbitcoin_server_a-init.o): In function `WalletInit::Construct(InitInterfaces&) const':
/…/src/wallet/init.cpp:139: undefined reference to `interfaces::MakeWalletClient(interfaces::Chain&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >)'
collect2: error: ld returned 1 exit status
Makefile:4865: recipe for target 'test/fuzz/address_deserialize' failed
$ grep DESC /etc/lsb-release
DISTRIB_DESCRIPTION="Ubuntu 18.04.2 LTS"
$ gcc --version | head -1
gcc (Ubuntu 7.4.0-1ubuntu1~18.04) 7.4.0
$ ld --version | head -1
GNU ld (GNU Binutils for Ubuntu) 2.30

Just to rule out any local issue with my test system I reproduced the issue using a fresh 18.04 install too:

$ docker run -it ubuntu bash
$ apt update
$ apt upgrade
$ apt install gcc make git curl wget g++ build-essential libtool autotools-dev automake pkg-config bsdmainutils python3 libdb-dev libdb++-dev
$ apt install libssl-dev libevent-dev libboost-system-dev libboost-filesystem-dev libboost-chrono-dev libboost-test-dev libboost-thread-dev
$ git clone https://github.com/bitcoin/bitcoin bitcoin-enable-fuzz
$ cd bitcoin-enable-fuzz
$ git rev-parse HEAD
c7cfd20a77ce57d200b3b9e5e0dfb0d63818abdc
$ ./autogen.sh
$ ./configure --with-incompatible-bdb --without-miniupnpc --disable-zmq --enable-fuzz
$ make
…
libbitcoin_server.a(libbitcoin_server_a-init.o): In function `WalletInit::Construct(InitInterfaces&) const':
/bitcoin-enable-fuzz/src/wallet/init.cpp:139: undefined reference to `interfaces::MakeWalletClient(interfaces::Chain&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >)'
collect2: error: ld returned 1 exit status
Makefile:4865: recipe for target 'test/fuzz/address_deserialize' failed
$ grep DESC /etc/lsb-release
DISTRIB_DESCRIPTION="Ubuntu 18.04.2 LTS"
$ gcc --version | head -1
gcc (Ubuntu 7.4.0-1ubuntu1~18.04) 7.4.0
$ ld --version | head -1
GNU ld (GNU Binutils for Ubuntu) 2.30

Thanks for clarifying. I now see the same failure building inside docker with the steps above:

  CXX      bench/bench_bench_bitcoin-poly1305.o
  CXX      bench/bench_bench_bitcoin-prevector.o
  CXX      test/bench_bench_bitcoin-setup_common.o
  CXX      test/bench_bench_bitcoin-util.o
  CXX      bench/bench_bench_bitcoin-coin_selection.o
  CXX      bench/bench_bench_bitcoin-wallet_balance.o
  CXXLD    bench/bench_bitcoin
  CXX      test/test_fuzz_address_deserialize-setup_common.o
  CXX      test/fuzz/test_fuzz_address_deserialize-fuzz.o
  CXX      test/fuzz/test_fuzz_address_deserialize-deserialize.o
  CXXLD    test/fuzz/address_deserialize
libbitcoin_server.a(libbitcoin_server_a-init.o): In function `WalletInit::Construct(InitInterfaces&) const':
/bitcoin-enable-fuzz/src/wallet/init.cpp:139: undefined reference to `interfaces::MakeWalletClient(interfaces::Chain&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >)'
collect2: error: ld returned 1 exit status
Makefile:4865: recipe for target 'test/fuzz/address_deserialize' failed
make[2]: *** [test/fuzz/address_deserialize] Error 1
make[2]: Leaving directory '/bitcoin-enable-fuzz/src'
Makefile:12993: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/bitcoin-enable-fuzz/src'
Makefile:776: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1
root@79e5030ee089:/bitcoin-enable-fuzz# gcc --version
gcc (Ubuntu 7.4.0-1ubuntu1~18.04) 7.4.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

root@79e5030ee089:/bitcoin-enable-fuzz# git rev-parse HEAD
c7cfd20a77ce57d200b3b9e5e0dfb0d63818abdc

Those flags are incompatible, please see the discussion in #15295 (review)

--enable-fuzz should disable all other targets by itself, but currently we rely on the user to pass --disable-wallet --disable-bench --with-utils=no --with-daemon=no --with-libs=no --with-gui=no