ThreadSanitizer intermittently reports data race when shutting down node #16133

issue practicalswift opened this issue on June 1, 2019

practicalswift commented at 7:22 PM on June 1, 2019: contributor

I don't remember having seen this TSan reported data race triggered in Travis before:

112/120 - feature_assumevalid.py failed, Duration: 193 s
…
WARNING: ThreadSanitizer: data race (pid=28249)
  Write of size 8 at 0x7fa4ec6f9328 by main thread (mutexes: write M132814):
    [#0](/bitcoin-bitcoin/0/) std::vector<CNode*, std::allocator<CNode*> >::_M_erase_at_end(CNode**) /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/stl_vector.h:1439 (bitcoind+0x000000522ebf)
    [#1](/bitcoin-bitcoin/1/) std::vector<CNode*, std::allocator<CNode*> >::clear() /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/stl_vector.h:1212 (bitcoind+0x000000522ebf)
    [#2](/bitcoin-bitcoin/2/) CConnman::Stop() /home/travis/build/practicalswift/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src/net.cpp:2351 (bitcoind+0x000000522ebf)
    [#3](/bitcoin-bitcoin/3/) Shutdown(InitInterfaces&) /home/travis/build/practicalswift/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src/init.cpp:224 (bitcoind+0x0000004c2b52)
    [#4](/bitcoin-bitcoin/4/) AppInit(int, char**) /home/travis/build/practicalswift/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src/bitcoind.cpp:184 (bitcoind+0x0000004bd3f7)
    [#5](/bitcoin-bitcoin/5/) main /home/travis/build/practicalswift/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src/bitcoind.cpp:200 (bitcoind+0x0000004bd3f7)

Please note that the line numbers can be off by a couple of lines due to deviations from master.

fanquake added the label Tests on Jun 1, 2019
practicalswift renamed this:
~~ThreadSanitizer data race triggered in Travis when running feature_assumevalid.py~~
ThreadSanitizer intermittently reports data race when running feature_assumevalid.py
on Jun 1, 2019
MarcoFalke commented at 8:37 AM on June 2, 2019: member

Is this related to the comment?

https://github.com/bitcoin/bitcoin/blob/c7cfd20a77ce57d200b3b9e5e0dfb0d63818abdc/src/net.h#L178-L187
MarcoFalke added the label P2P on Jun 2, 2019
MarcoFalke removed the label Tests on Jun 2, 2019
MarcoFalke commented at 7:01 PM on November 1, 2019: member

I keep seeing these on travis. E.g. https://travis-ci.org/bitcoin/bitcoin/jobs/606043684, https://travis-ci.org/MarcoFalke/bitcoin-core/jobs/606220831#L8232
MarcoFalke renamed this:
~~ThreadSanitizer intermittently reports data race when running feature_assumevalid.py~~
ThreadSanitizer intermittently reports data race when shutting down node
on Nov 2, 2019
MarcoFalke commented at 4:48 PM on April 24, 2020: member

Fixed in #18458
MarcoFalke closed this on Apr 24, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

practicalswift

MarcoFalke

Labels

P2P

Linked (view graph)

#1 JSON-RPC support for mobile devices ("ultra-lightweight" clients)#2 Long-term, safe, store-of-value #3 Encrypt wallet #4 Export/Import wallet in a human readable, future-proof format #5 Make the version number the protocol version and not the client version