build: remove GZIP export from gitian descriptors #16141

1. 
   fanquake commented at 8:01 pm on June 3, 2019: member

   The GZIP environment variable is deprecated, and everywhere that we invoke gzip we are already passing -9n directly, i.e:

   0  find bitcoin-* | sort | tar --no-recursion --mode='u+rw,go+r-w,a+X' --owner=0 --group=0 -c -T - | gzip -9n > ../$SOURCEDIST
   

   0GZIP="-9n" gzip -h
   1gzip: warning: GZIP environment variable is deprecated; use an alias or script
   2Usage: gzip [OPTION]... [FILE]...
   

2. build: remove export GZIP from gitian descriptors 3ff1f2a319
3. fanquake added the label Build system on Jun 3, 2019
4. fanquake added the label Needs gitian build on Jun 3, 2019
5. fanquake requested review from dongcarl on Jun 3, 2019
6. 
   theuni commented at 9:21 am on June 4, 2019: member

   Loving these cleanups. utACK.

   Since we call tar explicitly, maybe TAR_OPTIONS could be merged in and go away as well?

7. 
   practicalswift commented at 10:18 am on June 4, 2019: contributor

   utACK 3ff1f2a319fc619954736d1e540ccbebc818ff11

   Agree with @theuni regarding TAR_OPTIONS. Parameters passed explicitly are easier to reason about.

8. depends: remove usage of TAR_OPTIONS bc8863b819
9. 
   DrahtBot commented at 2:00 pm on June 5, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #15569 (docs: improve linux tar packages by cisba)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

10. in contrib/gitian-descriptors/gitian-osx.yml:116 in bc8863b819

    111@@ -114,8 +112,8 @@ script: |
    112   # Correct tar file order
    113   mkdir -p temp
    114   pushd temp
    115-  tar xf ../$SOURCEDIST
    116-  find bitcoin-* | sort | tar --no-recursion --mode='u+rw,go+r-w,a+X' --owner=0 --group=0 -c -T - | gzip -9n > ../$SOURCEDIST
    117+  tar -xf ../$SOURCEDIST
    118+  find bitcoin-* | sort | tar --mtime="$REFERENCE_DATE\\\ $REFERENCE_TIME" --no-recursion --mode='u+rw,go+r-w,a+X' --owner=0 --group=0 -c -T - | gzip -9n > ../$SOURCEDIST
    

    ---

    ---

    

    laanwj commented at 10:42 am on June 6, 2019:

    Wait, so TAR_OPTIONS environment variable is used by tar itself?
11. laanwj merged this on Jun 7, 2019
12. laanwj closed this on Jun 7, 2019

    ---

13. MarcoFalke removed the label Needs gitian build on Jun 7, 2019
14. fanquake deleted the branch on Jun 7, 2019
15. sidhujag referenced this in commit ef6b15c2af on Jun 7, 2019
16. 
    MarcoFalke commented at 8:05 am on June 9, 2019: member

    Why was this merged without a gitian build? Does the build pass for anyone?
17. 
    MarcoFalke commented at 8:09 am on June 9, 2019: member

    0+ tar --strip-components=1 -xf ../bitcoin-0.18.99.tar.gz
    1tar: aclocal.m4: implausibly old time stamp -9223372036854775808
    2tar: autogen.sh: implausibly old time stamp -9223372036854775808
    3tar: build-aux/compile: implausibly old time stamp -9223372036854775808
    4tar: build-aux/config.guess: implausibly old time stamp -9223372036854775808
    5tar: build-aux/config.sub: implausibly old time stamp -9223372036854775808
    6tar: build-aux/depcomp: implausibly old time stamp -9223372036854775808
    

18. sidhujag referenced this in commit e014f99963 on Jun 10, 2019
19. dongcarl referenced this in commit 993aa414d3 on Jun 10, 2019
20. 
    laanwj commented at 9:03 pm on June 10, 2019: member

    Ok, whoops, let’s revert this for now. looks like there’s already a fix that moves forward instead
21. 
    fanquake commented at 9:05 pm on June 10, 2019: member

    @laanwj I don’t think we need to revert, there is a fix up in #16184.
22. MarcoFalke referenced this in commit 473c6b7c5a on Jun 11, 2019
23. sidhujag referenced this in commit 153e120080 on Jun 11, 2019
24. HashUnlimited referenced this in commit 2b1ca3f724 on Aug 30, 2019
25. deadalnix referenced this in commit 10416b0810 on Oct 27, 2020
26. Fuzzbawls referenced this in commit 37441b0099 on Jun 23, 2021
27. random-zebra referenced this in commit 3614de632e on Jul 19, 2021
28. UdjinM6 referenced this in commit dfbbec78e7 on Oct 23, 2021
29. UdjinM6 referenced this in commit c57c89e072 on Oct 23, 2021
30. Munkybooty referenced this in commit f51c68121f on Oct 29, 2021
31. Munkybooty referenced this in commit 26a2c14f6d on Oct 30, 2021
32. Munkybooty referenced this in commit 1df475e392 on Nov 2, 2021
33. Munkybooty referenced this in commit 86a8679d5b on Nov 16, 2021
34. Munkybooty referenced this in commit 9b18cc47b1 on Nov 18, 2021
35. UdjinM6 referenced this in commit 6dd986c111 on Dec 4, 2021
36. DrahtBot locked this on Dec 16, 2021

Contributors
fanquake theuni practicalswift DrahtBot laanwj MarcoFalke

Review Requested
dongcarl

Labels
Build system