Line coverage non-determinism in unit test(s) calling SerializeFileDB #16157

issue practicalswift opened this issue on June 6, 2019
  1. practicalswift commented at 7:07 AM on June 6, 2019: contributor

    Line coverage non-determinism in unit test(s) calling SerializeFileDB:

    $ contrib/devtools/test_deterministic_coverage.sh 1000
    [2019-06-04 23:30:31] Measuring coverage, run [#1](/bitcoin-bitcoin/1/) of 1000
    [2019-06-04 23:32:48] Measuring coverage, run [#2](/bitcoin-bitcoin/2/) of 1000
    [2019-06-04 23:36:15] Measuring coverage, run [#3](/bitcoin-bitcoin/3/) of 1000
    [2019-06-04 23:40:19] Measuring coverage, run [#4](/bitcoin-bitcoin/4/) of 1000
    [2019-06-04 23:44:57] Measuring coverage, run [#5](/bitcoin-bitcoin/5/) of 1000
    ...
    [2019-06-06 02:08:54] Measuring coverage, run [#556](/bitcoin-bitcoin/556/) of 1000
    [2019-06-06 02:10:34] Measuring coverage, run [#557](/bitcoin-bitcoin/557/) of 1000
    [2019-06-06 02:12:19] Measuring coverage, run [#558](/bitcoin-bitcoin/558/) of 1000
    [2019-06-06 02:15:14] Measuring coverage, run [#559](/bitcoin-bitcoin/559/) of 1000
    [2019-06-06 02:18:30] Measuring coverage, run [#560](/bitcoin-bitcoin/560/) of 1000
    
    The line coverage is non-deterministic between runs. Exiting.
    
    The test suite must be deterministic in the sense that the set of lines executed at least
    once must be identical between runs. This is a necessary condition for meaningful
    coverage measuring.
    
    --- gcovr.run-1.txt     2019-06-04 23:32:48.253337692 +0000
    +++ gcovr.run-560.txt   2019-06-06 02:20:24.202638122 +0000
    @@ -4,7 +4,7 @@
     ------------------------------------------------------------------------------
     File                                       Lines    Exec  Cover   Missing
     ------------------------------------------------------------------------------
    -addrdb.cpp                                    60      49    81%   48,53,58,73,83,127,129,132,134 [* 28-29]
    +addrdb.cpp                                    60      51    85%   53,73,83,127,129,132,134 [* 28-29]
     addrdb.h                                      28      24    85%   72-73,76-77
     addrman.cpp                                  270     238    88%   275,285,289,294-296,346-347,393,480,497,499,502,505,508,512-514,517,519,522,525,528,532,572,576-578,581-582,606-607
     addrman.h                                    212     172    81%   329-331,335,340,344,372,376,389-393,402-413,415,442-444,450,608,610-613,616,618-621
    @@ -400,5 +400,5 @@
     zmq/zmqpublishnotifier.h                       5       0     0%   12,31,37,43,49
     zmq/zmqrpc.cpp                                23       3    13%   16,18,20,23,33-35,37,40-47,51,62,64-65
     ------------------------------------------------------------------------------
    -TOTAL                                      53255   28278    53%
    +TOTAL                                      53255   28280    53%
     ------------------------------------------------------------------------------
    
  2. fanquake added the label Tests on Jun 6, 2019
  3. practicalswift commented at 3:09 PM on June 19, 2019: contributor

    I'm not able to hit this case any more. Closing.

  4. practicalswift closed this on Jun 19, 2019

  5. MarcoFalke locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 18:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me