0.17.2 backport: build with -fstack-reuse=none and test case #16163

1. 
   fanquake commented at 8:30 AM on June 7, 2019: member

   Backports:

   • build with -fstack-reuse=none
   • Add test for GCC bug 90348

   https://github.com/bitcoin/bitcoin/commit/b5a4abeca238a0fa37b34e35ca610dcfe7112c82 has been modified to replace the setup_common.h with test_bitcoin.h include.

2. build with -fstack-reuse=none

   Github-Pull: #15983
   Rebased-From: faf38bc056e523485520f98f3f725c583a3b89bf

   05fb9f7fbb
3. Add test for GCC bug 90348

   Github-Pull: #15985
   Rebased-From: 58e291cfad12fa85af87d093acfa7b44702e3521

   b5a4abeca2
4. fanquake added the label Backport on Jun 7, 2019
5. fanquake added this to the milestone 0.17.2 on Jun 7, 2019
6. MarcoFalke renamed this:
   backport: build with -fstack-reuse=none and test case
   0.17.2 backport: build with -fstack-reuse=none and test case
   on Jun 7, 2019
7. DrahtBot added the label Needs rebase on Jun 8, 2019
8. DrahtBot removed the label Needs rebase on Jun 8, 2019
9. 
   Empact commented at 1:28 AM on June 10, 2019: member

   ACK https://github.com/bitcoin/bitcoin/pull/16163/commits/b5a4abeca238a0fa37b34e35ca610dcfe7112c82 by review of the linked PRs, the GCC bug and option, and visual inspection/comparison of the ported code

10. 
    laanwj commented at 10:56 AM on June 13, 2019: member

    Code review + relevancy for backport ACK b5a4abeca238a0fa37b34e35ca610dcfe7112c82

11. laanwj merged this on Jun 13, 2019
12. laanwj closed this on Jun 13, 2019

    ---

13. laanwj referenced this in commit c165df198d on Jun 13, 2019
14. fanquake deleted the branch on Aug 16, 2019
15. DrahtBot locked this on Dec 16, 2021

Contributors

fanquakeEmpactlaanwj

Milestone
0.17.2