depends: xtrans: Configure flags cleanup. #16183

pull dongcarl wants to merge 1 commits into bitcoin:master from dongcarl:2019-06-leave-xtrans-alone-right-now changing 1 files +1 −1
  1. dongcarl commented at 6:51 pm on June 10, 2019: member 
    0xtrans does not understand the --with-pic and --disable-shared flags we
1pass it because it is not a library. Instead, we should pass it flags
2that disable features/packages we're not using so they don't get a
3chance to sneak in.

    Here’s a comparison of stdout and stderr of make -j(nproc) V=1 xtrans_built before and after this PR: https://gist.github.com/dongcarl/4ebf6fe9985ebc1508190f75932e4237

  2. dongcarl added the label Build system on Jun 10, 2019
  3. dongcarl added the label Needs gitian build on Jun 10, 2019
  4. practicalswift commented at 7:25 pm on June 10, 2019: contributor
    Concept ACK
  5. fanquake commented at 8:12 pm on June 10, 2019: member

    Concept ACK.

    This seems to be in line with recent discussion and pointers from cfields. Will check the flag changes, gbuild and compare build outputs. Also rebooted Travis.

  6. DrahtBot commented at 9:41 pm on June 11, 2019: member

    Gitian builds for commit 8a503a6c6dd419921373f45d7aa6f1787c9b8884 (master):

    Gitian builds for commit b99d01f408cdabdd9564f6df263e8b69b716d8e1 (master and this pull):

  7. DrahtBot removed the label Needs gitian build on Jun 11, 2019
  8. MarcoFalke added the label Needs gitian build on Jun 11, 2019
  9. depends: xtrans: Configure flags cleanup. 
    xtrans does not understand the --with-pic and --disable-shared flags we
pass it because it is not a library. Instead, we should pass it flags
that disable features/packages we're not using so they don't get a
chance to sneak in.
    30ea931dee
  10. dongcarl force-pushed on Jun 12, 2019
  11. DrahtBot commented at 8:33 pm on June 12, 2019: member

    Gitian builds for commit 473c6b7c5ab0e041c6a3f9f3609f9cd8c40a6542 (master):

    Gitian builds for commit 2706c50bcca2eb5629cbafe5c0c73d7f9e8859e0 (master and this pull):

  12. DrahtBot removed the label Needs gitian build on Jun 12, 2019
  13. laanwj commented at 12:49 pm on June 13, 2019: member
    what is xtrans and what are we using it for? (concept and code review ACK in any case, seems if it’s not using the options it makes no sense to add them)
  14. fanquake approved
  15. fanquake commented at 5:03 am on June 25, 2019: member

    ACK 30ea931dee8e4533c4b8efe00693aebb6fbd78fc

    The added flags are mostly documentation related: --disable-docs: Enable building the documentation (default: yes) --without-xmlto: Use xmlto to regenerate documentation (default: auto) --without-fop: Use fop to regenerate documentation (default: auto) --without-xsltproc: Use xsltproc for the transformation of XML documents (default: auto)

    I’d have thought passing --disable-docs would remove the need for the additional flags, however we need the flags to disable the additional checks.

    diff of configure output for master vs this PR:

     0 checking if gcc supports -Werror... yes
 1 checking if gcc supports -Werror=attributes... yes
 2 checking whether make supports nested variables... (cached) yes
 3-checking whether to build documentation... yes
 4-checking for xmlto... no
 5-checking for fop... no
 6-checking for xsltproc... no
 7+checking whether to build documentation... no
 8 checking for X.Org SGML entities >= 1.8... /usr/share/sgml
 9 checking for fchown... yes
10 checking that generated files are newer than configure... done

    We also lose the configure: WARNING: unrecognized options: --with-pic, --disable-shared warning.

  16. fanquake merged this on Jun 25, 2019
  17. fanquake closed this on Jun 25, 2019
  18. fanquake referenced this in commit bc948d4cfd on Jun 25, 2019
  19. sidhujag referenced this in commit ae781822d5 on Jun 30, 2019
  20. meshcollider referenced this in commit 3ca514ddb7 on Aug 24, 2019
  21. sidhujag referenced this in commit d89bdedbc5 on Aug 25, 2019
  22. deadalnix referenced this in commit 7336644abe on Apr 1, 2020
  23. PastaPastaPasta referenced this in commit acd870a77c on Jun 27, 2021
  24. PastaPastaPasta referenced this in commit 650dc04a4c on Jun 28, 2021
  25. PastaPastaPasta referenced this in commit 4168b467d5 on Jun 29, 2021
  26. PastaPastaPasta referenced this in commit 76d59a737c on Jul 1, 2021
  27. PastaPastaPasta referenced this in commit 565a0c5748 on Jul 1, 2021
  28. PastaPastaPasta referenced this in commit 8a044ebc0e on Jul 12, 2021
  29. PastaPastaPasta referenced this in commit 7fcb8f53ed on Jul 13, 2021
  30. MarcoFalke locked this on Dec 16, 2021


dongcarl practicalswift fanquake DrahtBot laanwj

Labels
Build system

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-19 03:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me