docs: add rapidcheck to vcpkg install list #16241

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:windows_build_msvc changing 1 files +9 −8

fanquake commented at 8:08 AM on June 19, 2019: member

Setting up a fresh Windows 10 VM using this guide, installing rapidcheck and building using the changes in #16235 resulted in a working bitcoind and all tests passing.
docs: add rapidcheck to vcpkg install list 4971be76a7
fanquake added the label Docs on Jun 19, 2019
fanquake added the label Windows on Jun 19, 2019
sipsorcery commented at 8:14 AM on June 19, 2019: member

ACK
DrahtBot commented at 10:20 AM on June 19, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #15876 ([rpc] signer send and fee bump convenience methods by Sjors)
- #15382 ([util] add runCommandParseJSON by Sjors)
- #14912 ([WIP] External signer support (e.g. hardware wallet) by Sjors)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
in build_msvc/README.md:27 in 4971be76a7
```
  27 | +- Berkeley DB
  28 | +- OpenSSL
  29 | +- Boost
  30 | +- libevent
  31 |  - ZeroMQ
  32 | +- RapidCheck
```
MarcoFalke commented at 1:05 PM on June 19, 2019:

This is not "required for the Visual Studio build", it is a test-only optional experimental package

fanquake commented at 1:06 PM on June 19, 2019:

@MarcoFalke I cannot compile using Visual Studio unless it is installed.

MarcoFalke commented at 1:11 PM on June 19, 2019:

That sounds like a bug in our build_msvc setup

sipsorcery commented at 1:35 PM on June 19, 2019:

@MarcoFalke the rapidcheck header is used in two of the test classes: src/test/gen/crypto_gen.cpp and src/test/key_properties.cpp.

MarcoFalke commented at 1:46 PM on June 19, 2019:

Yeah, but shouldn't it be guarded by a configure check. Those probably don't exist on windows, but I wanted to mention it.

sipsorcery commented at 7:21 PM on June 19, 2019:

The checks in the key_properties.cpp class get hit when I run the test_bitcoin.exe app under Windows. From a quick look at the RapidCheck library there doesn't seem to be any reason it can't be used on Windows?

MarcoFalke commented at 7:23 PM on June 19, 2019:

Oh, I am pretty sure it can be used on Windows, but maybe not every developer wants to use it on windows or even install it?
sipsorcery commented at 7:41 PM on June 19, 2019:

I'd recommend adding rapidcheck to the build instructions for msbuild/Visual Studio as per this PR. It took 24s to install on my Windows machine. I don't think it's going to cause problems for any devs.

c:\Tools\vcpkg>vcpkg install rapidcheck:x64-windows-static The following packages will be built and installed: rapidcheck[core]:x64-windows-static Starting package 1/1: rapidcheck:x64-windows-static Building package rapidcheck[core]:x64-windows-static... -- Using cached C:/Tools/vcpkg/downloads/emil-e-rapidcheck-cf9e0d8bd8c94e9dc00dc0ab302352bfaf1a3ac5.tar.gz -- Using source at C:/Tools/vcpkg/buildtrees/rapidcheck/src/bfaf1a3ac5-d497ee5770 -- Configuring x64-windows-static -- Building x64-windows-static-dbg -- Building x64-windows-static-rel -- Performing post-build validation -- Performing post-build validation done Building package rapidcheck[core]:x64-windows-static... done Installing package rapidcheck[core]:x64-windows-static... Installing package rapidcheck[core]:x64-windows-static... done Elapsed time for package rapidcheck:x64-windows-static: 23.58 s Total elapsed time: 23.58 s The package rapidcheck:x64-windows-static provides CMake targets: find_package(rapidcheck CONFIG REQUIRED) # Note: 2 target(s) were omitted. target_link_libraries(main PRIVATE rapidcheck rapidcheck_boost rapidcheck_catch rapidcheck_gmock) c:\Tools\vcpkg>
NicolasDorier commented at 1:05 PM on June 19, 2019: contributor

tACK
rockstardev commented at 7:27 PM on June 19, 2019: none

tACK... just ran into this problem.
MarcoFalke referenced this in commit b1344eac5f on Jun 19, 2019
MarcoFalke merged this on Jun 19, 2019
MarcoFalke closed this on Jun 19, 2019
fanquake deleted the branch on Jun 19, 2019
DrahtBot locked this on Dec 16, 2021