This remove the patchwork of powershell done in AppVeyor to the AfterBuild target of bitcoind so that windows developers do not have to figure out how to manually edit the config.ini before running the functional tests.
You can easily test with msbuild /t:AfterBuild in bitcoind folder.
I’m not so sure about this change. My personal preference would be that the bitcoin msbuild’s job stops at the point the executables are produced. A majority of the time I do a build I don’t end up running the tests. I’m testing the compilation, debugging etc. Burying non-build related tasks down in one of the vcxproj files seems a bit fragile. If something breaks messing around with a script embedded within XML is not the nicest.
I do get the point about tidying up the test preparation though. What about a script along the lines of the msvc-autogen.py that performs all the test preparation tasks? The process would then be:
Why would you not want to get config.ini generated as part of the build?
Such msbuild task are not more fragile than a python script, also it would need to be documented, while it should not be.
Why would you not want to get config.ini generated as part of the build?
Yes this would be useful.
What about shortening the string replacement snippet using:
0File.WriteAllText(
1 OutputFilename,
2 Regex.Replace(File.ReadAllText(InputFilename), MatchExpression, ReplacementText)
3 );
As per https://stackoverflow.com/questions/7837644/how-to-replace-string-in-file-using-msbuild.
@sipsorcery several problem with the stackoverflow solution:
@NicolasDorier tested this PR and looks good. The python tests run with the produced config.ini.
I did notice that @ENABLE_FUZZ_TRUE@ENABLE_FUZZ=true gets left in the resultant config.ini file. I notice the appveyor logic doesn’t set that variable, it might have been added afterwards.
@sipsorcery strange, as you can see the app veyor script does not talk at all about the ENABLE_FUZZ. The appveyor script replace 8 strings, like mine.
And I don’t set it.
@NicolasDorier my guess is it’s not different. I suspect the appveyor script ends up leaving the @ENABLE_FUZZ_TRUE@ENABLE_FUZZ=true in the resultant config.ini as well. It doesn’t seem to stop the tests running.
Given this PR is touching that logic seems like a good opportunity to fix it.
@sipsorcery got it! done. ping @ken2812221 this might interest you.
In separate PR, I think I will also automatically copy the output file and pdb to src/
ACK 819c5ddad3ca915f77adc94d8b0a5d73069fff99
I merged this branch, built everything and ran the tests (saw one failure, I assume unrelated), then ran the suggested msbuild /t:AfterBuild command from inside bitcoin\build_msvc\bitcoind.
