policy: Add experimental -mempoolreplacement=full (off by default) #16264

1. 
   MarcoFalke commented at 6:40 pm on June 21, 2019: member

   In experimental settings it could make sense to give users the option to enable full replace by fee. The option is off by default, because it could hurt block or transaction propagation for the node that has it enabled.
2. MarcoFalke added the label TX fees and policy on Jun 21, 2019
3. MarcoFalke force-pushed on Jun 21, 2019
4. 
   DrahtBot commented at 9:10 pm on June 21, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #16476 (Use ArgsManager::ALLOW_STRING flag explicitly by hebasto)
   • #16097 (Add Flags enum to ArgsManager class by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. MarcoFalke added the label Needs Conceptual Review on Jun 22, 2019
6. 
   elichai commented at 8:18 pm on June 25, 2019: contributor

   ConceptACK, Sounds like a good idea. it should be the users decision to turn on this feature
7. in test/functional/feature_rbf.py:411 in fa7252e462 outdated

   407@@ -391,7 +408,8 @@ def test_too_many_replacements(self):
   408             tx_i.vin = [CTxIn(COutPoint(txid, i), nSequence=0)]
   409             tx_i.vout = [CTxOut(split_value - fee, CScript([b'a' * 35]))]
   410             tx_i_hex = txToHex(tx_i)
   411-            self.nodes[0].sendrawtransaction(tx_i_hex, 0)
   412+            for i in self.RBF_NODES:
   

   ---

   ---

   

   practicalswift commented at 8:44 pm on June 27, 2019:

   Is the redefining on i from the outer scope intentional here?
8. DrahtBot added the label Needs rebase on Jul 17, 2019
9. test: Sync nodes in helper method (simplify feature_rbf test) fa96efffea
10. policy: Add experimental -mempoolreplacement=full (off by default) fa31764911
11. MarcoFalke force-pushed on Jul 17, 2019
12. DrahtBot removed the label Needs rebase on Jul 17, 2019
13. 
    TheBlueMatt commented at 8:00 pm on July 30, 2019: member

    I’m -0.5 on this one. I’m not sure its really worth much, and I’m unclear on exactly what it solves. That said, #10823 probably solves whatever this solves without needlessly irritating random trolls, and we don’t have to make it opt-in.
14. MarcoFalke closed this on Jul 30, 2019

    ---

15. MarcoFalke deleted the branch on Jul 30, 2019
16. 
    luke-jr commented at 11:40 pm on August 19, 2019: member

    See #7219
17. MarcoFalke locked this on Dec 16, 2021

Contributors
MarcoFalke DrahtBot elichai practicalswift TheBlueMatt luke-jr

Labels
TX fees and policy Needs Conceptual Review