refactor: remove extra CBlockIndex declaration #16287

pull rrybarczyk wants to merge 1 commits into bitcoin:master from rrybarczyk:remove-extra-cblockindex changing 1 files +0 −1

rrybarczyk commented at 7:10 PM on June 25, 2019: contributor

Remove duplicate class CBlockIndex; declaration.
Remove extra CBlockIndex declaration 9824a0d6e9
DrahtBot added the label Validation on Jun 25, 2019
promag commented at 9:45 PM on June 25, 2019: member

ACK 9824a0d. Is this a random finding or you have searched for more similar cases?
rrybarczyk commented at 10:35 PM on June 25, 2019: contributor

Just a random find
MarcoFalke added the label Refactoring on Jun 25, 2019
MarcoFalke removed the label Validation on Jun 25, 2019
fanquake renamed this:
~~Remove extra CBlockIndex declaration~~
refactor: remove extra CBlockIndex declaration
on Jun 26, 2019
fanquake approved
fanquake commented at 3:53 AM on June 26, 2019: member

ACK 9824a0d6e91f75477b8417a2acb3301a8e8d8aa1

Initial usage was introduced in d76a8acb9b7bcabf43e3e05168a36911f187818d (#6680). The duplicate was introduced in 7d0bf0bb4652fad052d5bf3ca3bf883754b46ead (#6480), which was actually merged after #6680.
practicalswift commented at 8:32 AM on June 26, 2019: contributor
utACK 9824a0d6e91f75477b8417a2acb3301a8e8d8aa1

Welcome as a contributor! @promag This seems to be the only instance:
```
$ git grep -E '^(class|struct|extern) .*;' -- "*.h" "*.cpp" | sort | uniq -c | grep -vE ' 1 '
      2 src/validationinterface.h:class CBlockIndex;
```
MarcoFalke merged this on Jun 26, 2019
MarcoFalke closed this on Jun 26, 2019
MarcoFalke referenced this in commit 1b28bca04c on Jun 26, 2019
promag commented at 8:53 PM on June 26, 2019: member

@practicalswift nice ;)
jasonbcox referenced this in commit f498cf0abb on Sep 22, 2020
DrahtBot locked this on Dec 16, 2021

Contributors

Labels