tests: make check currently broken on macOS #16288

issue fanquake opened this issue on June 26, 2019
  1. fanquake commented at 3:47 AM on June 26, 2019: member
    git checkout master && git clean -fxd && ./autogen.sh && ./configure && make check -j8
    .....
    Running tests: torcontrol_tests from test/torcontrol_tests.cpp
    Running tests: transaction_tests from test/transaction_tests.cpp
    Running tests: txindex_tests from test/txindex_tests.cpp
    ../build-aux/test-driver: line 107: 85583 Abort trap: 6           "$@" > $log_file 2>&1
    FAIL: qt/test/test_bitcoin-qt
    
    cat src/test-suite.log 
    ==============================================
       Bitcoin Core 0.18.99: src/test-suite.log
    ==============================================
    
    # TOTAL: 1
    # PASS:  0
    # SKIP:  0
    # XFAIL: 0
    # FAIL:  1
    # XPASS: 0
    # ERROR: 0
    
    .. contents:: :depth: 2
    
    FAIL: qt/test/test_bitcoin-qt
    =============================
    
    ********* Start testing of AppTests *********
    Config: Using QtTest library 5.12.3, Qt 5.12.3 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 10.0.1 (clang-1001.0.46.4) (Apple))
    PASS   : AppTests::initTestCase()
    WARNING: AppTests::appTests() Skipping AppTests on mac build with 'minimal' platform set due to Qt bugs. To run AppTests, invoke with 'test_bitcoin-qt -platform cocoa' on mac, or else use a linux or windows build.
       Loc: [qt/test/apptests.cpp(61)]
    PASS   : AppTests::appTests()
    PASS   : AppTests::cleanupTestCase()
    Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 1ms
    ********* Finished testing of AppTests *********
    ********* Start testing of URITests *********
    Config: Using QtTest library 5.12.3, Qt 5.12.3 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 10.0.1 (clang-1001.0.46.4) (Apple))
    PASS   : URITests::initTestCase()
    PASS   : URITests::uriTests()
    PASS   : URITests::cleanupTestCase()
    Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 0ms
    ********* Finished testing of URITests *********
    ********* Start testing of RPCNestedTests *********
    Config: Using QtTest library 5.12.3, Qt 5.12.3 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 10.0.1 (clang-1001.0.46.4) (Apple))
    PASS   : RPCNestedTests::initTestCase()
    Assertion failed: (secp256k1_context_sign == nullptr), function ECC_Start, file key.cpp, line 349.
    FAIL qt/test/test_bitcoin-qt (exit status: 134)
    

    Looks like it's been failing since #16252, cc @MarcoFalke.

    git checkout bc948d4cfd6da2effa8c2ae619e11e83207c6fbc && git clean -fxd && ./autogen.sh && ./configure && make check -j8
    ....
    Running tests: db_tests from wallet/test/db_tests.cpp
    PASS: qt/test/test_bitcoin-qt
    Running tests: psbt_wallet_tests from wallet/test/psbt_wallet_tests.cpp
    ============================================================================
    Testsuite summary for Bitcoin Core 0.18.99
    ============================================================================
    # TOTAL: 1
    # PASS:  1
    
  2. fanquake added the label Tests on Jun 26, 2019
  3. AkioNak commented at 7:32 AM on June 26, 2019: contributor

    I think ECC_Stop() should call before #ifdef Q_OS_MAC in AppTests::appTests() not after #endif. https://github.com/bitcoin/bitcoin/blob/master/src/qt/test/apptests.cpp#L52-L67

  4. jonasschnelli commented at 9:21 AM on June 26, 2019: contributor

    I think ECC_Stop() should call before #ifdef Q_OS_MAC in AppTests::appTests() not after #endif. https://github.com/bitcoin/bitcoin/blob/master/src/qt/test/apptests.cpp#L52-L67

    Almost (it would fix the issue though). The correct fix is to add the missing ECC_Stop(); in void RPCNestedTests::rpcNestedTests(). Will PR.

  5. MarcoFalke closed this on Jun 26, 2019

  6. MarcoFalke referenced this in commit 3077f11dad on Jun 26, 2019
  7. Munkybooty referenced this in commit 2ae4f24a5c on Nov 2, 2021
  8. Munkybooty referenced this in commit de99f19b98 on Nov 2, 2021
  9. Munkybooty referenced this in commit 067f0a4605 on Nov 4, 2021
  10. Munkybooty referenced this in commit 3bc1982862 on Nov 16, 2021
  11. Munkybooty referenced this in commit 716f124b00 on Nov 18, 2021
  12. DrahtBot locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-16 21:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me