test: Add missing ECC_Stop() in GUI rpcnestedtests.cpp #16289

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2019/06/fix_rpcnested_test changing 1 files +3 −1

jonasschnelli commented at 9:34 AM on June 26, 2019: contributor

Fixes #16288

Was probably missing in #7783
Add missing ECC_Stop(); in GUI rpcnestedtests.cpp f466c4ce84
jonasschnelli added the label GUI on Jun 26, 2019
jonasschnelli added the label Tests on Jun 26, 2019
fanquake renamed this:
~~Add missing ECC_Stop(); in GUI rpcnestedtests.cpp~~
test: Add missing ECC_Stop() in GUI rpcnestedtests.cpp
on Jun 26, 2019
fanquake approved
fanquake commented at 11:10 AM on June 26, 2019: member

ACK f466c4ce846000b2f984b4759f89f3f793fa0100. Tested running make check on macOS.
MarcoFalke commented at 4:16 PM on June 26, 2019: member

Why is this only happening on macos?
jonasschnelli commented at 5:39 PM on June 26, 2019: contributor

Because on Mac, the AppTests::appTests() gets skipped and misses the ECC_Stop() which would have cured the issue that ECC_Start() gets double initialized through RPCNestedTests::rpcNestedTests() -> TestingSetup test.

I don't know if we could get rid of TestingSetup test in RPCNestedTests::rpcNestedTests() though.
DrahtBot commented at 9:12 PM on June 26, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #16294 (qt: test: Create at most one testing setup by MarcoFalke)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Sjors commented at 9:19 PM on June 26, 2019: member

ACK f466c4c. Tested by comparing make check on master and this PR with macOS 10.14.5. I also tried with and without --enable-debug / --without-gui.
MarcoFalke merged this on Jun 26, 2019
MarcoFalke closed this on Jun 26, 2019
MarcoFalke referenced this in commit 3077f11dad on Jun 26, 2019
pull[bot] referenced this in commit 7400135b79 on Jun 27, 2019
deadalnix referenced this in commit abd12750b3 on Mar 26, 2020
Munkybooty referenced this in commit 2ae4f24a5c on Nov 2, 2021
Munkybooty referenced this in commit de99f19b98 on Nov 2, 2021
Munkybooty referenced this in commit 067f0a4605 on Nov 4, 2021
Munkybooty referenced this in commit 3bc1982862 on Nov 16, 2021
Munkybooty referenced this in commit 716f124b00 on Nov 18, 2021
vijaydasmp referenced this in commit 3531aa95e8 on Nov 23, 2021
vijaydasmp referenced this in commit 4d1b3654aa on Nov 23, 2021
vijaydasmp referenced this in commit bfb32d6b2d on Nov 24, 2021
vijaydasmp referenced this in commit 3f839b0758 on Nov 25, 2021
vijaydasmp referenced this in commit 89b2eccaa0 on Nov 26, 2021
PastaPastaPasta referenced this in commit b0b8b2d2a9 on Nov 30, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#7783 [Qt] RPC-Console: support nested commands and simple value queries #16288 tests: make check currently broken on macOS

test: Add missing ECC_Stop() in GUI rpcnestedtests.cpp #16289

Conflicts