gui: Stop translating PACKAGE_NAME #16291

pull MarcoFalke wants to merge 4 commits into bitcoin:master from MarcoFalke:1906-noTranslatePackageName changing 17 files +303 −250
  1. MarcoFalke commented at 3:11 pm on June 26, 2019: member

    Generally the package name is not translated, but the package description is.

    E.g. GIMP or Firefox are always called that way regardless of the system language. However, “Firefox webbrowser” or “GIMP image manipulation program” are translated.

  2. build: Stop translating PACKAGE_NAME fa5e9f157e
  3. scripted-diff: Avoid passing PACKAGE_NAME for translation 
    -BEGIN VERIFY SCRIPT-
sed -i --regexp-extended -e 's/\<\w+(::\w+)?\(PACKAGE_NAME\)/PACKAGE_NAME/g' $(git grep -l --extended-regexp '\<\w+(::\w+)?\(PACKAGE_NAME\)' src)
-END VERIFY SCRIPT-
    fabe87d2c9
  4. qt: Run «make translate» in ./src/ fab85208f6
  5. MarcoFalke added the label GUI on Jun 26, 2019
  6. MarcoFalke added the label Needs Conceptual Review on Jun 26, 2019
  7. hebasto commented at 3:17 pm on June 26, 2019: member
    Strong concept ACK (https://github.com/bitcoin/bitcoin/pull/15894#discussion_r297326036).
  8. MarcoFalke commented at 3:25 pm on June 26, 2019: member

    The GUI never picked up the translation anyway, so there shouldn’t be any user-facing changes other than in InitErrors (See the difference between “Bitcoin Core” and “Bitcoin Kern”):

    Screenshot from 2019-06-26 11-23-15

    Edit: So I’d say to backport this change to 0.18.1

  9. MarcoFalke removed the label Needs Conceptual Review on Jun 26, 2019
  10. promag commented at 4:08 pm on June 26, 2019: member
    Concept ACK.
  11. laanwj commented at 4:44 pm on June 26, 2019: member
    Concept ACK
  12. DrahtBot commented at 6:01 pm on June 26, 2019: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #16224 (gui: Bilingual GUI error messages by hebasto)
    • #15864 (Fix datadir handling by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  13. practicalswift commented at 6:12 pm on June 26, 2019: contributor
    Concept ACK
  14. fanquake commented at 2:44 am on June 27, 2019: member

    @MarcoFalke

    So I’d say to backport this change to 0.18.1

    What would be the benefit of backporting this? Isn’t it just a simplification to the code that wont have any user facing effects?

  15. MarcoFalke commented at 2:58 am on June 27, 2019: member
    Only the following instances are translated: git grep '_(PACKA', but not the others.
  16. laanwj commented at 8:18 am on June 27, 2019: member

    What would be the benefit of backporting this? Isn’t it just a simplification to the code that wont have any user facing effects?

    The only user-visible impact would be the InitErrors, I guess. It also reduces the workload of translators a bit by removing one(!) translation message. I don’t think it’s strictly necessary for backport but as there’s really no added risk it doesn’t hurt either.

  17. fanquake added this to the milestone 0.18.1 on Jun 27, 2019
  18. fanquake added the label Needs backport on Jun 27, 2019
  19. hebasto commented at 4:19 pm on June 27, 2019: member
    Is the qt: Run «make translate» in ./src/ commit (fab85208f678ba1be53bdb73a73ce3c5c937d448) a subject to review? It seems it should be a part of the release process, right?
  20. MarcoFalke commented at 4:27 pm on June 27, 2019: member
    Yes, it is subject to review, since I changed the buildfile and reviewers will need to check that the new buildfile works as expected anyway (with or without my commit).
  21. hebasto commented at 6:52 pm on June 27, 2019: member
    Is any reason to keep both PACKAGE_NAME and COPYRIGHT_HOLDERS_SUBSTITUTION?
  22. util: No translation of `Bitcoin Core` in the copyright fa64b947bb
  23. MarcoFalke commented at 7:54 pm on June 27, 2019: member
    I changed it so that COPYRIGHT_HOLDERS_SUBSTITUTION is also no longer translated, but I kept it for now. Maybe @luke-jr knows more why it is needed.
  24. MarcoFalke added the label Needs gitian build on Jun 27, 2019
  25. MarcoFalke removed the label Needs gitian build on Jun 27, 2019
  26. MarcoFalke added the label Needs gitian build on Jun 27, 2019
  27. luke-jr commented at 4:18 am on June 28, 2019: member

    Generally, COPYRIGHT_HOLDERS_SUBSTITUTION should be “Bitcoin Core” even for software that isn’t named “Bitcoin Core”.

    Regarding the PR itself: Should we get input from translators who have been using translated package names for a long time?

  28. laanwj commented at 12:28 pm on June 28, 2019: member

    Regarding the PR itself: Should we get input from translators who have been using translated package names for a long time?

    It can’t hurt to ask people’s input, but I’m not sure this makes much of a difference. E.g. are there any other occurences of “Bitcoin core” in the translated messages that shouldn’t be translated?

  29. MarcoFalke commented at 1:23 pm on June 28, 2019: member

    are there any other occurences of “Bitcoin core” in the translated messages that shouldn’t be translated?

    It doesn’t look like it:

    0git grep 'Bitcoin Core' src/qt/locale/|grep '<source>'|grep -v '<source>Bitcoin Core</source>'|wc
1      0       0       0
  30. DrahtBot commented at 2:04 am on June 29, 2019: member

    Gitian builds for commit 7400135b7918df9c34206bead744c496e07b0e78 (master):

    Gitian builds for commit 0b2f4ee1f385b88a4a1d11ff4c0d7823950df8ef (master and this pull):

  31. DrahtBot removed the label Needs gitian build on Jun 29, 2019
  32. in src/util/system.cpp:1191 in fa64b947bb 
    1187@@ -1188,10 +1188,11 @@ int GetNumCores()
1188 
1189 std::string CopyrightHolders(const std::string& strPrefix)
1190 {
1191-    std::string strCopyrightHolders = strPrefix + strprintf(_(COPYRIGHT_HOLDERS), _(COPYRIGHT_HOLDERS_SUBSTITUTION));
1192+    const auto copyright_devs = strprintf(_(COPYRIGHT_HOLDERS), COPYRIGHT_HOLDERS_SUBSTITUTION);
    hebasto commented at 11:07 am on July 4, 2019:

    nit:

    0const std::string copyright_devs = strprintf(_(COPYRIGHT_HOLDERS), COPYRIGHT_HOLDERS_SUBSTITUTION);
  33. hebasto approved
  34. hebasto commented at 11:08 am on July 4, 2019: member
    ACK fa64b947bb3075ff8737656706b941af691908ab, I have not tested the code, but I have reviewed it and it looks OK, I agree it can be merged.
  35. MarcoFalke merged this on Jul 8, 2019
  36. MarcoFalke closed this on Jul 8, 2019
  37. MarcoFalke referenced this in commit 4882040182 on Jul 8, 2019
  38. MarcoFalke deleted the branch on Jul 8, 2019
  39. sidhujag referenced this in commit 61ac06cf25 on Jul 9, 2019
  40. fanquake commented at 5:59 am on July 24, 2019: member
    Is this still a candidate for backport? It’s likely missed v0.18.1 unless we have an rc2. But could still be pulled into the v0.18 branch if wanted.
  41. fanquake referenced this in commit 0354cd39d8 on Aug 15, 2019
  42. fanquake referenced this in commit b6ef374e8a on Aug 15, 2019
  43. fanquake referenced this in commit dd30db74ea on Aug 15, 2019
  44. fanquake removed the label Needs backport on Aug 15, 2019
  45. fanquake removed this from the milestone 0.18.1 on Aug 15, 2019
  46. fanquake added this to the milestone 0.18.2 on Aug 15, 2019
  47. fanquake commented at 2:04 am on August 15, 2019: member
    Bumped to 0.18.2. I’ve included this for backport in #16617.
  48. fanquake referenced this in commit 7b43b471f3 on Aug 24, 2019
  49. fanquake referenced this in commit 81f8968a5d on Aug 24, 2019
  50. fanquake referenced this in commit a155a564a8 on Aug 24, 2019
  51. fanquake referenced this in commit a44e18f20b on Sep 23, 2019
  52. fanquake referenced this in commit 87908e9c98 on Sep 23, 2019
  53. fanquake referenced this in commit 9d389d09ed on Sep 23, 2019
  54. laanwj referenced this in commit 29d70264fb on Nov 25, 2019
  55. deadalnix referenced this in commit a39dd32352 on Apr 21, 2020
  56. deadalnix referenced this in commit cb75d6b66c on Apr 21, 2020
  57. ftrader referenced this in commit 4b53a41db6 on Apr 14, 2021
  58. random-zebra referenced this in commit e988d40e1f on Sep 6, 2021
  59. DrahtBot locked this on Feb 15, 2022


MarcoFalke hebasto promag laanwj DrahtBot practicalswift fanquake luke-jr

Labels
GUI

Milestone
0.18.2

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-06-29 10:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me