docs: Use placeholder instead of key expiration date #16330

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20190702-key-expiration changing 1 files +1 −1

hebasto commented at 8:20 PM on July 2, 2019: member

Use a placeholder instead of the actual expiration date, so that the documentation doesn't require updating every time an expiry date changes.
in contrib/verifybinaries/README.md:9 in 4ad19a1d4b outdated
```
   5 | @@ -6,7 +6,7 @@ Make sure you obtain the proper release signing key and verify the fingerprint w
   6 |  
   7 |  ```sh
   8 |  $ gpg --fingerprint "Bitcoin Core binary release signing key"
   9 | -pub   4096R/36C2E964 2015-06-24 [expires: 2017-02-13]
  10 | +pub   4096R/36C2E964 2015-06-24 [expires: 2022-02-10]
```
MarcoFalke commented at 8:25 PM on July 2, 2019:

pub 4096R/36C2E964 2015-06-24
hebasto commented at 8:34 PM on July 2, 2019:

Is it ok if the gpg example output does not match the real one? I mean that gpg actually prints expires: string.

MarcoFalke commented at 8:41 PM on July 2, 2019:

Alternatively you can change the text to something like:

gpg --fingerprint "01EA 5486 DE18 A882 D4C2 6845 90C8 019E 36C2 E964" should return a key and not an error.

fanquake commented at 7:44 AM on July 3, 2019:

I don't see a problem with matching the real gpg output.

laanwj commented at 9:02 AM on July 3, 2019:

or replace it with YYYY-MM-DD, so it's clear there needs to be something there, but this document doesn't need to be updated every time for it. There's already too many things that need to be updated after an expiration date bump (and apparently we're still finding new things! good catch).

practicalswift commented at 9:06 AM on July 3, 2019:

gpg --fingerprint "Bitcoin Core binary release signing key" | cut -f1 -d'[' :-)

MarcoFalke commented at 11:55 AM on July 3, 2019:

The only reason I added the gpg output here, is to have the fingerprint written down in our doc. The reason was not to have some gpg output here that is supposed to be constantly updated whenever a date or version changes. I think we have better things to do and solve.
fanquake added the label Docs on Jul 2, 2019
hebasto force-pushed on Jul 3, 2019
Use placeholder instead of key expiration date 88fd556a96
hebasto force-pushed on Jul 3, 2019
fanquake renamed this:
~~docs: Update release signing key expiration date~~
docs: Use placeholder instead of key expiration date
on Jul 4, 2019
fanquake approved
fanquake commented at 3:03 AM on July 4, 2019: member

ACK 88fd556a969d1120a0ff633bc384336388a11709
fanquake merged this on Jul 4, 2019
fanquake closed this on Jul 4, 2019
fanquake referenced this in commit dfdcb3dfe5 on Jul 4, 2019
hebasto deleted the branch on Jul 4, 2019
PastaPastaPasta referenced this in commit b931f5b8f3 on Jun 27, 2021
PastaPastaPasta referenced this in commit f9b2a540ce on Jun 28, 2021
PastaPastaPasta referenced this in commit b9b035472b on Jun 29, 2021
PastaPastaPasta referenced this in commit 024c146c2b on Jul 1, 2021
PastaPastaPasta referenced this in commit 663ddee643 on Jul 1, 2021
PastaPastaPasta referenced this in commit f665e17962 on Jul 12, 2021
PastaPastaPasta referenced this in commit 11a37feac1 on Jul 13, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels