build: prune dbus from depends #16352

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:depends_prune_dbus changing 3 files +1 −29
  1. fanquake commented at 6:59 am on July 7, 2019: member

    Since #8210 (59d063d07660d6e8d53ed8aa1eb8b0747ea6767c), we’ve been passing -dbus-runtime when configuring Qt.

    0qtbase-opensource-src-5.9.7 $ ./configure -h | grep -i dbus
1  -no-dbus ............. Do not build the Qt D-Bus module
2  -dbus-linked ......... Build Qt D-Bus and link to libdbus-1 [auto]
3  -dbus-runtime ........ Build Qt D-Bus and dynamically load libdbus-1 [no]

    This means we don’t actually seem to be using the D-Bus we build in depends. This was pointed out by theuni at the time, here and here, but was never followed up. dongcarl also bought it up as part of #16150.

    I’ve tested building and running bitcoin-qt using depends on Debian. Needs further testing.

  2. build: prune dbus from depends e8fabd9253
  3. fanquake added the label Build system on Jul 7, 2019
  4. fanquake added the label Needs gitian build on Jul 7, 2019
  5. fanquake requested review from theuni on Jul 7, 2019
  6. fanquake requested review from dongcarl on Jul 7, 2019
  7. DrahtBot commented at 9:22 am on July 7, 2019: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #16270 (depends: expat 2.2.7 by fanquake)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  8. practicalswift commented at 5:35 pm on July 7, 2019: contributor
    Concept ACK
  9. DrahtBot commented at 1:40 am on July 8, 2019: member

    Gitian builds for commit f373beebbcc0c7d1160e02dc638a00b3e6831d98 (master):

    Gitian builds for commit 85200ca2adf9da7400f10097f2538b59cb4b47a5 (master and this pull):

  10. DrahtBot removed the label Needs gitian build on Jul 8, 2019
  11. laanwj commented at 9:41 am on July 8, 2019: member

    Thanks

    Are there no transitive dependencies that have become unnecessary due to this?

    code review ACK e8fabd9253400a7c3fe45b34bc572eb00ff5522d

  12. fanquake commented at 10:27 am on July 8, 2019: member

    Are there no transitive dependencies that have become unnecessary due to this?

    Not yet. expat is still required for at least fontconfig: https://github.com/bitcoin/bitcoin/blob/e1a8d76aff8d70e63f399df05ee555760f1b5514/depends/packages/fontconfig.mk#L6

  13. laanwj commented at 11:20 am on July 8, 2019: member
    Glad to hear it’s one step toward no longer needing expat :+1:
  14. laanwj merged this on Jul 8, 2019
  15. laanwj closed this on Jul 8, 2019
  16. laanwj referenced this in commit 983c84844c on Jul 8, 2019
  17. sidhujag referenced this in commit ed68cfbf17 on Jul 9, 2019
  18. fanquake deleted the branch on Oct 17, 2019
  19. deadalnix referenced this in commit 805ed73c0c on Apr 1, 2020
  20. ftrader referenced this in commit 2a7dc8f242 on Aug 13, 2021
  21. PastaPastaPasta referenced this in commit 6d6b585aff on Oct 22, 2021
  22. DrahtBot locked this on Dec 16, 2021


fanquake DrahtBot practicalswift laanwj


theuni dongcarl

Labels
Build system

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-05 01:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me