depends: cleanup package configure flags #16370

fanquake commented at 2:54 AM on July 11, 2019: member

Related to #16354.

This PR adds additional configure flags to packages in depends to explicitly disable features we aren't using; similar to #16183. It also fixes passing --without-tools to qrencode.

I've added --disable-drafts to zeromq:

Build and install draft classes and methods [default=yes]

I'm not entirely sure how far we want to take this. i.e in the zeromq package we explicitly pass --without-libsodium, even though it's disabled by default.

Do we also want to explicitly pass all the other --without flags? :

  --with-libgssapi_krb5   require libzmq build with libgssapi_krb5
                          [default=no]
  --with-libsodium        use libsodium instead of built-in tweetnacl
                          [default=no]
  --with-pgm              build libzmq with PGM extension. Requires pkg-config
                          [default=no]
  --with-norm             build libzmq with NORM protocol extension,
                          optionally specifying norm path [default=no]
  --with-vmci             build libzmq with VMCI transport [default=no]

fanquake added the label Build system on Jul 11, 2019

fanquake requested review from dongcarl on Jul 11, 2019

fanquake added the label Needs gitian build on Jul 11, 2019

Sjors commented at 1:26 PM on July 11, 2019: member

Less is more :-) I'm able to build and run QT on macOS 10.14.5 with 9a3e237. test/functional/interface_zmq.py passes.

Explicitly passing all --without flags seems like a good idea; it means we don't to worry about the upstream default changing and it's also easier to reason about.

DrahtBot removed the label Needs gitian build on Jul 12, 2019

dongcarl commented at 6:37 PM on July 12, 2019: member

Concept ACK. Looking at the DrahtBot logs, xproto and xextproto are both headers-only, so let's remove --disable-shared from them!

I think we should explicitly pass all --without flags... Silent behavioral changes are the worst kind.

fanquake force-pushed on Jul 13, 2019

fanquake added the label Needs gitian build on Jul 13, 2019

practicalswift commented at 4:12 PM on July 13, 2019: contributor

Concept ACK

Compilation times before and after would be interesting to see.

Nice cleanup regardless of compilation time impact though.

DrahtBot removed the label Needs gitian build on Jul 14, 2019

DrahtBot commented at 12:41 AM on July 18, 2019: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

fanquake force-pushed on Jul 23, 2019

fanquake commented at 7:15 AM on July 23, 2019: member

Rebased for #16408.

in depends/packages/fontconfig.mk:9 in 0d359bf555 outdated

   5 | @@ -6,7 +6,7 @@ $(package)_sha256_hash=b449a3e10c47e1d1c7a6ec6e2016cca73d3bd68fbbd4f0ae5cc6b573f
   6 |  $(package)_dependencies=freetype expat
   7 |  
   8 |  define $(package)_set_vars
   9 | -  $(package)_config_opts=--disable-docs --disable-static
  10 | +  $(package)_config_opts=--disable-docs --disable-static --disable-libxml2

dongcarl commented at 3:32 PM on July 23, 2019:

After inspecting the autoconf files, it seems that iconv is currently disabled and should probably be in the future as well.

  $(package)_config_opts=--disable-docs --disable-static --disable-libxml2 --disable-iconv

fanquake commented at 5:57 AM on July 24, 2019:

Done.

in depends/packages/qrencode.mk:8 in 0d359bf555 outdated

   4 | @@ -5,7 +5,7 @@ $(package)_file_name=$(package)-$($(package)_version).tar.bz2
   5 |  $(package)_sha256_hash=efe5188b1ddbcbf98763b819b146be6a90481aac30cfc8d858ab78a19cde1fa5
   6 |  
   7 |  define $(package)_set_vars
   8 | -$(package)_config_opts=--disable-shared -without-tools --disable-sdltest
   9 | +$(package)_config_opts=--disable-shared --without-tools --without-tests --disable-sdltest

dongcarl commented at 4:03 PM on July 23, 2019:

$(package)_config_opts=--disable-shared --without-tools --without-tests --disable-sdltest --disable-gprof --disable-gcov --disable-mudflap --without-libiconv-prefix

fanquake commented at 5:59 AM on July 24, 2019:

Done.

theuni commented at 8:49 PM on July 31, 2019:

Let's not mix --without-libiconv-prefix into these changes, that's just related to its search path. iconv is only used for the tests (which aren't compiled) anyway.

fanquake commented at 3:04 AM on August 1, 2019:

Updated to remove --without-libiconv-prefix. Docs:

--with-libiconv-prefix[=DIR]  search for libiconv in DIR/include and DIR/lib

in depends/packages/zeromq.mk:9 in 0d359bf555 outdated

   5 | @@ -6,7 +6,8 @@ $(package)_sha256_hash=bcbabe1e2c7d0eec4ed612e10b94b112dd5f06fcefa994a0c79a45d83
   6 |  $(package)_patches=0001-fix-build-with-older-mingw64.patch 0002-disable-pthread_set_name_np.patch
   7 |  
   8 |  define $(package)_set_vars
   9 | -  $(package)_config_opts=--without-docs --disable-shared --without-libsodium --disable-curve --disable-curve-keygen --disable-perf --disable-Werror
  10 | +  $(package)_config_opts=--without-docs --disable-shared --disable-curve --disable-curve-keygen --disable-perf --disable-Werror --disable-drafts

dongcarl commented at 5:11 PM on July 23, 2019:

We can add: --disable-libunwind --disable-radix-tree --without-gcov --without-militant

fanquake commented at 5:59 AM on July 24, 2019:

Done.

theuni commented at 8:58 PM on July 31, 2019:

--with-militant         enable militant API assertions

Disabling this (the current default) sounds like a safety downgrade...

in depends/packages/libXau.mk:11 in 0d359bf555 outdated

   5 | @@ -6,7 +6,7 @@ $(package)_sha256_hash=fdd477320aeb5cdd67272838722d6b7d544887dfe7de46e1e7cc0c27c
   6 |  $(package)_dependencies=xproto
   7 |  
   8 |  define $(package)_set_vars
   9 | -  $(package)_config_opts=--disable-shared
  10 | +  $(package)_config_opts=--disable-shared --disable-lint-library --without-lint

dongcarl commented at 5:27 PM on July 23, 2019:

Nit: Took a look at --disable-xthreads in the autoconf files... It seems that it's currently enabled. I'm not sure what the impact is of disabling it so we'll leave it for now.

fanquake commented at 5:58 AM on July 24, 2019:

Did you want to add a comment here somewhere, even just as a reminder in future if this package is updated / defaults change etc.

dongcarl commented at 3:14 PM on July 30, 2019:

Yeah a comment would be great for the future!

fanquake commented at 7:13 AM on July 31, 2019:

Added a comment.

in depends/packages/libxcb.mk:9 in 0d359bf555 outdated

   5 | @@ -6,7 +6,7 @@ $(package)_sha256_hash=98d9ab05b636dd088603b64229dd1ab2d2cc02ab807892e107d674f9c
   6 |  $(package)_dependencies=xcb_proto libXau
   7 |  
   8 |  define $(package)_set_vars
   9 | -$(package)_config_opts=--disable-static
  10 | +$(package)_config_opts=--disable-static --disable-build-docs --without-doxygen

dongcarl commented at 5:30 PM on July 23, 2019:

This is a candidate for another issue... It seems that we build all of the default XCB Extensions, but the -qt-xcb option we supply to QT might cause it to build them as well. (source: https://doc.qt.io/qt-5.9/linux-requirements.html)

fanquake commented at 6:07 AM on July 24, 2019:

Opened an issue to track that: https://github.com/bitcoin/bitcoin/issues/16447

theuni commented at 8:43 PM on July 31, 2019:

Looks like we should set --without-launchd as well.

fanquake commented at 3:02 AM on August 1, 2019:

Updated with --without-launchd. Docs are:

--with-launchd Build with support for Apple's launchd (default: auto)

in depends/packages/xproto.mk:8 in 0d359bf555 outdated

   4 | @@ -5,7 +5,7 @@ $(package)_file_name=$(package)-$($(package)_version).tar.bz2
   5 |  $(package)_sha256_hash=636162c1759805a5a0114a369dffdeccb8af8c859ef6e1445f26a4e6e046514f
   6 |  
   7 |  define $(package)_set_vars
   8 | -$(package)_config_opts=--disable-shared
   9 | +$(package)_config_opts=--without-fop --without-xmlto --without-xsltproc

dongcarl commented at 5:34 PM on July 23, 2019:

Nit: Looking at https://gist.github.com/dongcarl/892d7deda8da3ff72317009ecbb07ffb#file-xproto-configure-help-L80-L90, I'm not sure what the specs and prototypes are... If anyone else knows please say so, otherwise we can leave it.

fanquake commented at 6:04 AM on July 24, 2019:

From the looks of this mailing list post they are probably related to documentation generation?

Document building enablement macros. This allows a builder to skip document generation if such documents are not desired. They should not be used to workaround tooling issues, use macros above. By default, building is enabled. The default value can be changed from configure.ac by invoking the macro like XORG_ENABLE_SPECS(no)

XORG_ENABLE_DOCS ENABLE_DOCS General documentation XORG_ENABLE_DEVEL_DOCS ENABLE_DEVEL_DOCS More specifically developer's documentation XORG_ENABLE_SPECS ENABLE_SPECS More specifically functional specifications

dongcarl commented at 5:52 PM on July 30, 2019:

Let's just do --disable-specs, I was able to successfully do a guix build even with --disable-specs. You can put a comment there for the other flags or don't, either way is fine :-)

fanquake commented at 7:13 AM on July 31, 2019:

Updated with --disable-specs.

in depends/packages/zeromq.mk:10 in 0d359bf555 outdated

   5 | @@ -6,7 +6,8 @@ $(package)_sha256_hash=bcbabe1e2c7d0eec4ed612e10b94b112dd5f06fcefa994a0c79a45d83
   6 |  $(package)_patches=0001-fix-build-with-older-mingw64.patch 0002-disable-pthread_set_name_np.patch
   7 |  
   8 |  define $(package)_set_vars
   9 | -  $(package)_config_opts=--without-docs --disable-shared --without-libsodium --disable-curve --disable-curve-keygen --disable-perf --disable-Werror
  10 | +  $(package)_config_opts=--without-docs --disable-shared --disable-curve --disable-curve-keygen --disable-perf --disable-Werror --disable-drafts
  11 | +  $(package)_config_opts += --without-libsodium --without-libgssapi_krb5 --without-pgm --without-norm --without-vmci

dongcarl commented at 5:41 PM on July 23, 2019:

Looking at https://gist.github.com/dongcarl/892d7deda8da3ff72317009ecbb07ffb#file-zeromq-configure-help-L114-L120, I'm reminded that after we're able to use Guix for release builds, we will finally be able to, and definitely should specify what the minimal kernel headers are that we target for each architecture. We don't want to target kernel headers that are too new, have the zeromq build auto-assume we have the fancy new ekquelect (not an actual thing) available, and then not be able to run on older kernels.

fanquake commented at 6:10 AM on July 24, 2019:

Is this something you'd like to document here, or should we start tracking future Guix related improvements somewhere else? Depends how much there is to keep track of.

dongcarl commented at 5:51 PM on July 30, 2019:

Tracked https://github.com/bitcoin/bitcoin/issues/16496

dongcarl commented at 5:46 PM on July 23, 2019: member

Much needed work, many thanks for starting it!

I reviewed this PR with the help of this gist, which contains all the configure --help outputs of the packages you've touched here.

dongcarl commented at 5:52 PM on July 23, 2019: member

Thinking a little harder about our policy w/re configure flags here... I believe that our approach with these cleanups should be to explicitly disable as many features and packages as possible without changing Bitcoin Core's functionality.

Going forward, we can keep our builds sane by simply requiring (at review time) a diff of the configure --help output for every package version bump. We will change configure flags only to support new Bitcoin Core features or to disable new and unneeded features/packages for depends package version bumps.

theuni commented at 6:04 PM on July 23, 2019: member

@dongcarl I agree with the spirit of that idea, but I don't think we should actually attempt to automate or codify.

We need to be a little more surgical about this, imo. Remember that buildsystems are imperfect. An explicit "--without-foo" may accidentally produce a different result from an auto-detected missing "foo". The most obvious example of this would be configuring Core with an explicit CXXFLAGS: "./configure CXXFLAGS="-O2 -g". Being explicit there means clobbering the warnings and hardening that would've been added otherwise.

tl;dr: Concept ACK, but let's not go around flipping every switch we can find indiscriminately. Will review.

Edit: Showing a diff of configure --help as part of a depends PR couldn't possibly be a bad thing! I just think it's a bit overkill as a requirement.

fanquake force-pushed on Jul 24, 2019

fanquake commented at 6:19 AM on July 24, 2019: member

tl;dr: Concept ACK, but let's not go around flipping every switch we can find indiscriminately. Will review.

Fair call. I've made some of the changes suggested by Carl above, and left some comments inline. I'll leave this until you've done a first pass review.

Showing a diff of configure --help as part of a depends PR couldn't possibly be a bad thing!

I think configure diffs are a nice idea, and at least they can be automated.

laanwj referenced this in commit a54a12046e on Jul 25, 2019

konez2k referenced this in commit 5e9dd64953 on Jul 27, 2019

fanquake force-pushed on Jul 31, 2019

in depends/packages/xproto.mk:8 in 173206c8b9 outdated

   4 | @@ -5,7 +5,7 @@ $(package)_file_name=$(package)-$($(package)_version).tar.bz2
   5 |  $(package)_sha256_hash=636162c1759805a5a0114a369dffdeccb8af8c859ef6e1445f26a4e6e046514f
   6 |  
   7 |  define $(package)_set_vars
   8 | -$(package)_config_opts=--disable-shared
   9 | +$(package)_config_opts=--without-fop --without-xmlto --without-xsltproc --disable-specs

theuni commented at 8:51 PM on July 31, 2019:

Doesn't this install generated spec files? If so, does libXau not need them?

theuni commented at 9:07 PM on July 31, 2019: member

Left a few things to check.

The --with-militant is the type of switch-flipping that makes me really nervous. Can we make sure that binary results don't differ before/after these changes? IMO Anything that changes the bitcoind binary should be reviewed separately.

fanquake force-pushed on Aug 1, 2019

fanquake commented at 3:10 AM on August 1, 2019: member

I've addressed two of @theuni's comments (libxcb and qrencode).

For the remaining two, I'm adding some changes to our build-for-compare.py script so that you can pass a depends prefix through to configure. That should make it easier to do binary comparisons of depends changes. I'll follow up with some comparisons of the --with-militant (zmq) changes shortly.

Doesn't this install generated spec files? If so, does libXau not need them?

Still need to figure out and address this.

laanwj referenced this in commit 1cd167e573 on Aug 1, 2019

laanwj commented at 1:00 PM on August 1, 2019: member

Concept ACK

fanquake force-pushed on Aug 2, 2019

fanquake commented at 1:27 AM on August 2, 2019: member

I've opened 1 more PR to the maintainer-tools repo that ensures we get deterministic bitcoin-qt builds.

Disabling this (the current default) sounds like a safety downgrade...

I agree, and have now removed that change.

Passing --with-militant to zmqs ./configure (the default) defines ZMQ_ACT_MILITANT. Looking at the zeromq source, the usages of ZMQ_ACT_MILITANT are all in options.cpp. I've included some of the usage below:

static int sockopt_invalid ()
{
#if defined(ZMQ_ACT_MILITANT)
    zmq_assert (false);
#endif
    errno = EINVAL;
    return -1;
}

        default:
#if defined(ZMQ_ACT_MILITANT)
            //  There are valid scenarios for probing with unknown socket option
            //  values, e.g. to check if security is enabled or not. This will not
            //  provoke a militant assert. However, passing bad values to a valid
            //  socket option will, if ZMQ_ACT_MILITANT is defined.
            malformed = false;
#endif
            break;
    }

#if defined(ZMQ_ACT_MILITANT)
    //  There is no valid use case for passing an error back to the application
    //  when it sent malformed arguments to a socket option. Use ./configure
    //  --with-militant to enable this checking.
    if (malformed)
        zmq_assert (false);
#endif
    errno = EINVAL;
    return -1;
}

FWIW the diff of the bitcoinds from a comparison build, one which had --without-militant passed to zeromq, is very large.

laanwj referenced this in commit b49e7796c2 on Aug 14, 2019

DrahtBot added the label Needs rebase on Aug 14, 2019

DrahtBot commented at 12:09 PM on August 14, 2019: member

Needs rebase

depends: libXau: configure flags cleanup e439388b35

depends: libxcb: configure flags cleanup e656d95ec7

depends: fontconfig: configure flags cleanup 86beb8cdc4

depends: qrencode: configure flags cleanup

This also fixes passing --without-tools

6a8ada3a4f

depends: xproto: configure flags cleanup 0072237b9e

depends: zeromq: disable draft classes and methods c295cba5a2

fanquake force-pushed on Aug 14, 2019

fanquake removed the label Needs rebase on Aug 14, 2019

fanquake commented at 12:36 PM on August 14, 2019: member

Rebased for #16533.

MarcoFalke deleted a comment on Aug 14, 2019

MarcoFalke added the label Needs gitian build on Aug 14, 2019

dongcarl commented at 7:00 PM on August 14, 2019: member

@fanquake So the patchset as it stands right now does not change add the --with-militant flag, and thus the build-for-compare.py results are identical? I think this is merge-able, and we should deal with --with-militant in another PR/issue.

fanquake commented at 9:57 AM on August 15, 2019: member

@dongcarl Yes I'm seeing identical results.

I've just done another build-for-compare using the following (inside a Buster Docker container):

git fetch upstream pull/16370/head:16370 && git checkout 16370

# build depends for c295cba5a2f934e51a7c8610ab4c58b8e9d56619
cd depends
RAPIDCHECK=1 make -j5
cd ..

# build for compare into /tmp/c295cba5a2f934e51a7c8610ab4c58b8e9d56619
../bitcoin-maintainer-tools/build-for-compare.py c295cba5a2f934e51a7c8610ab4c58b8e9d56619  --prefix=/bitcoin/depends/x86_64-pc-linux-gnu --executables=src/bitcoind,src/qt/bitcoin-qt --parallelism=5 --tgtdir=/tmp/c295cba5a2f934e51a7c8610ab4c58b8e9d56619

# jump back to last commit in the branch before the changes in this PR
git checkout 24f29790cd7e1001c0f923130ea24b18d378bbb5

# re build depends
cd depends
RAPIDCHECK=1 make -j5
cd ..

# build for compare into /tmp/24f29790cd7e1001c0f923130ea24b18d378bbb5
../bitcoin-maintainer-tools/build-for-compare.py 24f29790cd7e1001c0f923130ea24b18d378bbb5  --prefix=/bitcoin/depends/x86_64-pc-linux-gnu --executables=src/bitcoind,src/qt/bitcoin-qt --parallelism=5 --tgtdir=/tmp/24f29790cd7e1001c0f923130ea24b18d378bbb5

# compare
shasum /tmp/24f29790cd7e1001c0f923130ea24b18d378bbb5/*.stripped /tmp/c295cba5a2f934e51a7c8610ab4c58b8e9d56619/*.stripped
a97c2d0626fa5b115b32c37604703aacc577845a  /tmp/24f29790cd7e1001c0f923130ea24b18d378bbb5/bitcoin-qt.24f29790cd7e1001c0f923130ea24b18d378bbb5.stripped
7c78eb1760cf901f6dad7299ef6a270d73f3d52a  /tmp/24f29790cd7e1001c0f923130ea24b18d378bbb5/bitcoind.24f29790cd7e1001c0f923130ea24b18d378bbb5.stripped
a97c2d0626fa5b115b32c37604703aacc577845a  /tmp/c295cba5a2f934e51a7c8610ab4c58b8e9d56619/bitcoin-qt.c295cba5a2f934e51a7c8610ab4c58b8e9d56619.stripped
7c78eb1760cf901f6dad7299ef6a270d73f3d52a  /tmp/c295cba5a2f934e51a7c8610ab4c58b8e9d56619/bitcoind.c295cba5a2f934e51a7c8610ab4c58b8e9d56619.stripped

diffoscope 24f29790cd7e1001c0f923130ea24b18d378bbb5/bitcoin-qt.24f29790cd7e1001c0f923130ea24b18d378bbb5.stripped c295cba5a2f934e51a7c8610ab4c58b8e9d56619/bitcoin-qt.c295cba5a2f934e51a7c8610ab4c58b8e9d56619.stripped

DrahtBot commented at 6:29 PM on August 16, 2019: member

Gitian builds for commit a7aa809027633556dd3280c6e29ca98eb3235a3d (master):

d6c6331d5bb8779b29ede40450e09c93... bitcoin-0.18.99-aarch64-linux-gnu-debug.tar.gz
9d0aeb3a183854db1894c148684a2967... bitcoin-0.18.99-aarch64-linux-gnu.tar.gz
00eca38f0593c39438c988339b2269ea... bitcoin-0.18.99-arm-linux-gnueabihf-debug.tar.gz
9090d968c576f7f1475774584ae90282... bitcoin-0.18.99-arm-linux-gnueabihf.tar.gz
ca12783dfbfccfbb651092c73a2ba6e3... bitcoin-0.18.99-i686-pc-linux-gnu-debug.tar.gz
02a8d0e055409dc70b02bad2d9205aeb... bitcoin-0.18.99-i686-pc-linux-gnu.tar.gz
46055916f6a3f9d4af33692913b104bc... bitcoin-0.18.99-osx-unsigned.dmg
dfd33e16ddc4863ae7f4990f7829d5d5... bitcoin-0.18.99-osx64.tar.gz
98eff308a265524446bd150b39f4964f... bitcoin-0.18.99-riscv64-linux-gnu-debug.tar.gz
6c43910bf13beaab04b26ddf30d1b484... bitcoin-0.18.99-riscv64-linux-gnu.tar.gz
e13026deb46aebbe33292943985141c3... bitcoin-0.18.99-win64-debug.zip
5194fe7fcbfd7f58cd22365a6fd2f3c9... bitcoin-0.18.99-win64-setup-unsigned.exe
f27d4ffd251e04711eaef6de613b7112... bitcoin-0.18.99-win64.zip
103c1c5781ae61e05e206b43720e0e7d... bitcoin-0.18.99-x86_64-linux-gnu-debug.tar.gz
9202666f7ae4ec6db9f019a1758df34b... bitcoin-0.18.99-x86_64-linux-gnu.tar.gz
cc60c71bbd72244dc34658a615853825... bitcoin-0.18.99.tar.gz
787a2339f4559459644c60b8c1d6faad... bitcoin-core-linux-0.19-res.yml
556de79cee6bc37d1eef47b6e28cf58a... bitcoin-core-osx-0.19-res.yml
80467961539cba0bf375e640e3f68d4a... bitcoin-core-win-0.19-res.yml
3f80f939721b6730a43f44d19ce90091... linux-build.log
bf6fef8be1c084d045ab1ec3ed25c1dc... osx-build.log
0f57059251ce5e72368cf821a7548b76... win-build.log

Gitian builds for commit f7d153905d3bf322a5dc900372b51b89438fdf18 (master and this pull):

6cea7fe99045626078f62bf11854cec7... bitcoin-0.18.99-aarch64-linux-gnu-debug.tar.gz
9f54a37229cc2076916f32085bb736b3... bitcoin-0.18.99-aarch64-linux-gnu.tar.gz
4e96e45bb6777bfb151fa25a6c3cdaaa... bitcoin-0.18.99-arm-linux-gnueabihf-debug.tar.gz
8a29ea1403c6a23595f85c001c7481d3... bitcoin-0.18.99-arm-linux-gnueabihf.tar.gz
fc7723a1ef00287cae13f4988444fcea... bitcoin-0.18.99-i686-pc-linux-gnu-debug.tar.gz
baff90a807e68f03e5371692868088af... bitcoin-0.18.99-i686-pc-linux-gnu.tar.gz
1d39668dca2198926a2cadf2682bbdac... bitcoin-0.18.99-osx-unsigned.dmg
d5ffda55378ea422f1d19f179c4ada7c... bitcoin-0.18.99-osx64.tar.gz
08c8bdaf95df503c65410c6543ca4562... bitcoin-0.18.99-riscv64-linux-gnu-debug.tar.gz
a3d0957dcbac414600d67dc071caca25... bitcoin-0.18.99-riscv64-linux-gnu.tar.gz
d0ff56c3b57096a3e71ea92c78b74963... bitcoin-0.18.99-win64-debug.zip
0a08bd97d64bd05ac7dd2a95d93597af... bitcoin-0.18.99-win64-setup-unsigned.exe
653a68f9f6077ff1fc35bb7cb42151eb... bitcoin-0.18.99-win64.zip
44101afbdaf1cd39ae2dea34841ff696... bitcoin-0.18.99-x86_64-linux-gnu-debug.tar.gz
fb3aa92b7fdfddfa943a2e3be8e9969a... bitcoin-0.18.99-x86_64-linux-gnu.tar.gz
d61cecf3194ad090066e11904fa5aa7b... bitcoin-0.18.99.tar.gz
017297c5b97f61e8be78193982069a02... bitcoin-core-linux-0.19-res.yml
f3e73d0a4ca48d9a32d5d91300161489... bitcoin-core-linux-0.19-res.yml.diff
5bdbc683fc31fbd6c66aa3dda6a5abac... bitcoin-core-osx-0.19-res.yml
ff286f1bf54ffd75e716e0e5396c50de... bitcoin-core-osx-0.19-res.yml.diff
99d99deca3a4a9eeeeff6019682d4283... bitcoin-core-win-0.19-res.yml
b7bea7e92d20018114cc86a6ba3365f1... bitcoin-core-win-0.19-res.yml.diff
71e12010a14dbebd9e7d9fe09381bef3... linux-build.log
6a7ff415ffaddf60950b10ebaff41e35... linux-build.log.diff
5bcb0af35d2a4b3580d6e0c42d4858f5... osx-build.log
1b1f4dd88b6354e8ef328019e0171012... osx-build.log.diff
7d10747e25514f4ec6eab47694a84618... win-build.log
103a88171f47a42f06b5162504331018... win-build.log.diff

DrahtBot removed the label Needs gitian build on Aug 16, 2019

dongcarl commented at 5:36 PM on August 20, 2019: member

ACK c295cba5a2f934e51a7c8610ab4c58b8e9d56619

Sjors commented at 7:07 PM on August 20, 2019: member

c295cba still builds for me on macOS.

meshcollider commented at 2:44 AM on August 24, 2019: contributor

Looks good to me, since dongcarl and theuni have both reviewed and the gitian build looks fine

meshcollider referenced this in commit 3ca514ddb7 on Aug 24, 2019

meshcollider merged this on Aug 24, 2019

meshcollider closed this on Aug 24, 2019

fanquake deleted the branch on Aug 24, 2019

sidhujag referenced this in commit d89bdedbc5 on Aug 25, 2019

deadalnix referenced this in commit 0823821a44 on Apr 2, 2020

zkbot referenced this in commit e3d5ddbef4 on Oct 8, 2020

zkbot referenced this in commit 6e4090d840 on Oct 8, 2020

PastaPastaPasta referenced this in commit a42ac5713a on Jun 27, 2021

PastaPastaPasta referenced this in commit acd870a77c on Jun 27, 2021

PastaPastaPasta referenced this in commit 5694044819 on Jun 28, 2021

PastaPastaPasta referenced this in commit 650dc04a4c on Jun 28, 2021

PastaPastaPasta referenced this in commit b79dcdcc37 on Jun 29, 2021

PastaPastaPasta referenced this in commit 4168b467d5 on Jun 29, 2021

PastaPastaPasta referenced this in commit 0fb196d0c6 on Jul 1, 2021

PastaPastaPasta referenced this in commit 76d59a737c on Jul 1, 2021

PastaPastaPasta referenced this in commit 6d9db17449 on Jul 1, 2021

PastaPastaPasta referenced this in commit 565a0c5748 on Jul 1, 2021

PastaPastaPasta referenced this in commit d062deb53d on Jul 12, 2021

PastaPastaPasta referenced this in commit 8a044ebc0e on Jul 12, 2021

PastaPastaPasta referenced this in commit 7fcb8f53ed on Jul 13, 2021

ftrader referenced this in commit 1612a624c9 on Aug 13, 2021

PastaPastaPasta referenced this in commit 0af66e6574 on Sep 11, 2021

PastaPastaPasta referenced this in commit 1b5d29bb9c on Sep 11, 2021

Munkybooty referenced this in commit 97632ca890 on Nov 9, 2021

Munkybooty referenced this in commit ccd976d600 on Nov 16, 2021

Munkybooty referenced this in commit bf59b2ec92 on Nov 18, 2021

Munkybooty referenced this in commit dcca9d8eb1 on Nov 24, 2021

Munkybooty referenced this in commit 3e40a99573 on Nov 30, 2021

Munkybooty referenced this in commit a9727f8c24 on Dec 15, 2021

DrahtBot locked this on Dec 16, 2021