build: ignore macOS make deploy artefacts & add them to clean-local #16371

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:ignore_osx_volname changing 2 files +5 −0
  1. fanquake commented at 4:30 AM on July 11, 2019: member

    No description provided.

  2. fanquake added the label Build system on Jul 11, 2019
  3. laanwj commented at 8:25 AM on July 11, 2019: member

    Concept ACK, the file is produced in the makefile (though, not by any umbrella rule), so it should be ignored

    also code review ACK 290c5c6ae80668a1e8090be74f653b0f24704d97

  4. MarcoFalke renamed this:
    trivial: build: ignore osx_volname & add it to clean-local
    build: ignore osx_volname & add it to clean-local
    on Jul 11, 2019
  5. fanquake force-pushed on Jul 16, 2019
  6. fanquake renamed this:
    build: ignore osx_volname & add it to clean-local
    build: ignore macOS make deploy artefacts & add them to clean-local
    on Jul 16, 2019
  7. hebasto commented at 6:55 AM on July 19, 2019: member

    Concept ACK

  8. practicalswift commented at 11:13 AM on July 22, 2019: contributor

    utACK 57fb62ec23c8d78a761577b87dc38090afcd13f3

  9. in .gitignore:137 in 57fb62ec23 outdated 
     127 | @@ -128,3 +128,8 @@ db4/
 128 |  
 129 |  # clang-check
 130 |  *.plist
 131 | +
 132 | +osx_volname
 133 | +dist/
    jonasschnelli commented at 12:44 PM on July 22, 2019:

    Do you have any other files than the already ignored Bitcoin-Qt.app in here?

  10. jonasschnelli commented at 12:45 PM on July 22, 2019: contributor

    ACK 57fb62ec23c8d78a761577b87dc38090afcd13f3

  11. hebasto commented at 6:32 PM on July 22, 2019: member

    @fanquake On master testing make deploy on High Sierra 10.13.6. Cannot observe mentioned artefacts. Which macOS version do you use?

  12. fanquake commented at 1:00 AM on July 23, 2019: member

    @hebasto The artefacts occur when building for a macOS HOST on a Linux machine.

  13. in .gitignore:134 in 57fb62ec23 outdated 
     127 | @@ -128,3 +128,8 @@ db4/
 128 |  
 129 |  # clang-check
 130 |  *.plist
 131 | +
 132 | +osx_volname
 133 | +dist/
 134 | +dpi36.background.tiff
    hebasto commented at 5:14 PM on August 13, 2019:

    Could be just *.background.tiff?

    fanquake commented at 12:24 AM on August 14, 2019:

    Done.

  14. hebasto commented at 5:47 PM on August 13, 2019: member

    Tested master branch on Linux Mint 19.2:

    cd depends
make HOST=x86_64-apple-darwin14 SDK_PATH=`pwd`/SDKs
cd ..
./configure --prefix=`pwd`/depends/x86_64-apple-darwin14
make deploy

    Artefacts:

    • dist/ folder -- observed
    • dpi36.background.tiff -- observed
    • dpi72.background.tiff -- observed
    • osx_volname -- not observed
  15. build: ignore macOS make deploy artefacts & add them to clean-local c84ff23c6d
  16. fanquake force-pushed on Aug 14, 2019
  17. fanquake commented at 12:20 AM on August 14, 2019: member

    @hebasto Thanks for testing. I've fixed your nit.

    osx_volname -- not observed

    You should see it if you run make osx_volname

  18. hebasto commented at 6:07 PM on August 14, 2019: member

    ACK c84ff23c6daade5145d960e1ac26596ddede2da1, tested on Linux Mint 19.2:

    • make with targets osx_volname, deploydir and deploy creates the mentioned artefacts
    • make clean removes them
  19. MarcoFalke added the label Needs gitian build on Aug 14, 2019
  20. DrahtBot commented at 7:05 AM on August 16, 2019: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit a7aa809027633556dd3280c6e29ca98eb3235a3d (master):

    Gitian builds for commit 5b4a86682729d5c8f82fafd4c6287d306653bfde (master and this pull):

  21. DrahtBot removed the label Needs gitian build on Aug 16, 2019
  22. dongcarl commented at 11:40 PM on August 20, 2019: member

    ACK c84ff23c6daade5145d960e1ac26596ddede2da1

  23. fanquake referenced this in commit 8ee572f094 on Aug 21, 2019
  24. fanquake merged this on Aug 21, 2019
  25. fanquake closed this on Aug 21, 2019
  26. fanquake deleted the branch on Aug 21, 2019
  27. sidhujag referenced this in commit 0cc70ff1ab on Aug 22, 2019
  28. kittywhiskers referenced this in commit 3fde51dd12 on Nov 3, 2021
  29. kittywhiskers referenced this in commit 86f4b154a0 on Nov 4, 2021
  30. kittywhiskers referenced this in commit a9997c778e on Nov 11, 2021
  31. pravblockc referenced this in commit b2e966db51 on Nov 18, 2021
  32. MarcoFalke locked this on Dec 16, 2021
Contributors
fanquakelaanwjhebastopracticalswiftjonasschnelliDrahtBotdongcarl
Labels
Build system
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-26 06:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me