depends: Bump QT to LTS release 5.9.8 #16413

pull THETCR wants to merge 1 commits into bitcoin:master from THETCR:qt-lts changing 1 files +4 −4
  1. THETCR commented at 12:23 PM on July 18, 2019: contributor

    This update is only a minor version but in contrary to 5.9.7 it's a LTS release. It doesn't add any new functionality to Qt but fixes multiple security issues and bugs. Including some race conditions and annoying bugs on macOS.

  2. depends: Bump QT to LTS release 5.9.8 0c6054fc9f
  3. fanquake added the label Build system on Jul 18, 2019
  4. fanquake added the label Needs gitian build on Jul 18, 2019
  5. MarcoFalke commented at 12:59 PM on July 18, 2019: member

    Including some race conditions and annoying bugs on macOS

    I think having some references would help testing.

  6. THETCR commented at 1:39 PM on July 18, 2019: contributor

    I don't know if QTBUG-69955 is noticeable in the bitcoin-qt, but it is/was in other projects. Nonetheless, having a LTS release is way more preferable if it's only a minor update.

  7. DrahtBot commented at 3:41 PM on July 18, 2019: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    No conflicts as of last run.

  8. hebasto commented at 6:31 AM on July 19, 2019: member

    Ref: fixed in 5.9.8

  9. fanquake commented at 3:31 AM on July 29, 2019: member

    I don't know if QTBUG-69955 is noticeable in the bitcoin-qt, but it is/was in other projects.

    It looks like we should already have that fix, as it was included in the 5.9.7 release?

    Looking at the 5.9.8 fixes, I'm not sure if there's anything in there that affects the parts of Qt we use. Could you outline in the PR description which bug fixes we want?

    In any case, the 5.9.9 LTS release is slated for Q4 of this year (likely before our 0.19.0 release), so if we haven't updated to the 5.12 LTS before then, we could update Qt to 5.9.9 at that point if there was a pressing reason too.

  10. DrahtBot commented at 3:06 PM on July 29, 2019: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit febf3a856bcfb8fef2cb4ddcb8d1e0cab8a22580 (master):

    Gitian builds for commit 0454597984c96854fa7d25797e4181d17cf11b61 (master and this pull):

  11. DrahtBot removed the label Needs gitian build on Jul 29, 2019
  12. laanwj added this to the milestone 0.19.0 on Jul 30, 2019
  13. laanwj commented at 5:54 AM on July 30, 2019: member

    Can anyone with MacOSX please test if this makes a difference?

    Will leave this open until short before 0.19 split-off—if there hasn't been a larger Qt bump by then, let's merge this.

  14. BlockMechanic commented at 2:13 PM on August 11, 2019: contributor

    Hi

    I'd like to suggest a bump to Qt 5.12 LTS. Previous versions make multiple issue and require a lot of patches to work with aarch64. The major contributing factor for my advocating going this route is Google deprecating both 32-bit apps and GCC in favour of Clang as mentioned here :- #16110 (review)

    Some patches have already been proposed/merged such as #16110 which enables bitcoind to build but not QT (android) and this :- #13696 which does enable Qt but is now obsolete due to the move to clang.

  15. fanquake commented at 1:02 AM on August 12, 2019: member

    I'd like to suggest a bump to Qt 5.12 LTS. @BlockMechanic I've suggested that here, however there are other things to consider when bumping, such as dropping compatibility with older operating systems. Qt dropped support for macOS < 10.12 in 5.12.

  16. BlockMechanic commented at 5:00 AM on August 12, 2019: contributor

    I'd like to suggest a bump to Qt 5.12 LTS.

    @BlockMechanic I've suggested that here, however there are other things to consider when bumping, such as dropping compatibility with older operating systems. Qt dropped support for macOS < 10.12 in 5.12.

    Ok thanks , I had already begun checking it out :)

  17. Sjors commented at 4:53 PM on August 13, 2019: member

    ACK 0c6054fc9fd27d8e2ef49419c07c5e8f2485e1f7. Lightly tested on macOS 10.14.6. Not really sure what difference would matter on macOS.

    Where does QT announce which versions are LTS? I'm fine with holding off merging, and instead bumping to whichever 5.9 version is the most recent closer to the 0.19 branch-off.

  18. hebasto commented at 5:02 PM on August 13, 2019: member

    @Sjors

    Where does QT announce which versions are LTS?

    https://blog.qt.io/

  19. laanwj commented at 12:07 PM on September 10, 2019: member

    Qt dropped support for macOS < 10.12 in 5.12.

    Okay, that's a good reason to not do that for 0.19. I'm going to go ahead and merge this. A larger bump can be done for 0.20.

  20. laanwj referenced this in commit 1985c4efda on Sep 10, 2019
  21. laanwj merged this on Sep 10, 2019
  22. laanwj closed this on Sep 10, 2019
  23. sidhujag referenced this in commit 6b23681683 on Sep 10, 2019
  24. fanquake deleted a comment on Oct 9, 2019
  25. fanquake deleted a comment on Oct 9, 2019
  26. fanquake locked this on Oct 9, 2019
Contributors
THETCRMarcoFalkeDrahtBothebastofanquakelaanwjBlockMechanicSjors
Labels
Build system

Milestone
0.19.0

Linked (view graph)
#17825 doc: Update dependencies.md
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 18:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me