doc: Update dependencies.md #17825

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20191229-update-dependencies changing 1 files +3 −3

hebasto commented at 11:24 AM on December 29, 2019: member
Updated info about:
- Qt-bundled FreeType library on Android
- Qt-bundled HarfBuzz-NG library
- Qt dependency version (5.9.7 -> 5.9.8, #16413)
doc: Update dependencies.md df97e59207
DrahtBot added the label Docs on Dec 29, 2019
promag commented at 10:46 PM on December 29, 2019: member

ACK df97e592078a33f6bf535979e05967c563de317b.
elichai commented at 10:01 AM on December 30, 2019: contributor

~ACK df97e592078a33f6bf535979e05967c563de317b~

I'm not quite sure I understand the semantics of the table. does it mean it's only bundled in QT-android or also or both? (because fontconfig also requires freetype, even on linux)
hebasto commented at 11:32 AM on December 30, 2019: member

@elichai

I'm not quite sure I understand the semantics of the table. does it mean it's only bundled in QT-android or also or both? (because fontconfig also requires freetype, even on linux)

https://github.com/bitcoin/bitcoin/blob/b931f61b9ab098ea4ea8fbe4cbf0b03c566c3f63/depends/packages/qt.mk#L33

https://github.com/bitcoin/bitcoin/blob/b931f61b9ab098ea4ea8fbe4cbf0b03c566c3f63/depends/packages/qt.mk#L131

https://github.com/bitcoin/bitcoin/blob/b931f61b9ab098ea4ea8fbe4cbf0b03c566c3f63/depends/packages/qt.mk#L159

Qt Third-Party Libraries:

To set whether Qt should use the system's versions of the libraries or to use the bundled version, pass either -system or -qt before the name of the library to configure. It is also possible to disable support for these libraries by using -no instead of -qt.

So, only on Android platform the bundled version of freetype is used. Other Linux platforms use system's freetype.
elichai commented at 11:35 AM on December 30, 2019: contributor

I know that. what I tried to ask is does this change semantically mean that this is the only place where freetype is used? if so then that's not right. if it doesn't then it's fine.

in other words. in qt freetype is only used in android. outside of qt it's used in more places in "normal" linux too. https://github.com/bitcoin/bitcoin/blob/b931f61b9ab098ea4ea8fbe4cbf0b03c566c3f63/depends/packages/packages.mk#L7 https://github.com/bitcoin/bitcoin/blob/b931f61b9ab098ea4ea8fbe4cbf0b03c566c3f63/depends/packages/fontconfig.mk#L6
hebasto commented at 11:49 AM on December 30, 2019: member
in other words. in qt freetype is only used in android. outside of qt it's used in more places in "normal" linux too.

freetype is used by Qt:
- Qt's own (bundled) freetype on Android
- system's (provided by host Linux OS) freetype on Linux (non-Android)
hebasto commented at 11:52 AM on December 30, 2019: member

... this change semantically mean that this is the only place where freetype is used?

The column name is "Bundled Qt library" ;)
fanquake commented at 6:31 PM on December 31, 2019: member

ACK df97e592078a33f6bf535979e05967c563de317b
fanquake referenced this in commit 35fff5be60 on Dec 31, 2019
fanquake merged this on Dec 31, 2019
fanquake closed this on Dec 31, 2019
hebasto deleted the branch on Dec 31, 2019
sidhujag referenced this in commit 63567806e8 on Jan 2, 2020
sidhujag referenced this in commit 87d60606ef on Nov 10, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#16413 depends: Bump QT to LTS release 5.9.8