txmempool: Remove unused default value MemPoolRemovalReason::UNKNOWN #16433

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1907-txmempoolNoUnknownDefault changing 4 files +17 −16

MarcoFalke commented at 11:43 AM on July 22, 2019: member

The remove* methods set the removal reason to UNKNOWN by default. This is nowhere used; Except in tests, where the value doesn't matter. Fix that by removing the confusing default.
txmempool: Remove unused default value MemPoolRemovalReason::UNKNOWN 0000ff0aa7
fanquake added the label Mempool on Jul 22, 2019
practicalswift commented at 11:37 PM on July 22, 2019: contributor

utACK 0000ff0aa763e3be524ac4537a41048a26529fb2
promag commented at 8:44 AM on July 23, 2019: member

ACK 0000ff0aa763e3be524ac4537a41048a26529fb2.
MarcoFalke added the label Refactoring on Jul 23, 2019
TheBlueMatt commented at 7:57 PM on July 30, 2019: member

utACK
jonasschnelli commented at 8:00 PM on July 30, 2019: contributor

utACK 0000ff0aa763e3be524ac4537a41048a26529fb2
jonasschnelli merged this on Jul 30, 2019
jonasschnelli closed this on Jul 30, 2019
jonasschnelli referenced this in commit 39763b7555 on Jul 30, 2019
MarcoFalke deleted the branch on Jul 30, 2019
deadalnix referenced this in commit f3afcb9a60 on Jun 12, 2020
vijaydasmp referenced this in commit 2caa6e0eae on Nov 15, 2021
vijaydasmp referenced this in commit 3de39b52a2 on Nov 16, 2021
vijaydasmp referenced this in commit 5b081699dc on Nov 21, 2021
vijaydasmp referenced this in commit 1aac6bf4c2 on Nov 22, 2021
vijaydasmp referenced this in commit 8256a11b39 on Dec 5, 2021
vijaydasmp referenced this in commit 8206fe4de8 on Dec 5, 2021
vijaydasmp referenced this in commit 04760d5ce3 on Dec 13, 2021
vijaydasmp referenced this in commit b702be6e89 on Dec 13, 2021
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels