These were previously disabled, but upstream changed to having benchmarks enabled by default in https://github.com/bitcoin-core/secp256k1/pull/480 and we pulled that change in as part of #15703.
build: disable building libsecp256k1 benchmarks #16573
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:disable-secp256k1-benchmarks changing 1 files +1 −1-
fanquake commented at 5:14 AM on August 9, 2019: member
-
bf72b8a555
build: disable libsecp256k1 benchmarks
These were previously disabled, but upstream changed to having benchmarks enabled by default in https://github.com/bitcoin-core/secp256k1/pull/480 and we pulled that change as part of #15703.
- fanquake added the label Build system on Aug 9, 2019
-
laanwj commented at 7:40 AM on August 9, 2019: member
ACK bf72b8a5551868433ae6fa1824915255f104b208
-
DrahtBot commented at 7:42 AM on August 9, 2019: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #14049 (Enable libsecp256k1 ecdh module, add ECDH function to CKey by jonasschnelli)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
real-or-random commented at 11:35 AM on August 9, 2019: member
ACK bf72b8a5551868433ae6fa1824915255f104b208 I only looked at the diff
bikeshedding:
--disable-benchmarkswould be more consistent with the other options given there. -
practicalswift commented at 12:20 PM on August 9, 2019: contributor
ACK bf72b8a5551868433ae6fa1824915255f104b208 -- diff looks correct
- laanwj merged this on Aug 9, 2019
- laanwj closed this on Aug 9, 2019
- laanwj referenced this in commit e47e36cb49 on Aug 9, 2019
- fanquake deleted the branch on Aug 10, 2019
- PastaPastaPasta referenced this in commit 7840adf9c2 on Jun 27, 2021
- PastaPastaPasta referenced this in commit 809e63862a on Jun 28, 2021
- PastaPastaPasta referenced this in commit 7e6f15b35d on Jun 29, 2021
- PastaPastaPasta referenced this in commit 1a0c416e2c on Jul 1, 2021
- PastaPastaPasta referenced this in commit 891006dad2 on Jul 1, 2021
- PastaPastaPasta referenced this in commit 0f9c331df2 on Jul 12, 2021
- gades referenced this in commit bb03a1294c on Apr 29, 2022
- DrahtBot locked this on Aug 16, 2022
