gui: remove unused PlatformStyle::TextColorIcon #16677

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_unused_text_coloricon changing 2 files +0 −8

fanquake commented at 6:56 AM on August 22, 2019: member

This is unused after #16612.
gui: remove unused PlatformStyle::TextColorIcon
This is unused after #16612.
bca388db0d
fanquake added the label GUI on Aug 22, 2019
fanquake added the label Refactoring on Aug 22, 2019
emilengler commented at 1:51 PM on August 22, 2019: contributor

Concept ACK bca388d

practicalswift commented at 7:09 PM on August 22, 2019: contributor

ACK bca388db0da3d40953ff65d03da62ca45a7951a6 -- diff looks correct & less cruft is better

FWIW here are some additional unused functions that you might want to investigate while you're at it:

Unused code

Unused functions that are not covered by unit tests

bitcoinconsensus_version
BlockFilter::BlockFilter(BlockFilterType, uint256 const&, std::vector<unsigned char>)
CBlock::ToString() const
CBloomFilter::reset(unsigned int)
CClientUIInterface::LoadWallet(std::unique_ptr<interfaces::Wallet>&)
PartiallySignedTransaction::IsNull() const
PSBTInput::IsNull() const
PSBTOutput::IsNull() const

Unused functions that are covered by unit tests

base_blob<160u>::SetHex(std::string const&)
base_blob<160u>::ToString() const
base_uint<256u>::base_uint(std::string const&)
base_uint<256u>::ToString() const
bitcoinconsensus_verify_script
bitcoinconsensus_verify_script_with_amount
BlockFilter::BlockFilter(BlockFilterType, CBlock const&, CBlockUndo const&)
BlockFilter::ComputeHeader(uint256 const&) const
CBloomFilter::CBloomFilter(unsigned int, double, unsigned int, unsigned char)
CBloomFilter::insert(uint256 const&)
CKey::Negate()
DecodeBase58(std::string const&, std::vector<unsigned char>&)
GCSFilter::MatchAny(std::unordered_set<std::vector<unsigned char>, ByteVectorHash, std::equal_to<std::vector<unsigned char>>, std::allocator<std::vector<unsigned char>>> const&) const
GCSFilter::Match(std::vector<unsigned char> const&) const
SignSignature(SigningProvider const&, CTransaction const&, CMutableTransaction&, unsigned int, int)

hebasto commented at 7:37 PM on August 22, 2019: member

Concept ACK
hebasto approved
hebasto commented at 7:08 AM on August 23, 2019: member

ACK bca388db0da3d40953ff65d03da62ca45a7951a6, I have reviewed the code and it looks OK, I agree it can be merge.
jonasschnelli approved
jonasschnelli commented at 9:12 AM on August 23, 2019: contributor

utACK bca388db0da3d40953ff65d03da62ca45a7951a6
jonasschnelli referenced this in commit d72758c3f6 on Aug 23, 2019
jonasschnelli merged this on Aug 23, 2019
jonasschnelli closed this on Aug 23, 2019
sidhujag referenced this in commit 4488a1b27e on Aug 23, 2019
luke-jr commented at 7:53 PM on August 23, 2019: member

This seems premature since someone volunteered to re-add menu icons...
fanquake deleted the branch on Aug 24, 2019
Fabcien referenced this in commit 273af50e2a on Dec 24, 2020
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#16612 qt: Remove menu icons