qt: Replace deprecated QSignalMapper by lambda expressions #16706

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:20190824-obsolete-qsignalmapper changing 3 files +7 −25
  1. hebasto commented at 7:49 AM on August 24, 2019: member

    The QSignalMapper class has been deprecated since Qt 5.10.

    This PR replaces it by lambdas and does not change behavior.

  2. qt: Remove QSignalMapper from RPCConsole
    The QSignalMapper class is obsolete since Qt 5.10.
    9e0c1d676c
  3. fanquake added the label GUI on Aug 24, 2019
  4. fanquake added the label Refactoring on Aug 24, 2019
  5. DrahtBot commented at 7:55 AM on August 24, 2019: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    No conflicts as of last run.

  6. fanquake commented at 7:57 AM on August 24, 2019: member

    QSignalMapper has actually been un-deprecated, see QSignalMapper deprecation and Un-deprecate QSignalMapper.

    However Concept ACK assuming there's no change in behaviour and the new code is still compatible with Qt 5.5.1.

  7. hebasto commented at 8:10 AM on August 24, 2019: member

    @fanquake

    QSignalMapper has actually been un-deprecated, see QSignalMapper deprecation and Un-deprecate QSignalMapper.

    I didn't know about that. Thank you.

    From Un-deprecate QSignalMapper:

    ... Note that in most cases you can use lambdas for passing custom parameters to slots. This is less costly and will simplify the code.

    FWIW, this PR is a part of my work on warnings raised during compiling on Bionic against Qt 5.13.

  8. practicalswift commented at 8:33 AM on August 24, 2019: contributor

    Concept ACK -- more readable and less code

  9. promag commented at 12:31 AM on August 25, 2019: member

    Concept ACK.

    Are the style changes really necessary? I'd prefer just dropping QSignalMapper.

  10. qt: Remove QSignalMapper from TransactionView
    The QSignalMapper class is obsolete since Qt 5.10.
    0912134039
  11. hebasto force-pushed on Aug 25, 2019
  12. hebasto commented at 6:14 AM on August 25, 2019: member

    @promag

    Are the style changes really necessary? I'd prefer just dropping QSignalMapper.

    Done.

  13. jonasschnelli commented at 6:57 AM on August 26, 2019: contributor

    Concept ACK

  14. jonasschnelli added the label Needs gitian build on Aug 26, 2019
  15. DrahtBot commented at 1:14 AM on August 27, 2019: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit db67101c748c208cced8e9b76a66d57cd48fbf6e (master):

    Gitian builds for commit e05543dbcf87fb9c057d9c652835d85c25a2cb3e (master and this pull):

  16. DrahtBot removed the label Needs gitian build on Aug 27, 2019
  17. jonasschnelli approved
  18. jonasschnelli commented at 7:04 AM on August 27, 2019: contributor

    utACK 091213403922e970b38cc3a98c11074e02ddba14

  19. laanwj referenced this in commit 75142ece6b on Aug 29, 2019
  20. laanwj merged this on Aug 29, 2019
  21. laanwj closed this on Aug 29, 2019
  22. hebasto deleted the branch on Aug 29, 2019
  23. Sjors commented at 5:10 PM on August 29, 2019: member

    Post merge ACK. This totally gets rid of the flood of warnings on macOs with QT 5.13 from homebrew. It's also shorter and more readable. Tested that external explorer links still work, as well as banning peers.

    Building with depends (QT 5.9.7) also works, though this still throws trillions of (unrelated) warnings.

  24. sidhujag referenced this in commit 5a4284acad on Aug 29, 2019
  25. jasonbcox referenced this in commit 01a4608fa8 on Oct 12, 2020
  26. barton2526 referenced this in commit e059c57eb9 on Jun 24, 2021
  27. kittywhiskers referenced this in commit 39dbc8fc60 on Nov 3, 2021
  28. kittywhiskers referenced this in commit d0d8dff22f on Nov 4, 2021
  29. kittywhiskers referenced this in commit 52b972a3a4 on Nov 11, 2021
  30. pravblockc referenced this in commit ed3d2056d3 on Nov 18, 2021
  31. DrahtBot locked this on Dec 16, 2021
Contributors
hebastoDrahtBotfanquakepracticalswiftpromagjonasschnelliSjors
Labels
GUIRefactoring
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me