doc: Update labels in CONTRIBUTING.md #16723

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20190825-build-prefix changing 1 files +17 −16

hebasto commented at 5:06 PM on August 25, 2019: member
This PR:
- adds build label
- makes labels lowercase (in accordance to current customs in this repo); also a lowercase label improves readability of PR title itself, e.g.,
```
doc: Update labels in CONTRIBUTING.md
```
reads better than
```
Doc: Update labels in CONTRIBUTING.md
```
- improves label names readability
- splits long labels (as suggested by jonatack)
DrahtBot added the label Docs on Aug 25, 2019
emilengler commented at 7:21 PM on August 25, 2019: contributor

Concept ACK b813460

in CONTRIBUTING.md:90 in b813460acd outdated

  97 | +  - `log` for changes to log messages
  98 | +  - `mining` for changes to the mining code
  99 | +  - `net` or `p2p` for changes to the peer-to-peer network code
 100 | +  - `refactor` for structural changes that do not change behavior
 101 | +  - `rpc`, `rest` or `zmq` for changes to the RPC, REST or ZMQ APIs
 102 | +  - `scripts and tools` for changes to the scripts and tools

emilengler commented at 7:23 PM on August 25, 2019:

Too long, commit messages are limited to 50 bytes

jonatack commented at 10:03 PM on August 25, 2019:

I'd propose script here, and "util or lib for changes to the utils or libraries" below.

hebasto commented at 8:52 AM on August 26, 2019:

Fixed.

hebasto commented at 8:52 AM on August 26, 2019:

Done.

in CONTRIBUTING.md:92 in b813460acd outdated

  99 | +  - `net` or `p2p` for changes to the peer-to-peer network code
 100 | +  - `refactor` for structural changes that do not change behavior
 101 | +  - `rpc`, `rest` or `zmq` for changes to the RPC, REST or ZMQ APIs
 102 | +  - `scripts and tools` for changes to the scripts and tools
 103 | +  - `test` for changes to the bitcoin unit tests or QA tests
 104 | +  - `utils and libraries` for changes to the utils and libraries

emilengler commented at 7:23 PM on August 25, 2019:

Same ^^

hebasto commented at 8:52 AM on August 26, 2019:

Fixed.

practicalswift commented at 8:24 PM on August 25, 2019: contributor

ACK b813460acde7acfa0594c5bb2cf86cf56be98dd4
jonatack commented at 10:04 PM on August 25, 2019: member

ACK modulo proposal below.

doc: Update labels in CONTRIBUTING.md

Add `build' label.
Make labels lowercase.
Split long labels.

a64dbeffe4

hebasto force-pushed on Aug 26, 2019
hebasto commented at 8:51 AM on August 26, 2019: member

All comments have been addressed.
practicalswift commented at 9:20 AM on August 26, 2019: contributor

ACK a64dbeffe486b2cd247ba160ebce1c0c1c7b9e72
fanquake approved
fanquake commented at 12:45 AM on August 27, 2019: member

ACK a64dbeffe486b2cd247ba160ebce1c0c1c7b9e72
fanquake referenced this in commit 215eec3bb5 on Aug 27, 2019
fanquake merged this on Aug 27, 2019
fanquake closed this on Aug 27, 2019
sidhujag referenced this in commit 8085047ffe on Aug 27, 2019
hebasto deleted the branch on Aug 29, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels