build: AppVeyor MSVC sync.obj linker warning #16736

issue hebasto opened this issue on August 27, 2019

hebasto commented at 6:27 PM on August 27, 2019: member

E.g., https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/26966329

...
Build succeeded.
       "C:\projects\bitcoin\build_msvc\bitcoin.sln" (default target) (1) ->
       "C:\projects\bitcoin\build_msvc\testconsensus\testconsensus.vcxproj" (default target) (5) ->
       "C:\projects\bitcoin\build_msvc\libbitcoin_util\libbitcoin_util.vcxproj" (default target) (6) ->
       (Lib target) -> 
         sync.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\projects\bitcoin\build_msvc\libbitcoin_util\libbitcoin_util.vcxproj]
    1 Warning(s)
    0 Error(s)
Time Elapsed 00:23:26.65
...

fanquake added the label Windows on Aug 28, 2019
fanquake commented at 1:16 AM on August 28, 2019: member

cc @sipsorcery
hebasto commented at 12:46 PM on August 28, 2019: member

The same warning was mentioned by @NicolasDorier as well.
sipsorcery commented at 8:08 PM on August 28, 2019: member

The linker warning occurs because the sync.cpp class in libbitcoin_util only has any code to compile if DEBUG_LOCKORDER is set which it isn't for the msvc build

The warning is innocuous but to save other maintainers worrying about in the future I've removed it in #16746.
MarcoFalke commented at 8:17 PM on August 28, 2019: member

Closing, because warning can be ignored
MarcoFalke closed this on Aug 28, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels