test: Add notes on how to generate data/wallets/high_minversion #16845

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1909-docTestGenWalletDataHighMinVersion changing 1 files +8 −0

MarcoFalke commented at 1:38 PM on September 10, 2019: member

I forgot to do this in #16796
fanquake added the label Tests on Sep 10, 2019
in test/functional/data/wallets/high_minversion/GENERATE.md:2 in fabe4304f4 outdated
```
   0 | @@ -0,0 +1,8 @@
   1 | +The wallet has been created by starting Bitcoin Core with the options
   2 | +`-regtest -datadir=/tmp -walletdir=$(pwd)/test/functional/data/wallets/`.
```
promag commented at 9:24 AM on September 15, 2019:

nit, could avoid loading existing wallets by adding -nowallet here.

MarcoFalke commented at 1:35 PM on September 16, 2019:

TIL

Done
promag commented at 9:26 AM on September 15, 2019: member

Code review ACK, instructions LGTM.
fanquake added the label Docs on Sep 15, 2019
fanquake requested review from ryanofsky on Sep 16, 2019
fanquake approved
fanquake commented at 8:19 AM on September 16, 2019: member

ACK fabe4304f484f6da7e7ac3d28921d1ceb7ac93d6
test: Add notes on how to generate data/wallets/high_minversion 2222c96dee
MarcoFalke force-pushed on Sep 16, 2019
ryanofsky approved
ryanofsky commented at 4:02 PM on September 16, 2019: member

ACK 2222c96deec0f636dee6e49efb745f29b06a40a5
MarcoFalke referenced this in commit 796b713633 on Sep 16, 2019
MarcoFalke merged this on Sep 16, 2019
MarcoFalke closed this on Sep 16, 2019
MarcoFalke deleted the branch on Sep 16, 2019
sidhujag referenced this in commit b58c25bd3b on Sep 16, 2019
jasonbcox referenced this in commit 51fcead186 on Oct 21, 2020
PastaPastaPasta referenced this in commit d93549e98d on Jun 27, 2021
PastaPastaPasta referenced this in commit f378f8fedf on Jun 28, 2021
PastaPastaPasta referenced this in commit e14a37280e on Jun 29, 2021
PastaPastaPasta referenced this in commit 0ce0726e9e on Jul 1, 2021
PastaPastaPasta referenced this in commit 67eb67a409 on Jul 1, 2021
PastaPastaPasta referenced this in commit d6c9235bec on Jul 12, 2021
PastaPastaPasta referenced this in commit 008ecf5394 on Sep 11, 2021
PastaPastaPasta referenced this in commit 939f65c2f8 on Sep 11, 2021
PastaPastaPasta referenced this in commit 8c646b7211 on Sep 12, 2021
PastaPastaPasta referenced this in commit 1baebcf326 on Sep 12, 2021
PastaPastaPasta referenced this in commit aaab554030 on Sep 12, 2021
PastaPastaPasta referenced this in commit a3cae5c165 on Sep 14, 2021
PastaPastaPasta referenced this in commit 5506e7d268 on Sep 14, 2021
Munkybooty referenced this in commit b82843d3b7 on Dec 7, 2021
Munkybooty referenced this in commit 75f39dd362 on Dec 15, 2021
Munkybooty referenced this in commit b35438a8a9 on Dec 15, 2021
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#16796 wallet: Fix segfault in CreateWalletFromFile