build: remove redundant sed patching #16879

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:messy_depends changing 1 files +0 −2
  1. fanquake commented at 6:53 AM on September 16, 2019: member

    While looking at #16838 I found at least two cases of sed patching in depends that now seems to be redundant. There's possibly a third case, but I haven't looked into that enough yet.

    Patching 0 -> kCGMouseButtonLeft should not be required, as kCGMouseButtonLeft has been used in the cocoa/qcocoacursor.mm source for a while.

    The include we were modifying in src/plugins/platforms/xcb/qxcbxsettings.cpp was removed in this commit.

  2. build: remove unnecessary macOS qt patching
    Patching in kCGMouseButtonLeft should not be required.

Looks like this hasn't been needed since qt 5.5 or so:
https://codereview.qt-project.org/c/qt/qtbase/+/115138
    4d45577c43
  3. build: remove unnecessary qt xcb patching
    The lines that this sed command was modifying were removed some time
ago. Relevant upstream change:

https://code.qt.io/cgit/qt/qtbase.git/commit/src/plugins/platforms/xcb/qxcbxsettings.cpp?id=538b9f504c0de11c473a40aed66df9900ac1c6c4
    93995c2751
  4. fanquake added the label Build system on Sep 16, 2019
  5. fanquake added the label Needs gitian build on Sep 16, 2019
  6. fanquake requested review from dongcarl on Sep 16, 2019
  7. laanwj commented at 10:36 AM on September 16, 2019: member

    Concept ACK

  8. practicalswift commented at 3:14 PM on September 16, 2019: contributor

    Concept ACK

    Thanks for removing all this old cruft in the build system.

  9. dongcarl commented at 3:59 PM on September 16, 2019: member

    ACK 93995c27515aa268c2c1aefe82f1a3cee33966ce

    Tested by running a Guix build.

  10. DrahtBot commented at 3:08 PM on September 17, 2019: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit 796b71363396e2ac99d241f5975c0978cdae3d67 (master):

    Gitian builds for commit dd3c7e95503d0bb28e78d0cc0dd659c0838fc93c (master and this pull):

  11. DrahtBot removed the label Needs gitian build on Sep 17, 2019
  12. fanquake referenced this in commit cc1d7fd57c on Sep 18, 2019
  13. fanquake merged this on Sep 18, 2019
  14. fanquake closed this on Sep 18, 2019
  15. sidhujag referenced this in commit ccbf64836d on Sep 23, 2019
  16. fanquake deleted the branch on Oct 21, 2019
  17. deadalnix referenced this in commit 8f416a686e on Apr 3, 2020
  18. ftrader referenced this in commit f7cdfc542d on Aug 17, 2020
  19. PastaPastaPasta referenced this in commit cad871801d on Jun 27, 2021
  20. PastaPastaPasta referenced this in commit 512b60afdc on Jun 28, 2021
  21. PastaPastaPasta referenced this in commit eaa3781020 on Jun 29, 2021
  22. PastaPastaPasta referenced this in commit 3a73302be0 on Jul 1, 2021
  23. PastaPastaPasta referenced this in commit 8424bfff25 on Jul 1, 2021
  24. PastaPastaPasta referenced this in commit 768c1d46e0 on Jul 12, 2021
  25. PastaPastaPasta referenced this in commit 6638fa763c on Jul 13, 2021
  26. DrahtBot locked this on Dec 16, 2021
Contributors
fanquakelaanwjpracticalswiftdongcarlDrahtBot


dongcarl

Labels
Build system
Linked (view graph)
#16837 depends: qt: Fix {C{,XX},LD}FLAGS pickup#16838 depends: `sed` robustness
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 00:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me