build: make deploy on MacOS creates multiple products #16909

issue ch4ot1c opened this issue on September 18, 2019

ch4ot1c commented at 9:06 PM on September 18, 2019: contributor
On MacOS 10.15 Beta, I ran make deploy, expecting to have an output of Bitcoin-Core.dmg per contrib/macdeploy/README, but instead get 3 other products -
- Bitcoin Core.app
- Bitcoin-Qt.dmg
- dist/Bitcoin Core.app
Should the .dmg be renamed?
ch4ot1c added the label Bug on Sep 18, 2019
fanquake added the label macOS on Sep 18, 2019
za-kk commented at 9:16 AM on September 22, 2019: contributor
Tested this on similar specs (macOS Mojave) and also getting the same 3 files when running make deploy (Bitcoin Core.app, dist/Bitcoin Core.app and Bitcoin-Qt.dmg).

Perhaps the contrib/macdeploy/README should be updated instead of renaming the .dmg?

Software Specs:
```
ProductName:    macOS Mojave
ProductVersion: 10.14.6
BuildVersion:   18G87
```
fanquake referenced this in commit c787556403 on Oct 15, 2019
fanquake commented at 9:04 PM on October 15, 2019: member

Closing, as the .dmg was renamed in #17142.
fanquake closed this on Oct 15, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels