docs: Update macdeploy README to include all files produced by `make deploy` #17142

pull za-kk wants to merge 1 commits into bitcoin:master from za-kk:master changing 1 files +1 −1

za-kk commented at 10:27 PM on October 14, 2019: contributor
Fixes issue #16909 to update the contrib/macdeploy/README.md to match the files produced from make deploy

The files produced from make deploy are as follows:
- Bitcoin-Qt.dmg
- Bitcoin Core.app
- dist/Bitcoin Core.app
fanquake added the label Docs on Oct 14, 2019
fanquake renamed this:
~~Update contrib/macdeploy/README.md to match files produced from `make deploy`~~
docs: Update macdeploy README to include all files produced by `make deploy`
on Oct 14, 2019

in contrib/macdeploy/README.md:14 in 2ba65ce7b2 outdated

  10 | @@ -11,5 +11,5 @@ This script should not be run manually, instead, after building as usual:
  11 |  During the process, the disk image window will pop up briefly where the fancy
  12 |  settings are applied. This is normal, please do not interfere.
  13 |  
  14 | -When finished, it will produce `Bitcoin-Core.dmg`.
  15 | +When finished, it will produce `Bitcoin-QT.dmg`, `Bitcoin Core.app` and `dist/Bitcoin Core.app`.

fanquake commented at 10:32 PM on October 14, 2019:

s/Bitcoin-QT.dmg/Bitcoin-Qt.dmg/

za-kk commented at 11:49 PM on October 14, 2019:

Updated, thanks 👍

fanquake commented at 10:32 PM on October 14, 2019: member

Thanks. Can you please update your commit message to something like the PR title.
in contrib/macdeploy/README.md:14 in 1220dfdd58 outdated
```
  10 | @@ -11,5 +11,5 @@ This script should not be run manually, instead, after building as usual:
  11 |  During the process, the disk image window will pop up briefly where the fancy
  12 |  settings are applied. This is normal, please do not interfere.
  13 |  
  14 | -When finished, it will produce `Bitcoin-Core.dmg`.
  15 | +When finished, it will produce `Bitcoin-Qt.dmg`, `Bitcoin Core.app` and `dist/Bitcoin Core.app`.
```
laanwj commented at 6:18 AM on October 15, 2019:

Two .apps? Is this intentional?

laanwj commented at 6:19 AM on October 15, 2019:

I think it'd make sense to make this a list, and describe what each item is (and what the differences are)

za-kk commented at 7:26 AM on October 15, 2019:

The two .app files were intentional as both are created, one in the root folder and the other is in the dist.

I am unsure of the differences between these two .app files, so any insight into this would be appreciated

laanwj commented at 9:58 AM on October 15, 2019:

OK—I think there's a misunderstanding about the purpose of this documentation. The idea here is not to list every intermediate that will be included in the image, but only the end product of the macdeploy (the .dmg image). If the purpose of the intermediate files is not clear, better to not list them.

za-kk commented at 10:19 AM on October 15, 2019:

Okay thanks @laanwj, I will reverse the change back to just listing the .dmg file as suggested and keep the filename change to match what is actually produced from make deploy (Bitcoin-Qt.dmg)

za-kk commented at 10:35 AM on October 15, 2019:

Done and squashed the commits 👍
laanwj added the label Build system on Oct 15, 2019
Update macdeploy README to include correctly named `.dmg` file produced from `make deploy` 4441e58497
za-kk requested review from laanwj on Oct 15, 2019
jonasschnelli added the label macOS on Oct 15, 2019
jonasschnelli commented at 1:15 PM on October 15, 2019: contributor

ACK 4441e58497513cc55cfebfdcaaeee340f62f8062
fanquake commented at 1:25 PM on October 15, 2019: member

ACK 4441e58497513cc55cfebfdcaaeee340f62f8062 - checked that Bitcoin-Qt.dmg is produced.
fanquake referenced this in commit c787556403 on Oct 15, 2019
fanquake merged this on Oct 15, 2019
fanquake closed this on Oct 15, 2019
MarcoFalke locked this on Dec 16, 2021

Contributors

Review Requested
laanwj

Labels

Docs macOS Build system

Linked (view graph)

#16909 build: make deploy on MacOS creates multiple products