doc: Document MemPoolAccept::Finalize(...) precondition #16915

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:clarify-mempoolaccept-finalize-assumptions changing 1 files +2 −1

practicalswift commented at 8:44 AM on September 19, 2019: contributor

Document MemPoolAccept::Finalize(...) precondition.

Context: A quick look at ...

$ git grep m_conflicting_size
src/validation.cpp:        size_t m_conflicting_size;
src/validation.cpp:    size_t& nConflictingSize = ws.m_conflicting_size;
src/validation.cpp:    const size_t& nConflictingSize = ws.m_conflicting_size;

... might look like an uninitialized read (which it is not) :)

fanquake added the label Docs on Sep 19, 2019
MarcoFalke commented at 1:20 PM on September 19, 2019: member

Fine, but I don't think we need the same comment in three places. One should be enough
doc: Document how members of struct Workspace are initialized 3bd91dd90c
practicalswift force-pushed on Sep 19, 2019
practicalswift commented at 8:46 PM on September 19, 2019: contributor

@MarcoFalke Feedback addressed. Please re-review :)
practicalswift commented at 8:20 AM on September 26, 2019: contributor

@MarcoFalke @fanquake Would you mind reviewing? :)
MarcoFalke commented at 8:34 PM on October 11, 2019: member

ACK 3bd91dd90c1b38ba2d15329795ebe21249ee2ceb
MarcoFalke commented at 8:34 PM on October 11, 2019: member

cc @sdaftuar
practicalswift commented at 7:18 PM on November 11, 2019: contributor

Ready for merge? :)
practicalswift closed this on Nov 14, 2019
practicalswift deleted the branch on Apr 10, 2021
DrahtBot locked this on Aug 18, 2022

Contributors

practicalswift

MarcoFalke

Labels

Docs