This prevents the common annoyance of the text being included into PRs accidentally.
doc: Put PR template in comments #16962
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2019_09_pr_template_comment changing 1 files +9 −1-
laanwj commented at 9:33 AM on September 25, 2019: member
- laanwj added the label Docs on Sep 25, 2019
-
promag commented at 9:35 AM on September 25, 2019: member
ACK
-
practicalswift commented at 10:44 AM on September 25, 2019: contributor
ACK 187c27ec56dfa3fce672ee75665b9776c10f8e0f
-
michaelfolkson commented at 11:14 AM on September 25, 2019: contributor
ACK 187c27ec56dfa3fce672ee75665b9776c10f8e0f
-
MarcoFalke commented at 12:09 PM on September 25, 2019: member
It will still be included in the pull (commented out) and then end up in the merge commit
-
MarcoFalke commented at 12:09 PM on September 25, 2019: member
So -0
-
laanwj commented at 1:34 PM on September 25, 2019: member
It will still be included in the pull (commented out) and then end up in the merge commit
I'll add an explicit comment to remove it. And if it's still a problem we can change github-merge.py to filter out HTML comments.
I think this is a lot better experience when submitting a PR, I still hope people will remove it, but even so it makes it easier to distinguish the commit message from the template stuff. Currently this text it simply pasted after and it's somewhat surprising.
-
203a67d21f
doc: Put PR template in comments
This prevents the common annoyance of the text being included into PRs accidentally.
- laanwj force-pushed on Sep 25, 2019
-
sdaftuar commented at 2:18 PM on September 25, 2019: member
utACK 203a67d21f566634165531a7a75c3f8c9f9c9d6a
- fanquake approved
-
fanquake commented at 8:43 AM on September 26, 2019: member
ACK 203a67d21f566634165531a7a75c3f8c9f9c9d6a - I make an effort to remove it whenever I see it in a PR.
- laanwj referenced this in commit 942e275018 on Sep 30, 2019
- laanwj merged this on Sep 30, 2019
- laanwj closed this on Sep 30, 2019
- sidhujag referenced this in commit 2431bb0c46 on Oct 2, 2019
- PastaPastaPasta referenced this in commit 1eee6dda36 on Jun 27, 2021
- PastaPastaPasta referenced this in commit 92f931babf on Jun 28, 2021
- PastaPastaPasta referenced this in commit 6325bd8d39 on Jun 29, 2021
- PastaPastaPasta referenced this in commit 7d4e94d908 on Jul 1, 2021
- PastaPastaPasta referenced this in commit 20cc7f1388 on Jul 1, 2021
- PastaPastaPasta referenced this in commit b698e40c0c on Jul 12, 2021
- PastaPastaPasta referenced this in commit 9e9ac972c3 on Jul 13, 2021
- PastaPastaPasta referenced this in commit 68810e8e57 on Jul 13, 2021
- DrahtBot locked this on Dec 16, 2021
Labels