qa: Explain QT_QPA_PLATFORM for gui tests #17015

1. 
   MarcoFalke commented at 8:07 PM on October 1, 2019: member

   Closes #17013

2. doc: Explain QT_QPA_PLATFORM for gui tests faccf5f9c8
3. MarcoFalke added this to the milestone 0.19.0 on Oct 1, 2019
4. DrahtBot added the label Docs on Oct 1, 2019
5. DrahtBot added the label GUI on Oct 1, 2019
6. DrahtBot added the label Tests on Oct 1, 2019
7. Sjors approved
8. 
   Sjors commented at 8:26 PM on October 1, 2019: member

   Code review ACK faccf5f, and tested QT_QPA_PLATFORM=cocoa on macOS.

9. in src/qt/test/test_main.cpp:64 in faccf5f9c8 outdated

     62 | @@ -63,7 +63,7 @@ int main(int argc, char *argv[])
     63 |      #if defined(WIN32)
     64 |          _putenv_s("QT_QPA_PLATFORM", "minimal");
   

   ---

   ---

   

   ryanofsky commented at 8:39 PM on October 1, 2019:

   Would suggest adding if (getenv("QT_QPA_PLATFORM") == nullptr) so the new instructions for setting QT_QPA_PLATFORM work on windows. Or, if you'd prefer to not change behavior in a documentation-only PR, you could add a // TODO: Fix this to not overwrite QT_QPA_PLATFORM if it is set externally comment

   ---

   

   MarcoFalke commented at 9:02 PM on October 1, 2019:

   Thx, added a commit and changed the pull request type to "qa"

10. ryanofsky approved
11. 
    ryanofsky commented at 8:43 PM on October 1, 2019: member

    utACK faccf5f9c899c40d4da5792629d0714249a4616b

12. MarcoFalke removed the label Docs on Oct 1, 2019
13. MarcoFalke renamed this:
    doc: Explain QT_QPA_PLATFORM for gui tests
    qa: Explain QT_QPA_PLATFORM for gui tests
    on Oct 1, 2019
14. qa: Do not force overwrite of QT_QPA_PLATFORM on windows for gui tests fa06bb607d
15. 
    promag commented at 9:17 PM on October 1, 2019: member

    ACK fa06bb607da2d3e35723661156d873c8eac1fa50.

16. jonasschnelli approved
17. 
    jonasschnelli commented at 9:38 PM on October 1, 2019: contributor

    ACK fa06bb60

18. ryanofsky approved
19. 
    ryanofsky commented at 10:31 PM on October 1, 2019: member

    utACK fa06bb607da2d3e35723661156d873c8eac1fa50

20. fanquake approved
21. 
    fanquake commented at 11:32 PM on October 1, 2019: member

    ACK fa06bb607da2d3e35723661156d873c8eac1fa50 - tested on macOS using QT_QPA_PLATFORM=cocoa src/qt/test/test_bitcoin-qt.

22. fanquake referenced this in commit dab0e36652 on Oct 1, 2019
23. fanquake merged this on Oct 1, 2019
24. fanquake closed this on Oct 1, 2019

    ---

25. MarcoFalke deleted the branch on Oct 2, 2019
26. jasonbcox referenced this in commit 3793705b7c on Oct 2, 2020
27. humbleDasher referenced this in commit dd37d5f947 on Dec 5, 2021
28. DrahtBot locked this on Dec 16, 2021

Contributors

MarcoFalkeSjorsryanofskypromagjonasschnellifanquake

Milestone
0.19.0