doc: fix Makefile target in benchmarking.md #17081

pull theStack wants to merge 1 commits into bitcoin:master from theStack:20191008-doc-fix_make_target_in_benchmarking_md changing 1 files +1 −1

theStack commented at 8:18 PM on October 8, 2019: member

While the resulting binary is called bench_bitcoin, the Makefile target is named bitcoin_bench (see src/Makefile.bench.include)

[doc] fix Makefile target in benchmarking.md

while the resulting binary is called `bench_bitcoin`, the Makefile target is
named `bitcoin_bench` (see `src/Makefile.bench.include`)

a54ab2104c

fanquake added the label Docs on Oct 8, 2019
fanquake renamed this:
~~[doc] fix Makefile target in benchmarking.md~~
doc: fix Makefile target in benchmarking.md
on Oct 8, 2019
in doc/benchmarking.md:14 in a54ab2104c
```
  10 | @@ -11,7 +11,7 @@ Running
  11 |  For benchmarks purposes you only need to compile `bitcoin_bench`. Beware of configuring without `--enable-debug` as this would impact
  12 |  benchmarking by unlatching log printers and lock analysis.
  13 |  
  14 | -    make -C src bench_bitcoin
  15 | +    make -C src bitcoin_bench
```
MarcoFalke commented at 8:47 PM on October 8, 2019:

Does make -C src bench work as well?

MarcoFalke commented at 8:48 PM on October 8, 2019:

Oh, I guess that also runs the bench

theStack commented at 9:16 PM on October 8, 2019:

Yes -- the target bench both builds and executes the benchmarks, bitcoin_bench only builds them.
fanquake approved
fanquake commented at 1:50 PM on October 9, 2019: member
ACK a54ab2104c82c41d17ca603999a9a03161eefc9e - Tested on macOS and Debian 9.9, as this only seemed to work there when these docs were added.

master (b1de33d29a2b8ca52fdc61c9969d14ae76154e63):
```
make -C src bench_bitcoin
make: *** No rule to make target `bench_bitcoin'.  Stop.
```
#17081 (a54ab2104c82c41d17ca603999a9a03161eefc9e):
```
make -C src bitcoin_bench
  CXX      bench/bench_bitcoin-bench_bitcoin.o
  CXX      bench/bench_bitcoin-bench.o
  CXX      bench/bench_bitcoin-block_assemble.o
...
```
fanquake referenced this in commit ceecefe0b0 on Oct 9, 2019
fanquake merged this on Oct 9, 2019
fanquake closed this on Oct 9, 2019
MarkLTZ referenced this in commit 8823f65197 on Apr 7, 2020
MarkLTZ referenced this in commit 0a1571d657 on Apr 7, 2020
theStack deleted the branch on Dec 1, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels