doc: Added instructions for how to add an upsteam to forked repo #17157

pull dannmat wants to merge 1 commits into bitcoin:master from dannmat:Oct-19-Contribution.mc changing 1 files +1 −1
  1. dannmat commented at 9:39 PM on October 15, 2019: none

    As a first time git developer, I struggled to understand whether to create a new fork for each pull request or not.

    After asking the IRC chat, I have added this to the documentation to further help new developers using git.

  2. fanquake added the label Docs on Oct 15, 2019
  3. kallewoof commented at 2:18 AM on October 16, 2019: member

    I'm not sure this belongs here. It looks like git/github documentation.

  4. dannmat commented at 7:12 AM on October 16, 2019: none

    I added it here because the instructions above it tell the user to

    1. fork
    2. branch
    3. commit

    but it's not clear that the first step should only be taken once and the user should add an upstream, so I was adding clarification.

  5. kallewoof commented at 7:38 AM on October 16, 2019: member

    Maybe change the "1" to something like "1. Fork repository (only the first time)".

  6. laanwj commented at 7:45 AM on October 16, 2019: member

    Maybe change the "1" to something like "1. Fork repository (only the first time)".

    +1 on this, better to integrate these kind of remarks into the process

  7. dannmat commented at 7:49 AM on October 16, 2019: none

    Yes will look neater, I'll do this later on tonight.

  8. carnhofdaki commented at 11:05 AM on October 16, 2019: contributor

    ACK

    This is about learning. When one learns something and someone else can learn from that, it improves us as a group. Welcome and all the best @dannmat ! @dannmat No need to change the patch but think of one more way to do it. More lazy than what is written in the linked GitHub's article. Hint: origin. Which repo is usually cloned first? (even before any change is done to the source code)

  9. dannmat commented at 11:21 AM on October 16, 2019: none

    Thanks! I'll have a read up on origin now!

  10. fanquake added the label Waiting for author on Oct 16, 2019
  11. dannmat force-pushed on Oct 16, 2019
  12. dannmat commented at 6:51 PM on October 16, 2019: none

    Changed and squashed

  13. fanquake removed the label Waiting for author on Oct 16, 2019
  14. carnhofdaki commented at 12:44 PM on October 17, 2019: contributor

    @dannmat Nice! Short and lean, though useful addition.

  15. in CONTRIBUTING.md:49 in 3d5f422577 outdated 
      45 | @@ -46,7 +46,7 @@ facilitates social contribution, easy testing and peer review.
  46 |  
  47 |  To contribute a patch, the workflow is as follows:
  48 |  
  49 | -  1. Fork repository
  50 | +  1. Fork repository [only first time](https://help.github.com/en/articles/configuring-a-remote-for-a-fork).
    fanquake commented at 6:48 PM on October 18, 2019:

    Can you change this to kallewoof's suggestion above.

      1. Fork repository ([only the first time](https://help.github.com/en/articles/configuring-a-remote-for-a-fork)).
  16. dannmat force-pushed on Oct 19, 2019
  17. dannmat commented at 9:59 AM on October 19, 2019: none

    Rebased and squashed

  18. in CONTRIBUTING.md:49 in 41d8ecbef7 outdated 
      45 | @@ -46,7 +46,7 @@ facilitates social contribution, easy testing and peer review.
  46 |  
  47 |  To contribute a patch, the workflow is as follows:
  48 |  
  49 | -  1. Fork repository
  50 | +  1. Fork repository ([only the first time](https://help.github.com/en/articles/configuring-a-remote-for-a-fork)).
    hebasto commented at 10:13 AM on October 20, 2019:

    Maybe link to https://help.github.com/en/articles/fork-a-repo is more relevant here?

    dannmat commented at 10:41 AM on October 20, 2019:

    Yes this is more relevant to the topic. I'll change this

  19. hebasto commented at 10:14 AM on October 20, 2019: member

    Concept ACK.

  20. doc: Added instructions for how to add an upsteam to forked repo
    As a first time git developer, I struggled to understand whether to create a new fork for each pull request or not.

After asking the IRC chat, I have added this to the documentation to further help new developers using git.

Co-Authored-By: Michael <fanquake@gmail.com>
    f09ba060ca
  21. dannmat force-pushed on Oct 20, 2019
  22. fanquake approved
  23. fanquake commented at 3:57 PM on October 20, 2019: member

    ACK f09ba060cacd42e4cb9a242c1d731deb1f6623c6 - For such a simple change, I think we've bike-shed this enough already. The bitcoin/bitcoin repo isn't really where anyone should be learning how to use git etc, but I think linking out here is ok.

  24. fanquake referenced this in commit b8f041af2d on Oct 20, 2019
  25. fanquake merged this on Oct 20, 2019
  26. fanquake closed this on Oct 20, 2019
  27. PastaPastaPasta referenced this in commit f4d9d95315 on Jun 27, 2021
  28. PastaPastaPasta referenced this in commit 842d6480aa on Jun 28, 2021
  29. PastaPastaPasta referenced this in commit 678163de3f on Jun 29, 2021
  30. PastaPastaPasta referenced this in commit e8b0161fd1 on Jul 1, 2021
  31. PastaPastaPasta referenced this in commit a5fab65c23 on Jul 1, 2021
  32. PastaPastaPasta referenced this in commit 967e8fa376 on Jul 12, 2021
  33. PastaPastaPasta referenced this in commit f6a60b520a on Jul 13, 2021
  34. PastaPastaPasta referenced this in commit 5857a5d5b4 on Jul 13, 2021
  35. DrahtBot locked this on Dec 16, 2021
Contributors
dannmatkallewooflaanwjcarnhofdakifanquakehebasto
Labels
Docs
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 18:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me