Windows installer properties and signing #17170

Downloaded bitcoin-0.19.0rc1-win64-setup.exe.

The Properties - Details tab lacks "File description" and "Copyright" values:

Also, the note that this exe file is signed by Bitcoin Core Code Signing Association could be mentioned somewhere in our docs.

The Properties - Details tab lacks "File description" and "Copyright" values:

See FileDescription in https://docs.microsoft.com/en-us/windows/win32/menurc/versioninfo-resource

Also, the note that this exe file is signed by Bitcoin Core Code Signing Association could be mentioned somewhere in our docs.

See here: #15682

See here: #15682

I knew it ;)

I mean providing info to an end user who downloads installer from bitcoincore.org (according to the principle of least astonishment). It could be readme.txt or release notes. No?

I think the name "Bitcoin Core Code Signing Association" is pretty self-explanatory and not surprising. No strong opinion, though.

I'm not sure this an actual problem that affects users. Please try to open issues for bugs and serious problems. (to be clear, feel free to open a PR to fix this, but opening an issue to track this seems pointless to me)

Agree with @laanwj . This can trivially be fixed by adding the FileDescription key to the rc files, no need to open a tracking issue.

Also, the note that this exe file is signed by Bitcoin Core Code Signing Association could be mentioned somewhere in our docs.

That would tie the project to the association closer than it currently is. Right now, anyone can sign...