Windows installer properties and signing #17170

issue hebasto opened this issue on October 17, 2019
  1. hebasto commented at 6:56 AM on October 17, 2019: member

    Downloaded bitcoin-0.19.0rc1-win64-setup.exe.

    The Properties - Details tab lacks "File description" and "Copyright" values:

    Screenshot from 2019-10-17 09-32-02

    Also, the note that this exe file is signed by Bitcoin Core Code Signing Association could be mentioned somewhere in our docs.

  2. hebasto renamed this:
    Windows *-setup.exe from bitcoincore.org
    Windows installer properties and signing
    on Oct 17, 2019
  3. fanquake added the label Windows on Oct 17, 2019
  4. MarcoFalke commented at 3:21 PM on October 17, 2019: member

    The Properties - Details tab lacks "File description" and "Copyright" values:

    See FileDescription in https://docs.microsoft.com/en-us/windows/win32/menurc/versioninfo-resource

    Also, the note that this exe file is signed by Bitcoin Core Code Signing Association could be mentioned somewhere in our docs.

    See here: #15682

  5. hebasto commented at 3:33 PM on October 17, 2019: member

    See here: #15682

    I knew it ;)

    I mean providing info to an end user who downloads installer from bitcoincore.org (according to the principle of least astonishment). It could be readme.txt or release notes. No?

  6. MarcoFalke commented at 3:42 PM on October 17, 2019: member

    I think the name "Bitcoin Core Code Signing Association" is pretty self-explanatory and not surprising. No strong opinion, though.

  7. laanwj commented at 6:57 PM on October 17, 2019: member

    I'm not sure this an actual problem that affects users. Please try to open issues for bugs and serious problems. (to be clear, feel free to open a PR to fix this, but opening an issue to track this seems pointless to me)

  8. MarcoFalke commented at 7:04 PM on October 17, 2019: member

    Agree with @laanwj . This can trivially be fixed by adding the FileDescription key to the rc files, no need to open a tracking issue.

  9. luke-jr commented at 6:06 AM on February 4, 2020: member

    Also, the note that this exe file is signed by Bitcoin Core Code Signing Association could be mentioned somewhere in our docs.

    That would tie the project to the association closer than it currently is. Right now, anyone can sign...

  10. fanquake closed this on Feb 5, 2020

  11. PastaPastaPasta referenced this in commit bb142df26b on Jun 27, 2021
  12. PastaPastaPasta referenced this in commit c42a1d225f on Jun 28, 2021
  13. PastaPastaPasta referenced this in commit ff1de6382f on Jun 29, 2021
  14. PastaPastaPasta referenced this in commit 581d5408ad on Jul 1, 2021
  15. PastaPastaPasta referenced this in commit 9ccdb9c42e on Jul 1, 2021
  16. PastaPastaPasta referenced this in commit b3ff351c68 on Jul 14, 2021
  17. PastaPastaPasta referenced this in commit 1340a51e1b on Jul 14, 2021
  18. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 03:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me